From: Greg KH <gregkh@linuxfoundation.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-staging@lists.linux.dev
Subject: Re: [PATCH -next] staging: ks7010: remove unnecessary sdio_set_drvdata() function
Date: Fri, 11 Aug 2023 22:38:37 +0200 [thread overview]
Message-ID: <2023081141-customary-abstain-e0c4@gregkh> (raw)
In-Reply-To: <20230811091736.887120-1-yangyingliang@huawei.com>
On Fri, Aug 11, 2023 at 05:17:36PM +0800, Yang Yingliang wrote:
> The driver data will be cleared in device_unbind_cleanup() in driver
> core code. So the sdio_set_drvdata(..., NULL) called in remove and
> error path in probe can be removed.
Yes, but, many things happen after the remove function is called and the
driver core cleans up that field, so are you SURE that it is safe to
make these kinds of changes?
How have you tested all of these?
thanks,
greg k-h
prev parent reply other threads:[~2023-08-11 20:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 9:17 [PATCH -next] staging: ks7010: remove unnecessary sdio_set_drvdata() function Yang Yingliang
2023-08-11 20:38 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023081141-customary-abstain-e0c4@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox