From: Greg KH <gregkh@linuxfoundation.org>
To: Tree Davies <tdavies@darkphysics.net>
Cc: philipp.g.hortmann@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] Staging: rtl8192e: Rename variable pBa in function rx_ts_delete_ba()
Date: Sun, 13 Aug 2023 08:54:13 +0200 [thread overview]
Message-ID: <2023081344-graveyard-frivolous-7d98@gregkh> (raw)
In-Reply-To: <20230813065035.95157-2-tdavies@darkphysics.net>
On Sat, Aug 12, 2023 at 11:50:30PM -0700, Tree Davies wrote:
> Rename variable pBa in function rx_ts_delete_ba() to rx_ts
> to fix checkpatch warning Avoid CamelCase.
>
> Signed-off-by: Tree Davies <tdavies@darkphysics.net>
> ---
> v2:Resending in smaller patch series
> drivers/staging/rtl8192e/rtl819x_BAProc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> index 0e3372868f97..1eff30533f47 100644
> --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> @@ -41,9 +41,9 @@ static u8 tx_ts_delete_ba(struct rtllib_device *ieee, struct tx_ts_record *pTxTs
> return bSendDELBA;
> }
>
> -static u8 rx_ts_delete_ba(struct rtllib_device *ieee, struct rx_ts_record *pRxTs)
> +static u8 rx_ts_delete_ba(struct rtllib_device *ieee, struct rx_ts_record *rx_ts)
> {
> - struct ba_record *pBa = &pRxTs->rx_admitted_ba_record;
> + struct ba_record *pBa = &rx_ts->rx_admitted_ba_record;
I think your description is wrong here, you are not renaming the pBa
variable.
thanks,
greg k-h
next prev parent reply other threads:[~2023-08-13 6:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-13 6:50 [PATCH 0/6] Staging: rtl8192e: Series-A Rename struct rx_ts_record references Tree Davies
2023-08-13 6:50 ` [PATCH v2 1/6] Staging: rtl8192e: Rename variable pBa in function rx_ts_delete_ba() Tree Davies
2023-08-13 6:54 ` Greg KH [this message]
2023-08-13 6:50 ` [PATCH v2 2/6] Staging: rtl8192e: Rename variable pTS in function rtllib_rx_ADDBAReq() Tree Davies
2023-08-13 6:55 ` Greg KH
2023-08-13 7:11 ` Tree Davies
2023-08-13 6:50 ` [PATCH v2 3/6] Staging: rtl8192e: Rename variable pRxTs in function rtllib_rx_DELBA() Tree Davies
2023-08-13 6:50 ` [PATCH v2 4/6] Staging: rtl8192e: Rename variable pRxTs in function rtllib_ts_init_del_ba() Tree Davies
2023-08-13 6:50 ` [PATCH v2 5/6] Staging: rtl8192e: Rename variable pRxTs in function rtllib_rx_ba_inact_timeout() Tree Davies
2023-08-13 6:50 ` [PATCH v2 6/6] Staging: rtl8192e: Rename variable pRxTs in function RxPktPendingTimeout() Tree Davies
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023081344-graveyard-frivolous-7d98@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
--cc=tdavies@darkphysics.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox