Re: [PATCH v2] staging: vt6655: replace camel case by snake case

Pavan Bobba
2023-08-23T13:32:45Z

On Wed, Aug 23, 2023 at 02:58:38PM +0200, Julia Lawall wrote:
>
> > }
> > - if ((wDelay < W_MAX_TIMEOUT) &&
> > - (!(byWait & I2MCSR_NACK))) {
> > + if ((delay < W_MAX_TIMEOUT) &&
>
> Maybe the W_ should also be dropped?
even non staging driver have this
https://elixir.bootlin.com/linux/v6.5-rc7/source/drivers/net/ethernet/via/via-velocity.h#L959

> > * Out:
> > - * pbyEepromRegs - EEPROM content Buffer
> > + * eepromregs - EEPROM content Buffer
>
> Here you could add some spaces to get the - EEPROM to line up with the
> rest. Likewise later.
>
> julia

ok

> > *
> > * Return Value: none
> > *
> > */
> > -void SROMvReadAllContents(void __iomem *iobase, unsigned char *pbyEepromRegs)
> > +void SROMvReadAllContents(void __iomem *iobase, unsigned char *eepromregs)
> > {
> > int ii;
> >
> > /* ii = Rom Address */
> > for (ii = 0; ii < EEP_MAX_CONTEXT_SIZE; ii++) {
> > - *pbyEepromRegs = SROMbyReadEmbedded(iobase,
> > + *eepromregs = SROMbyReadEmbedded(iobase,
> > (unsigned char)ii);
> > - pbyEepromRegs++;
> > + eepromregs++;
> > }
> > }
> >
> > @@ -122,19 +122,19 @@ void SROMvReadAllContents(void __iomem *iobase, unsigned char *pbyEepromRegs)
> > * In:
> > * iobase - I/O base address
> > * Out:
> > - * pbyEtherAddress - Ethernet Address buffer
> > + * etheraddress - Ethernet Address buffer
> > *
> > * Return Value: none
> > *
> > */
> > }
> > }
> > --
> > 2.34.1
> >
> >
> >