From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D417C137A for ; Sun, 27 Aug 2023 13:27:08 +0000 (UTC) Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-400e8ab9325so7679645e9.1 for ; Sun, 27 Aug 2023 06:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693142827; x=1693747627; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=q6sLDsBM3SAzSIk/9s8j5DkZWsAjuzBKZnQbC8hmoRw=; b=OBtIR8Ou680PclG8/4zyKtzBbSO0Trn3da/2JCkmSCR6vBcku2OsxRKPMhXNDNbFhk r6PuCRs1ACRngsRrF8NUBaqw+bneZrKyotc8fShw8EyYMmkVXft6QkTZ3v/1eVEFycSb hls+n5tAufuwckFDpwrU3POCh4kzvNiWtzZ8iabIharEmAMZHIDQRc9NxUZgmHrlBfZ/ URdwhJqyRM+lWIP2cssszhBVMdZKMhC404rS0XQC0Ayi2VAYOWRgA5AhmMzX9mO4cUMC b/eJPqtFpJqjaUap1PjMnmvfSfqJCG5QwecZMU4We44JsOOmvUHwHL4GfHrouLZ82bhI oFyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693142827; x=1693747627; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q6sLDsBM3SAzSIk/9s8j5DkZWsAjuzBKZnQbC8hmoRw=; b=O5f5AL9dFcAZCwYkmWHNqNQd1H+391m/+9ZW+mKz4Jwtr0zHVMoDtmR27iRRmPd1Vy pa2AuF/z23fs5A7V4u9dPGpZEbwqbMwPakDuAxB6pQ4/0uXv1FVhW0czCDJQXigneVz5 q+HW0lOJBihfz0nha4/bKtukvms/l4h3Yy3wcCFjdZz11T6dppW7BuL/ghDVZSpaZton hMwU1p5bm5ojYgfKco6lB4Mdbh7s/wPfB2DlvxMQaU6VIbPJuBLWKUEk4ompIX8tYOu2 icdOV8zcYvn0CbAl3ZKEmy2ZKvohLdgGrdmjhXubuLGV+hxweo51ypWvpTLDknh2E0R0 nILQ== X-Gm-Message-State: AOJu0YwdZXI966eW2kSrC+XHAewb1+J/xsXVhfEDw6N/BDod6yWx2LQI oh/bOfqwdgSHqVrcb6b6as8= X-Google-Smtp-Source: AGHT+IGTGqLCV/QwDDyrKOss383GlZ0N8H5bi13noXwZAEByQAc/inqAd/FeA2tqryFPCpu0gaKcCA== X-Received: by 2002:a5d:65c5:0:b0:319:8dcf:5c10 with SMTP id e5-20020a5d65c5000000b003198dcf5c10mr16624350wrw.6.1693142826571; Sun, 27 Aug 2023 06:27:06 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p579356c7.dip0.t-ipconnect.de. [87.147.86.199]) by smtp.gmail.com with ESMTPSA id j11-20020adfe50b000000b003143867d2ebsm7642369wrm.63.2023.08.27.06.27.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Aug 2023 06:27:06 -0700 (PDT) Date: Sun, 27 Aug 2023 15:27:04 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] staging: rtl8192e: Remove unsupported mode IW_MODE_ADHOC Message-ID: <20230827132704.GA12506@matrix-ESPRIMO-P710> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Remove unsupported mode IW_MODE_ADHOC because this mode is only partially coded in the driver. rtllib_rx_mgt() can only handle probe requests in IW_MODE_ADHOC and no authentication or association frames. Signed-off-by: Philipp Hortmann --- The only feature that is partially working in IW_MODE_ADHOC mode are beacons. Older Android Smartphones can see the beacons but Ubuntu 22.04 and Windows 11 not. No Device is able to connect. Debug code shows that only frames with ff:ff:ff:ff:ff:ff in addr1 field reach rtllib_rx_InfraAdhoc() when in IW_MODE_ADHOC mode. Using wireshark to monitor packets shows beacons and probe requests and probe responses but no further traffic. When this patch is accepted approximately 600 lines of code can be removed from the driver. Tested with rtl8192e (WLL6130-D99) in Mode n (12.5 MB/s) Transferred this patch over wlan connection of rtl8192e. --- drivers/staging/rtl8192e/rtllib_softmac_wx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/staging/rtl8192e/rtllib_softmac_wx.c index 0b690f0ffeef..48703d93df30 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c +++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c @@ -258,7 +258,6 @@ int rtllib_wx_set_mode(struct rtllib_device *ieee, struct iw_request_info *a, mutex_lock(&ieee->wx_mutex); switch (wrqu->mode) { case IW_MODE_MONITOR: - case IW_MODE_ADHOC: case IW_MODE_INFRA: break; case IW_MODE_AUTO: -- 2.41.0