From: Greg KH <gregkh@linuxfoundation.org>
To: Jonathan Bergh <bergh.jonathan@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vme_user: Add missing '*' in multiline comments
Date: Sun, 3 Sep 2023 16:43:15 +0200 [thread overview]
Message-ID: <2023090301-emission-scarce-8272@gregkh> (raw)
In-Reply-To: <20230903140617.567850-1-bergh.jonathan@gmail.com>
On Sun, Sep 03, 2023 at 04:06:17PM +0200, Jonathan Bergh wrote:
> This patch resolves a warning reported by checkpatch where multiline
> block comments should use '*' on intermediate lines in order to adhere
> to the Linux kernel coding-style guidelines.
>
> Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com>
> ---
> drivers/staging/vme_user/vme_fake.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c
> index 7c53a8a7b79b..90aaf650524d 100644
> --- a/drivers/staging/vme_user/vme_fake.c
> +++ b/drivers/staging/vme_user/vme_fake.c
> @@ -1010,8 +1010,8 @@ static void fake_free_consistent(struct device *parent, size_t size,
> {
> kfree(vaddr);
> /*
> - dma_free_coherent(parent, size, vaddr, dma);
> -*/
> + * dma_free_coherent(parent, size, vaddr, dma);
> + */
As this code isn't being used, why not just delete it instead?
thanks,
greg k-h
next prev parent reply other threads:[~2023-09-03 14:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-03 14:06 [PATCH] staging: vme_user: Add missing '*' in multiline comments Jonathan Bergh
2023-09-03 14:43 ` Greg KH [this message]
2023-09-03 19:42 ` Jonathan Bergh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023090301-emission-scarce-8272@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bergh.jonathan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox