* [PATCH] staging: vme_user: Add missing '*' in multiline comments
@ 2023-09-03 14:06 Jonathan Bergh
2023-09-03 14:43 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Bergh @ 2023-09-03 14:06 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Jonathan Bergh
This patch resolves a warning reported by checkpatch where multiline
block comments should use '*' on intermediate lines in order to adhere
to the Linux kernel coding-style guidelines.
Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com>
---
drivers/staging/vme_user/vme_fake.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c
index 7c53a8a7b79b..90aaf650524d 100644
--- a/drivers/staging/vme_user/vme_fake.c
+++ b/drivers/staging/vme_user/vme_fake.c
@@ -1010,8 +1010,8 @@ static void fake_free_consistent(struct device *parent, size_t size,
{
kfree(vaddr);
/*
- dma_free_coherent(parent, size, vaddr, dma);
-*/
+ * dma_free_coherent(parent, size, vaddr, dma);
+ */
}
/*
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging: vme_user: Add missing '*' in multiline comments
2023-09-03 14:06 [PATCH] staging: vme_user: Add missing '*' in multiline comments Jonathan Bergh
@ 2023-09-03 14:43 ` Greg KH
2023-09-03 19:42 ` Jonathan Bergh
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2023-09-03 14:43 UTC (permalink / raw)
To: Jonathan Bergh; +Cc: linux-staging, linux-kernel
On Sun, Sep 03, 2023 at 04:06:17PM +0200, Jonathan Bergh wrote:
> This patch resolves a warning reported by checkpatch where multiline
> block comments should use '*' on intermediate lines in order to adhere
> to the Linux kernel coding-style guidelines.
>
> Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com>
> ---
> drivers/staging/vme_user/vme_fake.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c
> index 7c53a8a7b79b..90aaf650524d 100644
> --- a/drivers/staging/vme_user/vme_fake.c
> +++ b/drivers/staging/vme_user/vme_fake.c
> @@ -1010,8 +1010,8 @@ static void fake_free_consistent(struct device *parent, size_t size,
> {
> kfree(vaddr);
> /*
> - dma_free_coherent(parent, size, vaddr, dma);
> -*/
> + * dma_free_coherent(parent, size, vaddr, dma);
> + */
As this code isn't being used, why not just delete it instead?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: vme_user: Add missing '*' in multiline comments
2023-09-03 14:43 ` Greg KH
@ 2023-09-03 19:42 ` Jonathan Bergh
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Bergh @ 2023-09-03 19:42 UTC (permalink / raw)
To: Greg KH; +Cc: linux-staging, linux-kernel
Yes ... that would be better.
On Sun, Sep 3, 2023 at 4:43 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Sun, Sep 03, 2023 at 04:06:17PM +0200, Jonathan Bergh wrote:
> > This patch resolves a warning reported by checkpatch where multiline
> > block comments should use '*' on intermediate lines in order to adhere
> > to the Linux kernel coding-style guidelines.
> >
> > Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com>
> > ---
> > drivers/staging/vme_user/vme_fake.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c
> > index 7c53a8a7b79b..90aaf650524d 100644
> > --- a/drivers/staging/vme_user/vme_fake.c
> > +++ b/drivers/staging/vme_user/vme_fake.c
> > @@ -1010,8 +1010,8 @@ static void fake_free_consistent(struct device *parent, size_t size,
> > {
> > kfree(vaddr);
> > /*
> > - dma_free_coherent(parent, size, vaddr, dma);
> > -*/
> > + * dma_free_coherent(parent, size, vaddr, dma);
> > + */
>
> As this code isn't being used, why not just delete it instead?
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-03 19:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-03 14:06 [PATCH] staging: vme_user: Add missing '*' in multiline comments Jonathan Bergh
2023-09-03 14:43 ` Greg KH
2023-09-03 19:42 ` Jonathan Bergh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox