From: Greg KH <gregkh@linuxfoundation.org>
To: Jonathan Bergh <bergh.jonathan@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: Fixed some formatting warnings in the vme_user driver
Date: Sun, 3 Sep 2023 11:39:58 +0200 [thread overview]
Message-ID: <2023090349-fresh-empirical-425d@gregkh> (raw)
In-Reply-To: <CA+MPq=VjvQSmY_coVxrmisXavgaZa78ram-SH2pHvOZ=AvaqRQ@mail.gmail.com>
On Sun, Sep 03, 2023 at 11:17:41AM +0200, Jonathan Bergh wrote:
> Hi Greg,
> I hope you are well. I got this response from your bot!
> I pretty much followed your FOSDEM instructions for *first kernel
> patches* so i thought I was doing it right.
That's a really old talk, things have changed a bit since then :)
> Based on the video of your talk, is more required in the SUBJECT and
> BODY for such a (basic) change? It seemed the above was pretty much
> inline with the terseness / examples you showed in your presentation.
> Hopefully thats the case.
Yes, you need a better changelog and subject line. Read the link that
the bot referred you to and look at all of the examples commits that
have been accepted for the files that you modified to give you an idea
of what is needed.
thanks,
greg k-h
next prev parent reply other threads:[~2023-09-03 9:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-03 8:22 [PATCH] Staging: Fixed some formatting warnings in the vme_user driver Jonathan Bergh
2023-09-03 8:32 ` Greg KH
2023-09-03 9:17 ` Jonathan Bergh
2023-09-03 9:39 ` Greg KH [this message]
2023-09-03 9:54 ` Jonathan Bergh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023090349-fresh-empirical-425d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bergh.jonathan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox