From: Umang Jain <umang.jain@ideasonboard.com>
To: linux-staging@lists.linux.dev,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: stefan.wahren@i2se.com, gregkh@linuxfoundation.org,
f.fainelli@gmail.com, athierry@redhat.com, error27@gmail.com,
kieran.bingham@ideasonboard.com,
laurent.pinchart@ideasonboard.com,
dave.stevenson@raspberrypi.com,
Umang Jain <umang.jain@ideasonboard.com>
Subject: [PATCH v10 5/5] staging: vc04_services: vchiq_arm: Remove vchiq_register_child()
Date: Mon, 11 Sep 2023 10:07:12 -0400 [thread overview]
Message-ID: <20230911140712.180751-6-umang.jain@ideasonboard.com> (raw)
In-Reply-To: <20230911140712.180751-1-umang.jain@ideasonboard.com>
vchiq_register_child() is used to registered child devices as platform
devices. Now that the child devices are migrated to use the
vchiq_bus_type instead, they will be registered to that. Hence, drop
vchiq_register_child() as it is no more required.
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
.../interface/vchiq_arm/vchiq_arm.c | 22 -------------------
1 file changed, 22 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
index 2da470740cda..5eccf5b277e5 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
@@ -1776,28 +1776,6 @@ static const struct of_device_id vchiq_of_match[] = {
};
MODULE_DEVICE_TABLE(of, vchiq_of_match);
-static struct platform_device *
-vchiq_register_child(struct platform_device *pdev, const char *name)
-{
- struct platform_device_info pdevinfo;
- struct platform_device *child;
-
- memset(&pdevinfo, 0, sizeof(pdevinfo));
-
- pdevinfo.parent = &pdev->dev;
- pdevinfo.name = name;
- pdevinfo.id = PLATFORM_DEVID_NONE;
- pdevinfo.dma_mask = DMA_BIT_MASK(32);
-
- child = platform_device_register_full(&pdevinfo);
- if (IS_ERR(child)) {
- dev_warn(&pdev->dev, "%s not registered\n", name);
- child = NULL;
- }
-
- return child;
-}
-
static int vchiq_probe(struct platform_device *pdev)
{
struct device_node *fw_node;
--
2.41.0
prev parent reply other threads:[~2023-09-11 14:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 14:07 [PATCH v10 0/5] staging: vc04_services: vchiq: Register devices with a custom bus_type Umang Jain
2023-09-11 14:07 ` [PATCH v10 1/5] staging: vc04_services: vchiq_arm: Add new bus type and device type Umang Jain
2023-09-11 20:22 ` Stefan Wahren
2023-09-12 5:50 ` Umang Jain
2023-09-12 7:23 ` Stefan Wahren
2023-09-13 11:31 ` Stefan Wahren
2023-09-13 12:08 ` Robin Murphy
2023-09-13 19:29 ` Umang Jain
2023-09-11 14:07 ` [PATCH v10 2/5] staging: vc04_services: vchiq_arm: Register vchiq_bus_type Umang Jain
2023-09-11 14:07 ` [PATCH v10 3/5] staging: bcm2835-camera: Register bcm2835-camera with vchiq_bus_type Umang Jain
2023-09-11 14:07 ` [PATCH v10 4/5] staging: bcm2835-audio: Register bcm2835-audio " Umang Jain
2023-09-11 14:07 ` Umang Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230911140712.180751-6-umang.jain@ideasonboard.com \
--to=umang.jain@ideasonboard.com \
--cc=athierry@redhat.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=error27@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox