Re: [PATCH v3 11/27] staging: iio: resolver: ad2s1210: add debugfs reg access

Jonathan Cameron
2023-09-30T14:52:44Z

On Fri, 29 Sep 2023 12:23:16 -0500
David Lechner <dlechner@baylibre.com> wrote:

> From: David Lechner <david@lechnology.com>
>
> From: David Lechner <dlechner@baylibre.com>
>
> This add an implementation of debugfs_reg_access for the AD2S1210
> driver.
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>

I never really care if a driver implements this or not.
However, if you find it useful that's fine, so applied.

Thanks,

Jonathan

> ---
>
> v3 changes: None
>
> drivers/staging/iio/resolver/ad2s1210.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c
> index 0663a51d04ad..31415fbb6384 100644
> --- a/drivers/staging/iio/resolver/ad2s1210.c
> +++ b/drivers/staging/iio/resolver/ad2s1210.c
> @@ -614,9 +614,29 @@ static int ad2s1210_initial(struct ad2s1210_state *st)
> return ret;
> }
>
> +static int ad2s1210_debugfs_reg_access(struct iio_dev *indio_dev,
> + unsigned int reg, unsigned int writeval,
> + unsigned int *readval)
> +{
> + struct ad2s1210_state *st = iio_priv(indio_dev);
> + int ret;
> +
> + mutex_lock(&st->lock);
> +
> + if (readval)
> + ret = regmap_read(st->regmap, reg, readval);
> + else
> + ret = regmap_write(st->regmap, reg, writeval);
> +
> + mutex_unlock(&st->lock);
> +
> + return ret;
> +}
> +
> static const struct iio_info ad2s1210_info = {
> .read_raw = ad2s1210_read_raw,
> .attrs = &ad2s1210_attribute_group,
> + .debugfs_reg_access = &ad2s1210_debugfs_reg_access,
> };
>
> static int ad2s1210_setup_clocks(struct ad2s1210_state *st)
>