Re: [PATCH v3 19/27] staging: iio: resolver: ad2s1210: add phase lock range support

Jonathan Cameron
2023-09-30T15:18:25Z

On Fri, 29 Sep 2023 12:23:24 -0500
David Lechner <dlechner@baylibre.com> wrote:

> From: David Lechner <david@lechnology.com>
>
> From: David Lechner <dlechner@baylibre.com>
>
> The AD2S1210 chip has a phase lock range feature that allows selecting
> the allowable phase difference between the excitation output and the
> sine and cosine inputs. This can be set to either 44 degrees (default)
> or 360 degrees.
>
> This patch adds a new phase channel with a threshold event that can be
> used to configure the phase lock range. Actually emitting the event
> will be added in a subsequent patch.
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
Looks good to me.