From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4ECCBD533 for ; Thu, 12 Oct 2023 07:59:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="V1zYE4tI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6B96C433C7; Thu, 12 Oct 2023 07:59:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697097555; bh=lhJ0mABYqusmJwDzlvcyUF3yYu3BzZ0v1uLfQprQBNs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=V1zYE4tIiqS5kPTew9ChTnNex2WSFFzks2Gb9aYTSNuV0stTrkyL5bUqMyUTFlxBp yqpSdE01jvChrNqEA19iQhfLhx9Y0XC+c9mODlbT0fPKuXV6ySqrIk3duNx2B1KL44 hXATxkv/7tOrvTtbgAN6mBv2kjHgFnJHXRY3K8YhCz8iZSe3LTI3CDAuVG4Wi8KylE mnpc5e58nJqjxlB5ELcOi3X2Z9e1FWuBgUxcYwxONXlgESSs+rgCv1eNgkTg4AyB1/ cG44q3DIYFb+/yueXP6QyiHM5sklWLkVJphbdnmbwpmcnjzGu9Jlxvb1SFCgZEcONh 5zChIRomWiRGg== Date: Thu, 12 Oct 2023 08:59:26 +0100 From: Jonathan Cameron To: David Lechner Cc: linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, Michael Hennerich , Nuno =?UTF-8?B?U8Oh?= , Axel Haslam , Philip Molloy , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/4] staging: iio: resolver: ad2s1210: clear faults after soft reset Message-ID: <20231012085926.2104251a@jic23-huawei> In-Reply-To: <20231010-ad2s1210-mainline-v5-2-35a0f6ffa04a@baylibre.com> References: <20231010-ad2s1210-mainline-v5-0-35a0f6ffa04a@baylibre.com> <20231010-ad2s1210-mainline-v5-2-35a0f6ffa04a@baylibre.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 10 Oct 2023 16:12:34 -0500 David Lechner wrote: > When a software reset is performed on the AD2S1210 to make the selected > excitation frequency take effect, it always triggers faults on the > input signals because the output signal is interrupted momentarily. > So we need to clear the faults after the software reset to avoid > triggering fault events the next time a sample is read. > > The datasheet specifies a time t[track] in Table 27 that specifies the > settle time in milliseconds after a reset depending on the selected > resolution. This is used in the driver to add an appropriate delay. > > Signed-off-by: David Lechner Applied