From: Soumya Negi <soumya.negi97@gmail.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Micky Ching <micky_ching@realsil.com.cn>,
outreachy@lists.linux.dev, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rts5208: Parenthesize macro arguments
Date: Thu, 12 Oct 2023 05:49:20 -0700 [thread overview]
Message-ID: <20231012124920.GA7107@Negi> (raw)
In-Reply-To: <a1556f74-83ef-d32-103d-6b0b0233473@inria.fr>
Hi Julia,
On Thu, Oct 12, 2023 at 09:51:27AM +0200, Julia Lawall wrote:
>
>
> On Thu, 12 Oct 2023, Soumya Negi wrote:
>
> > Hi Dan,
> > > For these ones, the name is too generic. probably the right thing is
> > > to just get rid of them completely and call spin_lock/unlock_irq()
> > > directly.
> >
> > I understand that there should be 2 different patches, one for the
> > macro-to-function rewrites & one for replacing the scsi lock/unlock macros with
> > direct spinlock calls. But, should these be in a patchset(they are vaguely
> > related since the patches together would get rid of the checkpatch warnings)?
> > I'm not sure.
>
> Patch set, since they affect the same file. Otherwise, Greg doesn't know
> in what order to apply them.
Thank you for explaining each point. I'm sending over the patch set for
review in a new email thread.
- Soumya
> julia
next prev parent reply other threads:[~2023-10-12 12:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 5:02 [PATCH] staging: rts5208: Parenthesize macro arguments Soumya Negi
2023-10-12 6:33 ` Dan Carpenter
2023-10-12 7:48 ` Soumya Negi
2023-10-12 7:51 ` Julia Lawall
2023-10-12 12:49 ` Soumya Negi [this message]
2023-10-12 13:03 ` Soumya Negi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231012124920.GA7107@Negi \
--to=soumya.negi97@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=micky_ching@realsil.com.cn \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox