linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH] tty: gdm724x: Match alignment with open parenthesis
@ 2023-10-13  6:01 Soumya Negi
  2023-10-13  6:42 ` Julia Lawall
  0 siblings, 1 reply; 3+ messages in thread
From: Soumya Negi @ 2023-10-13  6:01 UTC (permalink / raw)
  To: Jonathan Kim, Dean ahn, Greg Kroah-Hartman
  Cc: Soumya Negi, outreachy, linux-staging, linux-kernel

Fix CHECK: Alignment should match open parenthesis
Issue found by checkpatch.pl

Signed-off-by: Soumya Negi <soumya.negi97@gmail.com>
---
 drivers/staging/gdm724x/gdm_tty.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
index 32b2e817ff04..4e5cac76db58 100644
--- a/drivers/staging/gdm724x/gdm_tty.c
+++ b/drivers/staging/gdm724x/gdm_tty.c
@@ -271,8 +271,8 @@ int register_lte_tty_driver(void)
 	int ret;
 
 	for (i = 0; i < TTY_MAX_COUNT; i++) {
-		tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
-				TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV);
+		tty_driver = tty_alloc_driver(GDM_TTY_MINOR, TTY_DRIVER_REAL_RAW |
+					      TTY_DRIVER_DYNAMIC_DEV);
 		if (IS_ERR(tty_driver))
 			return PTR_ERR(tty_driver);
 
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] tty: gdm724x: Match alignment with open parenthesis
  2023-10-13  6:01 [PATCH] tty: gdm724x: Match alignment with open parenthesis Soumya Negi
@ 2023-10-13  6:42 ` Julia Lawall
  2023-10-13  7:48   ` Soumya Negi
  0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2023-10-13  6:42 UTC (permalink / raw)
  To: Soumya Negi
  Cc: Jonathan Kim, Dean ahn, Greg Kroah-Hartman, outreachy,
	linux-staging, linux-kernel

This and the next patch need to be in a series because they touch the same
file.

julia

On Thu, 12 Oct 2023, Soumya Negi wrote:

> Fix CHECK: Alignment should match open parenthesis
> Issue found by checkpatch.pl
>
> Signed-off-by: Soumya Negi <soumya.negi97@gmail.com>
> ---
>  drivers/staging/gdm724x/gdm_tty.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index 32b2e817ff04..4e5cac76db58 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -271,8 +271,8 @@ int register_lte_tty_driver(void)
>  	int ret;
>
>  	for (i = 0; i < TTY_MAX_COUNT; i++) {
> -		tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
> -				TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV);
> +		tty_driver = tty_alloc_driver(GDM_TTY_MINOR, TTY_DRIVER_REAL_RAW |
> +					      TTY_DRIVER_DYNAMIC_DEV);
>  		if (IS_ERR(tty_driver))
>  			return PTR_ERR(tty_driver);
>
> --
> 2.42.0
>
>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] tty: gdm724x: Match alignment with open parenthesis
  2023-10-13  6:42 ` Julia Lawall
@ 2023-10-13  7:48   ` Soumya Negi
  0 siblings, 0 replies; 3+ messages in thread
From: Soumya Negi @ 2023-10-13  7:48 UTC (permalink / raw)
  To: Julia Lawall
  Cc: Jonathan Kim, Dean ahn, Greg Kroah-Hartman, outreachy,
	linux-staging, linux-kernel

On Fri, Oct 13, 2023 at 08:42:42AM +0200, Julia Lawall wrote:
> This and the next patch need to be in a series because they touch the same
> file.
> 
> julia

Noted. Sending them as set.

> On Thu, 12 Oct 2023, Soumya Negi wrote:
> 
> > Fix CHECK: Alignment should match open parenthesis
> > Issue found by checkpatch.pl
> >
> > Signed-off-by: Soumya Negi <soumya.negi97@gmail.com>
> > ---
> >  drivers/staging/gdm724x/gdm_tty.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> > index 32b2e817ff04..4e5cac76db58 100644
> > --- a/drivers/staging/gdm724x/gdm_tty.c
> > +++ b/drivers/staging/gdm724x/gdm_tty.c
> > @@ -271,8 +271,8 @@ int register_lte_tty_driver(void)
> >  	int ret;
> >
> >  	for (i = 0; i < TTY_MAX_COUNT; i++) {
> > -		tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
> > -				TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV);
> > +		tty_driver = tty_alloc_driver(GDM_TTY_MINOR, TTY_DRIVER_REAL_RAW |
> > +					      TTY_DRIVER_DYNAMIC_DEV);
> >  		if (IS_ERR(tty_driver))
> >  			return PTR_ERR(tty_driver);
> >
> > --
> > 2.42.0
> >
> >
> >

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-10-13  7:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-13  6:01 [PATCH] tty: gdm724x: Match alignment with open parenthesis Soumya Negi
2023-10-13  6:42 ` Julia Lawall
2023-10-13  7:48   ` Soumya Negi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).