From: Soumya Negi <soumya.negi97@gmail.com>
To: Jonathan Kim <jonathankim@gctsemi.com>,
Dean ahn <deanahn@gctsemi.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: outreachy@lists.linux.dev, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: gdm724x: Add blank line after declaration
Date: Fri, 13 Oct 2023 00:50:24 -0700 [thread overview]
Message-ID: <20231013075024.GD13814@Negi> (raw)
In-Reply-To: <20231013060202.13419-1-soumya.negi97@gmail.com>
On Thu, Oct 12, 2023 at 11:01:57PM -0700, Soumya Negi wrote:
> Fix WARNING: Missing a blank line after declarations
> Issue found by checkpatch.pl
>
> Signed-off-by: Soumya Negi <soumya.negi97@gmail.com>
> ---
> drivers/staging/gdm724x/gdm_tty.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index 4e5cac76db58..0c61eaff6122 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -160,6 +160,7 @@ static ssize_t gdm_tty_write(struct tty_struct *tty, const u8 *buf, size_t len)
>
> while (remain) {
> size_t sending_len = min_t(size_t, MUX_TX_MAX_SIZE, remain);
> +
> gdm->tty_dev->send_func(gdm->tty_dev->priv_dev,
> (void *)(buf + sent_len),
> sending_len,
> --
Please ignore this patch. It must be sent as part of a patch set as
suggested by Julia. I'll be doing that shortly.
> 2.42.0
>
prev parent reply other threads:[~2023-10-13 7:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 6:01 [PATCH] tty: gdm724x: Add blank line after declaration Soumya Negi
2023-10-13 7:50 ` Soumya Negi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231013075024.GD13814@Negi \
--to=soumya.negi97@gmail.com \
--cc=deanahn@gctsemi.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathankim@gctsemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).