linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH] tty: gdm724x: Add blank line after declaration
@ 2023-10-13  6:01 Soumya Negi
  2023-10-13  7:50 ` Soumya Negi
  0 siblings, 1 reply; 2+ messages in thread
From: Soumya Negi @ 2023-10-13  6:01 UTC (permalink / raw)
  To: Jonathan Kim, Dean ahn, Greg Kroah-Hartman
  Cc: Soumya Negi, outreachy, linux-staging, linux-kernel

Fix WARNING: Missing a blank line after declarations
Issue found by checkpatch.pl

Signed-off-by: Soumya Negi <soumya.negi97@gmail.com>
---
 drivers/staging/gdm724x/gdm_tty.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
index 4e5cac76db58..0c61eaff6122 100644
--- a/drivers/staging/gdm724x/gdm_tty.c
+++ b/drivers/staging/gdm724x/gdm_tty.c
@@ -160,6 +160,7 @@ static ssize_t gdm_tty_write(struct tty_struct *tty, const u8 *buf, size_t len)
 
 	while (remain) {
 		size_t sending_len = min_t(size_t, MUX_TX_MAX_SIZE, remain);
+
 		gdm->tty_dev->send_func(gdm->tty_dev->priv_dev,
 					(void *)(buf + sent_len),
 					sending_len,
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] tty: gdm724x: Add blank line after declaration
  2023-10-13  6:01 [PATCH] tty: gdm724x: Add blank line after declaration Soumya Negi
@ 2023-10-13  7:50 ` Soumya Negi
  0 siblings, 0 replies; 2+ messages in thread
From: Soumya Negi @ 2023-10-13  7:50 UTC (permalink / raw)
  To: Jonathan Kim, Dean ahn, Greg Kroah-Hartman
  Cc: outreachy, linux-staging, linux-kernel

On Thu, Oct 12, 2023 at 11:01:57PM -0700, Soumya Negi wrote:
> Fix WARNING: Missing a blank line after declarations
> Issue found by checkpatch.pl
> 
> Signed-off-by: Soumya Negi <soumya.negi97@gmail.com>
> ---
>  drivers/staging/gdm724x/gdm_tty.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index 4e5cac76db58..0c61eaff6122 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -160,6 +160,7 @@ static ssize_t gdm_tty_write(struct tty_struct *tty, const u8 *buf, size_t len)
>  
>  	while (remain) {
>  		size_t sending_len = min_t(size_t, MUX_TX_MAX_SIZE, remain);
> +
>  		gdm->tty_dev->send_func(gdm->tty_dev->priv_dev,
>  					(void *)(buf + sent_len),
>  					sending_len,
> -- 

Please ignore this patch. It must be sent as part of a patch set as
suggested by Julia. I'll be doing that shortly.

> 2.42.0
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-10-13  7:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-13  6:01 [PATCH] tty: gdm724x: Add blank line after declaration Soumya Negi
2023-10-13  7:50 ` Soumya Negi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).