From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Soumya Negi <soumya.negi97@gmail.com>
Cc: Jonathan Kim <jonathankim@gctsemi.com>,
Dean ahn <deanahn@gctsemi.com>,
outreachy@lists.linux.dev, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] tty: gdm724x: Add blank line after declaration
Date: Sun, 15 Oct 2023 14:50:44 +0200 [thread overview]
Message-ID: <2023101508-curry-disorder-1b10@gregkh> (raw)
In-Reply-To: <20231015060716.GA31326@Negi>
On Sat, Oct 14, 2023 at 11:07:16PM -0700, Soumya Negi wrote:
> On Sun, Oct 15, 2023 at 07:37:30AM +0200, Greg Kroah-Hartman wrote:
> > On Fri, Oct 13, 2023 at 01:26:35AM -0700, Soumya Negi wrote:
> > > Fix WARNING: Missing a blank line after declarations
> > > Issue found by checkpatch.pl
> > >
> > > Signed-off-by: Soumya Negi <soumya.negi97@gmail.com>
> > > ---
> > > drivers/staging/gdm724x/gdm_tty.c | 1 +
> > > 1 file changed, 1 insertion(+)
> >
> > Why do you have "tty:" as the prefix for a staging driver? Shouldn't it
> > be "staging: gdm724x: ...."?
>
> Hi Greg,
>
> Thats what I thought too. But when I looked at the git history for
> gdm_tty.c the last few commits had "tty:". So I went with that.
That is because those commits were tty-wide, and they changed things in
multiple drivers all at once, not just for the one file.
> Should I change it to "staging:"?
Please do.
thanks,
greg k-h
next prev parent reply other threads:[~2023-10-15 12:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 8:26 [PATCH 0/2] tty: gdm724x: Fix coding style in gdm_tty.c Soumya Negi
2023-10-13 8:26 ` [PATCH 1/2] tty: gdm724x: Match alignment with open parenthesis Soumya Negi
2023-10-13 8:57 ` Dan Carpenter
2023-10-13 21:13 ` Soumya Negi
2023-10-14 7:38 ` Dan Carpenter
2023-10-20 2:14 ` Soumya Negi
2023-10-13 8:26 ` [PATCH 2/2] tty: gdm724x: Add blank line after declaration Soumya Negi
2023-10-15 5:37 ` Greg Kroah-Hartman
2023-10-15 6:07 ` Soumya Negi
2023-10-15 12:50 ` Greg Kroah-Hartman [this message]
2023-10-15 19:19 ` Soumya Negi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023101508-curry-disorder-1b10@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=deanahn@gctsemi.com \
--cc=jonathankim@gctsemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=soumya.negi97@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox