From: Greg KH <gregkh@linuxfoundation.org>
To: Gilbert Adikankwu <gilbertadikankwu@gmail.com>
Cc: outreachy@lists.linux.dev, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192u: Align descendant arguments
Date: Sun, 15 Oct 2023 18:09:47 +0200 [thread overview]
Message-ID: <2023101519-cane-backlands-b376@gregkh> (raw)
In-Reply-To: <ZSuYUmX5P5M0Ok/I@gilbert-PC>
On Sun, Oct 15, 2023 at 08:44:18AM +0100, Gilbert Adikankwu wrote:
> Adhere to Linux kernel coding style.
>
> "...A very commonly used style is to align descendants to a function
> open parenthesis" - (Excerpted from Linux kernel coding style (#2))
>
> Reported by checkpatch:
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Gilbert Adikankwu <gilbertadikankwu@gmail.com>
> ---
> drivers/staging/rtl8192u/r8180_93cx6.c | 4 ++--
> drivers/staging/rtl8192u/r8190_rtl8256.c | 16 +++++++--------
> drivers/staging/rtl8192u/r8192U_core.c | 20 +++++++++---------
> drivers/staging/rtl8192u/r8192U_dm.c | 24 +++++++++++-----------
> drivers/staging/rtl8192u/r819xU_firmware.c | 4 ++--
> drivers/staging/rtl8192u/r819xU_phy.c | 2 +-
> 6 files changed, 35 insertions(+), 35 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r8180_93cx6.c b/drivers/staging/rtl8192u/r8180_93cx6.c
> index 2527cea60e3e..1453a0307eb4 100644
> --- a/drivers/staging/rtl8192u/r8180_93cx6.c
> +++ b/drivers/staging/rtl8192u/r8180_93cx6.c
> @@ -114,7 +114,7 @@ int eprom_read(struct net_device *dev, u32 addr)
> ret = 0;
> /* enable EPROM programming */
> write_nic_byte_E(dev, EPROM_CMD,
> - (EPROM_CMD_PROGRAM << EPROM_CMD_OPERATING_MODE_SHIFT));
> + (EPROM_CMD_PROGRAM << EPROM_CMD_OPERATING_MODE_SHIFT));
> force_pci_posting(dev);
> udelay(EPROM_DELAY);
>
> @@ -165,6 +165,6 @@ int eprom_read(struct net_device *dev, u32 addr)
>
> /* disable EPROM programming */
> write_nic_byte_E(dev, EPROM_CMD,
> - (EPROM_CMD_NORMAL << EPROM_CMD_OPERATING_MODE_SHIFT));
> + (EPROM_CMD_NORMAL << EPROM_CMD_OPERATING_MODE_SHIFT));
> return ret;
> }
> diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c b/drivers/staging/rtl8192u/r8190_rtl8256.c
> index 54747fda552f..a81e88894e01 100644
> --- a/drivers/staging/rtl8192u/r8190_rtl8256.c
> +++ b/drivers/staging/rtl8192u/r8190_rtl8256.c
> @@ -46,17 +46,17 @@ void phy_set_rf8256_bandwidth(struct net_device *dev, enum ht_channel_width Band
> priv->card_8192_version == VERSION_819XU_B) {
> /* 8256 D-cut, E-cut, xiong: consider it later! */
> rtl8192_phy_SetRFReg(dev,
> - (enum rf90_radio_path_e)eRFPath,
> - 0x0b, bMask12Bits, 0x100); /* phy para:1ba */
> + (enum rf90_radio_path_e)eRFPath,
> + 0x0b, bMask12Bits, 0x100); /* phy para:1ba */
Now you added a different checkpatch warning, you can't say you fix one
and then add another, sorry.
greg k-h
next prev parent reply other threads:[~2023-10-15 16:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-15 7:44 [PATCH] staging: rtl8192u: Align descendant arguments Gilbert Adikankwu
2023-10-15 8:24 ` Andi Shyti
2023-10-15 16:09 ` Greg KH [this message]
2023-10-16 5:39 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023101519-cane-backlands-b376@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=gilbertadikankwu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).