From: Greg KH <gregkh@linuxfoundation.org>
To: Gilbert Adikankwu <gilbertadikankwu@gmail.com>
Cc: outreachy@lists.linux.dev, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: emxx_udc: Remove unnecessary parentheses around condition tests
Date: Mon, 16 Oct 2023 16:57:16 +0200 [thread overview]
Message-ID: <2023101658-unmoral-survival-25cf@gregkh> (raw)
In-Reply-To: <ZS0f+xaaLmLpKv2a@gilbert-PC>
On Mon, Oct 16, 2023 at 12:35:23PM +0100, Gilbert Adikankwu wrote:
> Fix 47 warnings detected by checkpatch.pl about unnecessary parenthesis
> around condition tests.
And as I have stated numerous times in the past, they are not
"unnecessary" at all, and provide a valuable hint to the developer as to
what is the ordering involved.
So you can ignore this checkpatch warning please, it's not valid as far
as I'm concerned for the subsystems that I maintain in the kernel.
sorry,
greg k-h
next prev parent reply other threads:[~2023-10-16 15:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 11:35 [PATCH] staging: emxx_udc: Remove unnecessary parentheses around condition tests Gilbert Adikankwu
2023-10-16 12:15 ` Julia Lawall
2023-10-16 14:57 ` Greg KH [this message]
2023-10-16 21:27 ` Andi Shyti
2023-10-17 4:14 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023101658-unmoral-survival-25cf@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=gilbertadikankwu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox