From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc: Thorsten Leemhuis <linux@leemhuis.info>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] staging: rtl8192u: remove entry from Makefile
Date: Tue, 17 Oct 2023 20:29:33 +0200 [thread overview]
Message-ID: <2023101705-undertone-sloppily-ce90@gregkh> (raw)
In-Reply-To: <337b7086-98fd-469d-a9ce-36b2d8a20559@gmail.com>
On Tue, Oct 17, 2023 at 08:07:33PM +0200, Philipp Hortmann wrote:
> On 10/17/23 15:35, Greg Kroah-Hartman wrote:
> > On Tue, Oct 17, 2023 at 12:35:57PM +0200, Thorsten Leemhuis wrote:
> > > On 17.10.23 10:13, Greg Kroah-Hartman wrote:
> > > > In commit 697455ce4110 ("staging: rtl8192u: Remove broken driver"), the
> > > > driver was removed, along with the Kconfig entry, but the Makefile line
> > > > in drivers/staging/Makefile was not updated, so things like 'make clean'
> > > > fail to work properly as they will decend into all subdirectories to try
> > > > to clean things up.
> > > >
> > > > Resolve this by removing the entry in the main staging Makefile.
> > > >
> > > > Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
> > > > Cc: Philipp Hortmann <philipp.g.hortmann@gmail.com>
> > > > Cc: Arnd Bergmann <arnd@arndb.de>
> > > > Fixes: 697455ce4110 ("staging: rtl8192u: Remove broken driver")
> > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > >
> > > Thx Greg, that fixed things for my case. In case anyone cares:
> >
> > I care, thanks!
>
>
> Sorry for messing up. I did a compile test of the entire kernel but I was
> not aware that I also need to test 'make clean'
Not a problem, I didn't either, and neither did the 0-day bot.
greg k-h
prev parent reply other threads:[~2023-10-17 18:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 8:13 [PATCH] staging: rtl8192u: remove entry from Makefile Greg Kroah-Hartman
2023-10-17 10:35 ` Thorsten Leemhuis
2023-10-17 13:35 ` Greg Kroah-Hartman
2023-10-17 18:07 ` Philipp Hortmann
2023-10-17 18:29 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023101705-undertone-sloppily-ce90@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux@leemhuis.info \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox