From: Nandha Kumar Singaram <nandhakumar.singaram@gmail.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rts5208: Replace the occurrences of (1<<x) by BIT(x)
Date: Tue, 17 Oct 2023 07:14:51 -0700 [thread overview]
Message-ID: <20231017141451.GB3156@ubuntu> (raw)
In-Reply-To: <433b9d45-bb21-49eb-8062-c03bcffa90ff@kadam.mountain>
On Tue, Oct 17, 2023 at 07:02:33AM +0300, Dan Carpenter wrote:
> On Mon, Oct 16, 2023 at 01:11:54PM -0700, Nandha Kumar Singaram wrote:
> > Adhere to linux coding style. Reported by checkpatch.pl:
> > CHECK: Prefer using the BIT macro
> >
> > Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram@gmail.com>
> > ---
> > drivers/staging/rts5208/rtsx_card.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/rts5208/rtsx_card.h b/drivers/staging/rts5208/rtsx_card.h
> > index 39727371cd7a..9d2504fddb13 100644
> > --- a/drivers/staging/rts5208/rtsx_card.h
> > +++ b/drivers/staging/rts5208/rtsx_card.h
> > @@ -338,7 +338,7 @@
> > #define DMA_DIR_FROM_CARD 0x02
> > #define DMA_EN 0x01
> > #define DMA_128 (0 << 4)
> > -#define DMA_256 (1 << 4)
> > +#define DMA_256 BIT(4)
> > #define DMA_512 (2 << 4)
>
> No. :P. Look at the lines around it. Now it's the odd duckling.
>
> > #define DMA_1024 (3 << 4)
> > #define DMA_PACK_SIZE_MASK 0x30
> > @@ -542,7 +542,7 @@
> >
> > #define BLINK_EN 0x08
> > #define LED_GPIO0 (0 << 4)
> > -#define LED_GPIO1 (1 << 4)
> > +#define LED_GPIO1 BIT(4)
> > #define LED_GPIO2 (2 << 4)
> >
>
> Same.
>
> regards,
> dan carpenter
>
Yeah, I understand now. Thanks for the review dan.
Regards,
Nandha Kumar Singaram
prev parent reply other threads:[~2023-10-17 14:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 20:11 [PATCH] staging: rts5208: Replace the occurrences of (1<<x) by BIT(x) Nandha Kumar Singaram
2023-10-17 4:02 ` Dan Carpenter
2023-10-17 4:06 ` Dan Carpenter
2023-10-17 14:02 ` Nandha Kumar Singaram
2023-10-17 14:14 ` Nandha Kumar Singaram [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231017141451.GB3156@ubuntu \
--to=nandhakumar.singaram@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox