From: Greg KH <gregkh@linuxfoundation.org>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc: Gilbert Adikankwu <gilbertadikankwu@gmail.com>,
forest@alittletooquiet.net, outreachy@lists.linux.dev,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] Rename variable bUpdateBBVGA, byCurrentCh, byCurPwr and byBBPreEDRSSI
Date: Tue, 17 Oct 2023 15:40:05 +0200 [thread overview]
Message-ID: <2023101747-goal-curing-5577@gregkh> (raw)
In-Reply-To: <0f6661a4-7281-4d26-8c26-ba03a567fcaa@gmail.com>
On Tue, Oct 17, 2023 at 08:19:49AM +0200, Philipp Hortmann wrote:
> On 10/17/23 00:58, Gilbert Adikankwu wrote:
> > Make the variable names adhere to Linux kernel coding style and mute
> > checkpatch.pl errors.
> >
> > Gilbert Adikankwu (4):
> > staging: vt6655: Rename variable bUpdateBBVGA
> > staging: vt6655: Rename variable byCurrentCh
> > staging: vt6655: Rename variable byCurPwr
> > staging: vt6655: Rename variable byBBPreEDRSSI
> >
> > drivers/staging/vt6655/baseband.c | 2 +-
> > drivers/staging/vt6655/channel.c | 18 +++++++++---------
> > drivers/staging/vt6655/device.h | 8 ++++----
> > drivers/staging/vt6655/device_main.c | 8 ++++----
> > drivers/staging/vt6655/dpc.c | 2 +-
> > drivers/staging/vt6655/rf.c | 4 ++--
> > 6 files changed, 21 insertions(+), 21 deletions(-)
> >
>
> Hi,
>
> - if (priv->byCurrentCh == ch->hw_value)
> + if (priv->current_ch == ch->hw_value)^M
> return ret;
>
> ERROR: DOS line endings
>
> What does the "^M" at the end of the new line?
> Did you run checkpatch on your patches?
I don't see that on my side, are you sure this is there?
thanks,
greg k-h
next prev parent reply other threads:[~2023-10-17 13:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 22:58 [PATCH 0/4] Rename variable bUpdateBBVGA, byCurrentCh, byCurPwr and byBBPreEDRSSI Gilbert Adikankwu
2023-10-16 22:58 ` [PATCH 1/4] staging: vt6655: Rename variable bUpdateBBVGA Gilbert Adikankwu
2023-10-17 4:48 ` Julia Lawall
2023-10-17 7:30 ` Gilbert Adikankwu
2023-10-17 7:33 ` Julia Lawall
2023-10-16 22:58 ` [PATCH 2/4] staging: vt6655: Rename variable byCurrentCh Gilbert Adikankwu
2023-10-16 22:58 ` [PATCH 3/4] staging: vt6655: Rename variable byCurPwr Gilbert Adikankwu
2023-10-16 22:58 ` [PATCH 4/4] staging: vt6655: Rename variable byBBPreEDRSSI Gilbert Adikankwu
2023-10-17 6:19 ` [PATCH 0/4] Rename variable bUpdateBBVGA, byCurrentCh, byCurPwr and byBBPreEDRSSI Philipp Hortmann
2023-10-17 7:19 ` Gilbert Adikankwu
2023-10-17 9:07 ` Karolina Stolarek
2023-10-17 13:40 ` Greg KH [this message]
2023-10-17 18:01 ` Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023101747-goal-curing-5577@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=forest@alittletooquiet.net \
--cc=gilbertadikankwu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox