Re: [PATCH 1/2] staging: vme_user: Replace printk() with pr_*(),dev_*()

Soumya Negi
2023-10-19T19:06:20Z

On Thu, Oct 19, 2023 at 05:34:01PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Oct 18, 2023 at 12:38:56PM -0700, Soumya Negi wrote:
> > Hi Greg,
> >
> > On Wed, Oct 18, 2023 at 03:26:07PM +0200, Greg Kroah-Hartman wrote:
> > > On Tue, Oct 17, 2023 at 09:36:32PM -0700, Soumya Negi wrote:
> > > > vme.c uses printk() to log messages. To improve and standardize message
> > > > formatting, use logging mechanisms pr_err()/pr_warn() and
> > > > dev_err()/dev_warn() instead. Retain the printk log levels of the
> > > > messages during replacement.
> > > >
> > > > Issue found by checkpatch.pl
> > > >
> > > > Signed-off-by: Soumya Negi <soumya.negi97@gmail.com>
> > > > ---
> > > > drivers/staging/vme_user/vme.c | 175 ++++++++++++++++++---------------
> > > > 1 file changed, 94 insertions(+), 81 deletions(-)
> > > >
> > > > diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c
> > > > index 6519a7c994a0..e8c2c1e77b7d 100644
> > > > --- a/drivers/staging/vme_user/vme.c
> > > > +++ b/drivers/staging/vme_user/vme.c
> > > > @@ -9,6 +9,8 @@
> > > > * Copyright 2004 Motorola Inc.
> > > > */
> > > >
> > > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > >
> > > No, this is a driver, as others have pointed out, always use dev_*()
> > > calls instead.
> >
> > Some of the pr_ fns can be dev_, but I don't think all can.
> > e.g. device NULL-check error messages
>
> I would argue that those are pointless and can be removed and also the
> check is probably not needed either.

Got it. The pr_() in find_bridge() can't be converted to dev_ so I'll remove
the message entirely in another patch.

I understand that the device-NULL checks should be done on the caller's side.
Since empty devices would mean something went wrong, would it be better to
put in an assertion(..WARN_ON) when removing the check?

> > Also, there are portions of the driver where we have no access to
> > any 'struct device' to feed into dev_.
>
> Then you can fix that :)

Will do this.

Regards,
Soumya

> thanks,
>
> greg k-h