Re: [PATCH 0/2] staging: vme_user: Replace printk's & cleanup log messages

Julia Lawall
2023-10-18T05:49:25Z

On Tue, 17 Oct 2023, Soumya Negi wrote:

> Staging driver vme_user has a bunch of printk() calls in vme.c which
> triggers checkpatch warnings. Remove all printk's and change them to
> the appropriate logging mechanism i.e pr_err()/pr_warn(), or
> dev_err()/dev_warn().
>
> Also, cleanup the messages further by using __func__ in the string
> instead of function names.

"cleanup" is not actually a verb. It's a noun. The verb would be clean
up.

julia

>
> This patchset fixes all checkpatch warnings like:
>
> WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then
> dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
> &
> WARNING: Prefer using '"%s...", __func__' to using 'vme_lm_get',
> this function's name, in a string
>
> Patches must be applied in order.
>
> Soumya Negi (2):
> staging: vme_user: Replace printk() with pr_*(),dev_*()
> staging: vme_user: Use __func__ instead of function name
>
> drivers/staging/vme_user/vme.c | 175 ++++++++++++++++++---------------
> 1 file changed, 94 insertions(+), 81 deletions(-)
>
> --
> 2.42.0
>
>
>