From: Nandha Kumar Singaram <nandhakumar.singaram@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Manish Chopra <manishc@marvell.com>,
GR-Linux-NIC-Dev@marvell.com, Coiby Xu <coiby.xu@gmail.com>,
netdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, kumaran.4353@gmail.com
Subject: Re: [PATCH 0/2] staging: qlge: Replace the occurrences of (1<<x) by BIT(x)
Date: Wed, 18 Oct 2023 10:01:11 -0700 [thread overview]
Message-ID: <20231018170111.GA3452@ubuntu> (raw)
In-Reply-To: <2023101856-visa-unlimited-a365@gregkh>
On Wed, Oct 18, 2023 at 03:28:30PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Oct 17, 2023 at 12:03:57PM -0700, Nandha Kumar Singaram wrote:
> > This patchset performs code cleanup in qlge driver as per
> > linux coding style and may be applied in any sequence.
> >
> > Nandha Kumar Singaram (2):
> > staging: qlge: Replace the occurrences of (1<<x) by BIT(x)
> > staging: qlge: Replace the occurrences of (1<<x) by BIT(x)
>
> You have two different patches doing different things yet they have the
> same identical subject lines. That's not ok, sorry, please make unique
> subject lines as obviously you are doing different things.
>
> thanks,
>
> greg k-h
Sorry greg, thanks for your feedback. Will update the patch
Regards,
Nandha Kumar Singaram
prev parent reply other threads:[~2023-10-18 17:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 19:03 [PATCH 0/2] staging: qlge: Replace the occurrences of (1<<x) by BIT(x) Nandha Kumar Singaram
2023-10-17 19:05 ` [PATCH 1/2] " Nandha Kumar Singaram
2023-10-17 19:06 ` [PATCH 2/2] " Nandha Kumar Singaram
2023-10-18 13:28 ` [PATCH 0/2] " Greg Kroah-Hartman
2023-10-18 17:01 ` Nandha Kumar Singaram [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231018170111.GA3452@ubuntu \
--to=nandhakumar.singaram@gmail.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=coiby.xu@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kumaran.4353@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).