From: Gary Rookard <garyrookard@fastmail.org>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: rtl8192e: renamed variable IsHTHalfNmodeAPs
Date: Sun, 22 Oct 2023 04:42:54 -0400 [thread overview]
Message-ID: <20231022044254.460b6677@gnu-trisquel> (raw)
In-Reply-To: <070529f5-b0ff-4cbb-af3e-28984616a821@gmail.com>
On Sun, 22 Oct 2023 09:47:36 +0200
Philipp Hortmann <philipp.g.hortmann@gmail.com> wrote:
> On 10/22/23 09:32, Gary Rookard wrote:
> > Sorry, but I do both compile and checkpatch, but they seem to be
> > failing, don't
> > know why yet. I've been using make M=drivers/staging/rtl8192e after
> > a complete
> > kernel build at make -j3, I'm changing it to Make drivers/staging
> > as a matter of recourse.
> > gcc version 13.2.1 20230826 (Gentoo 13.2.1_p20230826 p7)
> >
> > I use checkpatch unflaged on the patch, never a problem before...
> >
> > On Sun, Oct 22, 2023, at 2:48 AM, Philipp Hortmann wrote:
> >> On 10/22/23 00:40, Gary Rookard wrote:
> >> > Renamed from Pascal/CamelCase to Snake case the variable
> >> > IsHTHalfNmodeAPs, IsHTHalfNmodeAPs -> is_ht_half_nmode_aps.
> >> > Linux
> >> kernel
> >> > coding style (cleanup) checkpatch Avoid CamelCase. Driver
> >> > rtl8192e compiles. Signed-off-by: Gary Rookard
> >> > <garyrookard@fastmail.org
> >> <mailto:garyrookard@fastmail.org>> ---
> >> > drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
> >> > drivers/staging/rtl8192e/rtllib.h | 2 +-
> >> > drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- 3 files
> >> > changed, 3 insertions(+), 3 deletions(-)
> >>
> >> Hi,
> >>
> >> I assume that now I cannot apply this patch anymore because the
> >> previous one is missing.
> >>
> >> I propose to make a patch series out of the send in patches.
> >> Please do a compile test and and use checkpatch.
> >>
> >> Please include in the version change at which version what changed.
> >>
> >> Thanks for your support.
> >>
> >> Bye Philipp
> >>
> >
>
> Hi Gary,
>
> please use:
> make -C . M=drivers/staging/rtl8192e
>
> I am using checkpatch as described here:
> https://kernelnewbies.org/FirstKernelPatch
> "Git post-commit hooks"
>
> Please always reply with Bottom Posting. You used top posting which
> is not liked by the community and maintainer.
>
> Bye Philipp
Again sorry, it's sorta a GNU habit...mailing lists :( All advice
taken, thanks.
Regards
next prev parent reply other threads:[~2023-10-22 8:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-21 22:40 [PATCH] staging: rtl8192e: renamed variable IsHTHalfNmodeAPs Gary Rookard
2023-10-22 6:48 ` Philipp Hortmann
[not found] ` <aa578599-cd87-4c3a-8040-03ab065d8482@app.fastmail.com>
2023-10-22 7:47 ` Philipp Hortmann
2023-10-22 8:42 ` Gary Rookard [this message]
2023-10-22 10:21 ` Greg KH
2023-10-22 10:22 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231022044254.460b6677@gnu-trisquel \
--to=garyrookard@fastmail.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox