[PATCH] staging: rtl8192e: renamed variable IsHTHalfNmodeAPs

[PATCH] staging: rtl8192e: renamed variable IsHTHalfNmodeAPs

[Gary Rookard]

Renamed from Pascal/CamelCase to Snake case the variable
IsHTHalfNmodeAPs, IsHTHalfNmodeAPs -> is_ht_half_nmode_aps.

Linux kernel coding style (cleanup) checkpatch Avoid CamelCase.
Driver rtl8192e compiles.

Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
 drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
 drivers/staging/rtl8192e/rtllib.h         | 2 +-
 drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 8070a152712e..f564474fab52 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -139,7 +139,7 @@ u16  tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate)
 	return MCS_DATA_RATE[is40MHz][isShortGI][nDataRate & 0xf];
 }
 
-bool IsHTHalfNmodeAPs(struct rtllib_device *ieee)
+bool is_ht_half_nmode_aps(struct rtllib_device *ieee)
 {
 	bool			retValue = false;
 	struct rtllib_network *net = &ieee->current_network;
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 6a9550eaf148..5cae02883a59 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1783,7 +1783,7 @@ extern u8 MCS_FILTER_ALL[];
 extern u16 MCS_DATA_RATE[2][2][77];
 u8 HTCCheck(struct rtllib_device *ieee, u8 *pFrame);
 void HTResetIOTSetting(struct rt_hi_throughput *ht_info);
-bool IsHTHalfNmodeAPs(struct rtllib_device *ieee);
+bool is_ht_half_nmode_aps(struct rtllib_device *ieee);
 u16  tx_count_data_rate(struct rtllib_device *ieee, u8 nDataRate);
 int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb);
 int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb);
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index ff98b41c94e0..501295f5b75e 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -1872,7 +1872,7 @@ static void rtllib_rx_auth_resp(struct rtllib_device *ieee, struct sk_buff *skb)
 		ieee->softmac_stats.rx_auth_rs_ok++;
 		if (!(ieee->ht_info->iot_action & HT_IOT_ACT_PURE_N_MODE)) {
 			if (!ieee->GetNmodeSupportBySecCfg(ieee->dev)) {
-				if (IsHTHalfNmodeAPs(ieee)) {
+				if (is_ht_half_nmode_aps(ieee)) {
 					bSupportNmode = true;
 					bHalfSupportNmode = true;
 				} else {
-- 
2.41.0

Re: [PATCH] staging: rtl8192e: renamed variable IsHTHalfNmodeAPs

[Philipp Hortmann]

On 10/22/23 00:40, Gary Rookard wrote:
> Renamed from Pascal/CamelCase to Snake case the variable 
> IsHTHalfNmodeAPs, IsHTHalfNmodeAPs -> is_ht_half_nmode_aps. Linux kernel 
> coding style (cleanup) checkpatch Avoid CamelCase. Driver rtl8192e 
> compiles. Signed-off-by: Gary Rookard <garyrookard@fastmail.org> --- 
> drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +- 
> drivers/staging/rtl8192e/rtllib.h | 2 +- 
> drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- 3 files changed, 3 
> insertions(+), 3 deletions(-)

Hi,

I assume that now I cannot apply this patch anymore because the previous 
one is missing.

I propose to make a patch series out of the send in patches.
Please do a compile test and and use checkpatch.

Please include in the version change at which version what changed.

Thanks for your support.

Bye Philipp

Re: [PATCH] staging: rtl8192e: renamed variable IsHTHalfNmodeAPs

[Philipp Hortmann]

On 10/22/23 09:32, Gary Rookard wrote:
> Sorry, but I do both compile and checkpatch, but they seem to be 
> failing, don't
> know why yet. I've been using make M=drivers/staging/rtl8192e after a 
> complete
> kernel build at make -j3, I'm changing it to Make drivers/staging as a 
> matter of recourse.
> gcc version 13.2.1 20230826 (Gentoo 13.2.1_p20230826 p7)
> 
> I use checkpatch unflaged on the patch, never a problem before...
> 
> On Sun, Oct 22, 2023, at 2:48 AM, Philipp Hortmann wrote:
>> On 10/22/23 00:40, Gary Rookard wrote:
>> > Renamed from Pascal/CamelCase to Snake case the variable
>> > IsHTHalfNmodeAPs, IsHTHalfNmodeAPs -> is_ht_half_nmode_aps. Linux 
>> kernel
>> > coding style (cleanup) checkpatch Avoid CamelCase. Driver rtl8192e
>> > compiles. Signed-off-by: Gary Rookard <garyrookard@fastmail.org 
>> <mailto:garyrookard@fastmail.org>> ---
>> > drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
>> > drivers/staging/rtl8192e/rtllib.h | 2 +-
>> > drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- 3 files changed, 3
>> > insertions(+), 3 deletions(-)
>>
>> Hi,
>>
>> I assume that now I cannot apply this patch anymore because the previous
>> one is missing.
>>
>> I propose to make a patch series out of the send in patches.
>> Please do a compile test and and use checkpatch.
>>
>> Please include in the version change at which version what changed.
>>
>> Thanks for your support.
>>
>> Bye Philipp
>>
> 

Hi Gary,

please use:
make -C . M=drivers/staging/rtl8192e

I am using checkpatch as described here:
https://kernelnewbies.org/FirstKernelPatch
"Git post-commit hooks"

Please always reply with Bottom Posting. You used top posting which is 
not liked by the community and maintainer.

Bye Philipp

Re: [PATCH] staging: rtl8192e: renamed variable IsHTHalfNmodeAPs

[Gary Rookard]

On Sun, 22 Oct 2023 09:47:36 +0200
Philipp Hortmann <philipp.g.hortmann@gmail.com> wrote:

> On 10/22/23 09:32, Gary Rookard wrote:
> > Sorry, but I do both compile and checkpatch, but they seem to be 
> > failing, don't
> > know why yet. I've been using make M=drivers/staging/rtl8192e after
> > a complete
> > kernel build at make -j3, I'm changing it to Make drivers/staging
> > as a matter of recourse.
> > gcc version 13.2.1 20230826 (Gentoo 13.2.1_p20230826 p7)
> > 
> > I use checkpatch unflaged on the patch, never a problem before...
> > 
> > On Sun, Oct 22, 2023, at 2:48 AM, Philipp Hortmann wrote:  
> >> On 10/22/23 00:40, Gary Rookard wrote:  
> >> > Renamed from Pascal/CamelCase to Snake case the variable
> >> > IsHTHalfNmodeAPs, IsHTHalfNmodeAPs -> is_ht_half_nmode_aps.
> >> > Linux   
> >> kernel  
> >> > coding style (cleanup) checkpatch Avoid CamelCase. Driver
> >> > rtl8192e compiles. Signed-off-by: Gary Rookard
> >> > <garyrookard@fastmail.org   
> >> <mailto:garyrookard@fastmail.org>> ---  
> >> > drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
> >> > drivers/staging/rtl8192e/rtllib.h | 2 +-
> >> > drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- 3 files
> >> > changed, 3 insertions(+), 3 deletions(-)  
> >>
> >> Hi,
> >>
> >> I assume that now I cannot apply this patch anymore because the
> >> previous one is missing.
> >>
> >> I propose to make a patch series out of the send in patches.
> >> Please do a compile test and and use checkpatch.
> >>
> >> Please include in the version change at which version what changed.
> >>
> >> Thanks for your support.
> >>
> >> Bye Philipp
> >>  
> >   
> 
> Hi Gary,
> 
> please use:
> make -C . M=drivers/staging/rtl8192e
> 
> I am using checkpatch as described here:
> https://kernelnewbies.org/FirstKernelPatch
> "Git post-commit hooks"
> 
> Please always reply with Bottom Posting. You used top posting which
> is not liked by the community and maintainer.
> 
> Bye Philipp

Again sorry, it's sorta a GNU habit...mailing lists :( All advice
taken, thanks.

Regards

Re: [PATCH] staging: rtl8192e: renamed variable IsHTHalfNmodeAPs

[Greg KH]

On Sat, Oct 21, 2023 at 06:40:51PM -0400, Gary Rookard wrote:
> Renamed from Pascal/CamelCase to Snake case the variable
> IsHTHalfNmodeAPs, IsHTHalfNmodeAPs -> is_ht_half_nmode_aps.
> 
> Linux kernel coding style (cleanup) checkpatch Avoid CamelCase.
> Driver rtl8192e compiles.
> 
> Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
> ---
>  drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
>  drivers/staging/rtl8192e/rtllib.h         | 2 +-
>  drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> index 8070a152712e..f564474fab52 100644
> --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> @@ -139,7 +139,7 @@ u16  tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate)
>  	return MCS_DATA_RATE[is40MHz][isShortGI][nDataRate & 0xf];
>  }
>  
> -bool IsHTHalfNmodeAPs(struct rtllib_device *ieee)
> +bool is_ht_half_nmode_aps(struct rtllib_device *ieee)
>  {
>  	bool			retValue = false;
>  	struct rtllib_network *net = &ieee->current_network;
> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> index 6a9550eaf148..5cae02883a59 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -1783,7 +1783,7 @@ extern u8 MCS_FILTER_ALL[];
>  extern u16 MCS_DATA_RATE[2][2][77];
>  u8 HTCCheck(struct rtllib_device *ieee, u8 *pFrame);
>  void HTResetIOTSetting(struct rt_hi_throughput *ht_info);
> -bool IsHTHalfNmodeAPs(struct rtllib_device *ieee);
> +bool is_ht_half_nmode_aps(struct rtllib_device *ieee);
>  u16  tx_count_data_rate(struct rtllib_device *ieee, u8 nDataRate);
>  int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb);
>  int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb);
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
> index ff98b41c94e0..501295f5b75e 100644
> --- a/drivers/staging/rtl8192e/rtllib_softmac.c
> +++ b/drivers/staging/rtl8192e/rtllib_softmac.c
> @@ -1872,7 +1872,7 @@ static void rtllib_rx_auth_resp(struct rtllib_device *ieee, struct sk_buff *skb)
>  		ieee->softmac_stats.rx_auth_rs_ok++;
>  		if (!(ieee->ht_info->iot_action & HT_IOT_ACT_PURE_N_MODE)) {
>  			if (!ieee->GetNmodeSupportBySecCfg(ieee->dev)) {
> -				if (IsHTHalfNmodeAPs(ieee)) {
> +				if (is_ht_half_nmode_aps(ieee)) {
>  					bSupportNmode = true;
>  					bHalfSupportNmode = true;
>  				} else {
> -- 
> 2.41.0
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You sent multiple patches, yet no indication of which ones should be
  applied in which order.  Greg could just guess, but if you are
  receiving this email, he guessed wrong and the patches didn't apply.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for a
  description of how to do this so that Greg has a chance to apply these
  correctly.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH] staging: rtl8192e: renamed variable IsHTHalfNmodeAPs

[Greg KH]

On Sun, Oct 22, 2023 at 12:21:40PM +0200, Greg KH wrote:
> On Sat, Oct 21, 2023 at 06:40:51PM -0400, Gary Rookard wrote:
> > Renamed from Pascal/CamelCase to Snake case the variable
> > IsHTHalfNmodeAPs, IsHTHalfNmodeAPs -> is_ht_half_nmode_aps.
> > 
> > Linux kernel coding style (cleanup) checkpatch Avoid CamelCase.
> > Driver rtl8192e compiles.
> > 
> > Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
> > ---
> >  drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
> >  drivers/staging/rtl8192e/rtllib.h         | 2 +-
> >  drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
> >  3 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> > index 8070a152712e..f564474fab52 100644
> > --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
> > +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> > @@ -139,7 +139,7 @@ u16  tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate)
> >  	return MCS_DATA_RATE[is40MHz][isShortGI][nDataRate & 0xf];
> >  }
> >  
> > -bool IsHTHalfNmodeAPs(struct rtllib_device *ieee)
> > +bool is_ht_half_nmode_aps(struct rtllib_device *ieee)
> >  {
> >  	bool			retValue = false;
> >  	struct rtllib_network *net = &ieee->current_network;
> > diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> > index 6a9550eaf148..5cae02883a59 100644
> > --- a/drivers/staging/rtl8192e/rtllib.h
> > +++ b/drivers/staging/rtl8192e/rtllib.h
> > @@ -1783,7 +1783,7 @@ extern u8 MCS_FILTER_ALL[];
> >  extern u16 MCS_DATA_RATE[2][2][77];
> >  u8 HTCCheck(struct rtllib_device *ieee, u8 *pFrame);
> >  void HTResetIOTSetting(struct rt_hi_throughput *ht_info);
> > -bool IsHTHalfNmodeAPs(struct rtllib_device *ieee);
> > +bool is_ht_half_nmode_aps(struct rtllib_device *ieee);
> >  u16  tx_count_data_rate(struct rtllib_device *ieee, u8 nDataRate);
> >  int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb);
> >  int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb);
> > diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
> > index ff98b41c94e0..501295f5b75e 100644
> > --- a/drivers/staging/rtl8192e/rtllib_softmac.c
> > +++ b/drivers/staging/rtl8192e/rtllib_softmac.c
> > @@ -1872,7 +1872,7 @@ static void rtllib_rx_auth_resp(struct rtllib_device *ieee, struct sk_buff *skb)
> >  		ieee->softmac_stats.rx_auth_rs_ok++;
> >  		if (!(ieee->ht_info->iot_action & HT_IOT_ACT_PURE_N_MODE)) {
> >  			if (!ieee->GetNmodeSupportBySecCfg(ieee->dev)) {
> > -				if (IsHTHalfNmodeAPs(ieee)) {
> > +				if (is_ht_half_nmode_aps(ieee)) {
> >  					bSupportNmode = true;
> >  					bHalfSupportNmode = true;
> >  				} else {
> > -- 
> > 2.41.0
> > 
> > 
> 
> Hi,
> 
> This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
> a patch that has triggered this response.  He used to manually respond
> to these common problems, but in order to save his sanity (he kept
> writing the same thing over and over, yet to different people), I was
> created.  Hopefully you will not take offence and will fix the problem
> in your patch and resubmit it so that it can be accepted into the Linux
> kernel tree.
> 
> You are receiving this message because of the following common error(s)
> as indicated below:
> 
> - You sent multiple patches, yet no indication of which ones should be
>   applied in which order.  Greg could just guess, but if you are
>   receiving this email, he guessed wrong and the patches didn't apply.
>   Please read the section entitled "The canonical patch format" in the
>   kernel file, Documentation/process/submitting-patches.rst for a
>   description of how to do this so that Greg has a chance to apply these
>   correctly.
> 
> If you wish to discuss this problem further, or you have questions about
> how to resolve this issue, please feel free to respond to this email and
> Greg will reply once he has dug out from the pending patches received
> from other developers.
> 
> thanks,
> 
> greg k-h's patch email bot

Note that I have dropped all of your rtl8192e patches you sent, please
fix them all up, properly test them, and send them as a patch series so
we know what order to apply them in, otherwise it's impossible to guess.

Think about what you would want to see if you were on our side reviewing
them.

thanks,

greg k-h