From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2014C15491 for ; Wed, 25 Oct 2023 10:46:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="qdkXLt/L" Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 939C9669; Wed, 25 Oct 2023 12:46:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1698230771; bh=3B8UXJ9PcYzoRJm+B7Dz7xMuzRnpMz29Xx7zrFcbnGk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qdkXLt/LwLzZ4VaOXcKqPmGpnYLeZzYsdwln6xygJ2stUpmkeM/zlsfZE75wsTvzd yKiZ0/kejLYvAzT5CBTIeFGK2kgacFfcvX/DQCGHTzXwZIrGigdhxiIGVI2GBggmyn aAyc0As8zmGKmbyGlBZsW6WRau5pydWIdzkxpESk= Date: Wed, 25 Oct 2023 13:46:30 +0300 From: Laurent Pinchart To: Umang Jain Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stefan Wahren , Greg Kroah-Hartman , Kieran Bingham , Dan Carpenter Subject: Re: [PATCH 2/2] staging: vc04_services: Drop completed TODO item Message-ID: <20231025104630.GB481@pendragon.ideasonboard.com> References: <20231025103300.340572-1-umang.jain@ideasonboard.com> <20231025103300.340572-3-umang.jain@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231025103300.340572-3-umang.jain@ideasonboard.com> On Wed, Oct 25, 2023 at 06:33:00AM -0400, Umang Jain wrote: > Memory barries and remote_event_*() are documented. > Drop the TODO item related to them. > > Signed-off-by: Umang Jain > --- > drivers/staging/vc04_services/interface/TODO | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO > index 9c79ed549831..2d51f6928e0f 100644 > --- a/drivers/staging/vc04_services/interface/TODO > +++ b/drivers/staging/vc04_services/interface/TODO > @@ -33,13 +33,6 @@ such as dev_info, dev_dbg, and friends. > A short top-down description of this driver's architecture (function of > kthreads, userspace, limitations) could be very helpful for reviewers. > > -* Review and comment memory barriers > - > -There is a heavy use of memory barriers in this driver, it would be very > -beneficial to go over all of them and, if correct, comment on their merits. > -Extra points to whomever confidently reviews the remote_event_*() family of > -functions. > - Is vchiq so timing sensitive that it can't afford spinlocks ? > * Reformat core code with more sane indentations > > The code follows the 80 characters limitation yet tends to go 3 or 4 levels of -- Regards, Laurent Pinchart