From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Umang Jain <umang.jain@ideasonboard.com>
Cc: linux-staging@lists.linux.dev,
linux-rpi-kernel@lists.infradead.org,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Stefan Wahren <stefan.wahren@i2se.com>,
Dan Carpenter <error27@gmail.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Phil Elwell <phil@raspberrypi.com>
Subject: Re: [PATCH v2 8/8] staging: vc04_services: Drop log level mechanisms
Date: Wed, 25 Oct 2023 13:03:26 +0200 [thread overview]
Message-ID: <2023102543-chapter-spending-4978@gregkh> (raw)
In-Reply-To: <20231024114428.443528-9-umang.jain@ideasonboard.com>
On Tue, Oct 24, 2023 at 07:44:28AM -0400, Umang Jain wrote:
> Drop the log level remnants since the logs are now ported to use
> dynamic logging. Drop macros, externs and global variables which
> were used in the log level mechanisms along with debugfs log entries.
>
> Update the drivers/staging/vc04_services/interface/TODO list as well.
>
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
> drivers/staging/vc04_services/interface/TODO | 5 -
> .../interface/vchiq_arm/vchiq_arm.c | 4 -
> .../interface/vchiq_arm/vchiq_arm.h | 3 -
> .../interface/vchiq_arm/vchiq_core.c | 87 ++++++---------
> .../interface/vchiq_arm/vchiq_core.h | 11 --
> .../interface/vchiq_arm/vchiq_debugfs.c | 103 ------------------
> 6 files changed, 33 insertions(+), 180 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO
> index 6d9d4a800aa7..05eb5140d096 100644
> --- a/drivers/staging/vc04_services/interface/TODO
> +++ b/drivers/staging/vc04_services/interface/TODO
> @@ -23,11 +23,6 @@ should properly handle a module unload. This also includes that all
> resources must be freed (kthreads, debugfs entries, ...) and global
> variables avoided.
>
> -* Cleanup logging mechanism
> -
> -The driver should probably be using the standard kernel logging mechanisms
> -such as dev_info, dev_dbg, and friends.
> -
> * Documentation
>
> A short top-down description of this driver's architecture (function of
I dropped this chunk, and the changlog description of it, as I'm not
fully convinced that this portion is done yet. You did the hard work, I
think the remaining tiny bit can probably be scripted.
thanks,
greg k-h
next prev parent reply other threads:[~2023-10-25 11:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 11:44 [PATCH v2 0/8] staging: vc04: Drop custom logging based on printk Umang Jain
2023-10-24 11:44 ` [PATCH v2 1/8] staging: vc04_services: Pass struct device to vchiq_log_dump_mem() Umang Jain
2023-10-24 11:44 ` [PATCH v2 2/8] staging: vc04_services: Pass struct device to vchiq_init_slots() Umang Jain
2023-10-24 11:44 ` [PATCH v2 3/8] staging: vc04: Convert vchiq_log_error() to use dynamic debug Umang Jain
2023-10-24 11:44 ` [PATCH v2 4/8] staging: vc04: Convert vchiq_log_warning() " Umang Jain
2023-10-24 11:44 ` [PATCH v2 5/8] staging: vc04: Convert(and rename) vchiq_log_info() " Umang Jain
2023-10-24 11:44 ` [PATCH v2 6/8] staging: vc04: Convert vchiq_log_trace() " Umang Jain
2023-10-24 11:44 ` [PATCH v2 7/8] staging: vc04_services: Drop VCHIQ_LOG_PREFIX macro Umang Jain
2023-10-24 11:44 ` [PATCH v2 8/8] staging: vc04_services: Drop log level mechanisms Umang Jain
2023-10-25 11:03 ` Greg Kroah-Hartman [this message]
2023-10-25 11:01 ` [PATCH v2 0/8] staging: vc04: Drop custom logging based on printk Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023102543-chapter-spending-4978@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=error27@gmail.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@raspberrypi.com \
--cc=stefan.wahren@i2se.com \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).