From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD3E1210E2 for ; Wed, 25 Oct 2023 11:03:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="EKyxDa2l" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E1E7C433C8; Wed, 25 Oct 2023 11:03:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698231809; bh=Aa57aTVELvtasTdJr4xDdJMqfS+s+yVwDJlL6+u2dCM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EKyxDa2lU2R6ezw0pLmooF8XUeITjd9FUERmZEgBIrS3865haVuWekmDn3/2Y5jLi +TuHGnXmO68Num9MxWK8dddAuOs+nsJJhnq8HrcVIEbMblnVbD/4cCiLEqgRgYY+14 vxRbDJn2wx2g8GpraSviv+4/UjzFyK1sB0AHem5g= Date: Wed, 25 Oct 2023 13:03:26 +0200 From: Greg Kroah-Hartman To: Umang Jain Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stefan Wahren , Dan Carpenter , Kieran Bingham , Laurent Pinchart , Phil Elwell Subject: Re: [PATCH v2 8/8] staging: vc04_services: Drop log level mechanisms Message-ID: <2023102543-chapter-spending-4978@gregkh> References: <20231024114428.443528-1-umang.jain@ideasonboard.com> <20231024114428.443528-9-umang.jain@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231024114428.443528-9-umang.jain@ideasonboard.com> On Tue, Oct 24, 2023 at 07:44:28AM -0400, Umang Jain wrote: > Drop the log level remnants since the logs are now ported to use > dynamic logging. Drop macros, externs and global variables which > were used in the log level mechanisms along with debugfs log entries. > > Update the drivers/staging/vc04_services/interface/TODO list as well. > > Signed-off-by: Umang Jain > --- > drivers/staging/vc04_services/interface/TODO | 5 - > .../interface/vchiq_arm/vchiq_arm.c | 4 - > .../interface/vchiq_arm/vchiq_arm.h | 3 - > .../interface/vchiq_arm/vchiq_core.c | 87 ++++++--------- > .../interface/vchiq_arm/vchiq_core.h | 11 -- > .../interface/vchiq_arm/vchiq_debugfs.c | 103 ------------------ > 6 files changed, 33 insertions(+), 180 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO > index 6d9d4a800aa7..05eb5140d096 100644 > --- a/drivers/staging/vc04_services/interface/TODO > +++ b/drivers/staging/vc04_services/interface/TODO > @@ -23,11 +23,6 @@ should properly handle a module unload. This also includes that all > resources must be freed (kthreads, debugfs entries, ...) and global > variables avoided. > > -* Cleanup logging mechanism > - > -The driver should probably be using the standard kernel logging mechanisms > -such as dev_info, dev_dbg, and friends. > - > * Documentation > > A short top-down description of this driver's architecture (function of I dropped this chunk, and the changlog description of it, as I'm not fully convinced that this portion is done yet. You did the hard work, I think the remaining tiny bit can probably be scripted. thanks, greg k-h