From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Umang Jain <umang.jain@ideasonboard.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
linux-staging@lists.linux.dev,
"Ricardo B . Marliere" <ricardo@marliere.net>,
linux-rpi-kernel@lists.infradead.org,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Stefan Wahren <stefan.wahren@i2se.com>,
Dan Carpenter <error27@gmail.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 1/1] staging: vc04_services: Use %p4cc format modifier to print FourCC codes
Date: Wed, 25 Oct 2023 11:46:00 +0200 [thread overview]
Message-ID: <2023102546-trident-clear-1299@gregkh> (raw)
In-Reply-To: <fe0b6ed1-61ba-5373-1525-adb040f68184@ideasonboard.com>
On Wed, Oct 25, 2023 at 03:04:04PM +0530, Umang Jain wrote:
>
>
> On 10/25/23 2:58 PM, Sakari Ailus wrote:
> > On Wed, Oct 25, 2023 at 10:10:08AM +0300, Dan Carpenter wrote:
> > > On Wed, Oct 25, 2023 at 02:07:17AM -0400, Umang Jain wrote:
> > > > Drop VCHIQ_FOURCC_AS_4CHARS macro in favour of %p4cc format
> > > > modifier to print FourCC codes in the logs.
> > > >
> > > > vchiq_use_internal() and vchiq_release_internal() uses entity
> > > > character-array to store a transient string that contains
> > > > a FourCC code. Increase the length of entity array(to 64 bytes)
> > > > since %p4cc requires more bytes to hold the output characters.
> > > >
> > > > Suggested-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> > > > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> > > > ---
> > > > .../interface/vchiq_arm/vchiq_arm.c | 20 +++++-----
> > > > .../interface/vchiq_arm/vchiq_core.c | 40 +++++++++----------
> > > > .../interface/vchiq_arm/vchiq_core.h | 6 ---
> > > > .../interface/vchiq_arm/vchiq_dev.c | 7 ++--
> > > > 4 files changed, 33 insertions(+), 40 deletions(-)
> > > >
> > > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> > > > index fc6d33ec5e95..de6a24304a4d 100644
> > > > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> > > > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> > > > @@ -1441,7 +1441,7 @@ vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service,
> > > > {
> > > > struct vchiq_arm_state *arm_state = vchiq_platform_get_arm_state(state);
> > > > int ret = 0;
> > > > - char entity[16];
> > > > + char entity[64];
> > > > int *entity_uc;
> > > > int local_uc;
> > > > @@ -1454,8 +1454,8 @@ vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service,
> > > > sprintf(entity, "VCHIQ: ");
> > > > entity_uc = &arm_state->peer_use_count;
> > > > } else if (service) {
> > > > - sprintf(entity, "%c%c%c%c:%03d",
> > > > - VCHIQ_FOURCC_AS_4CHARS(service->base.fourcc),
> > > > + sprintf(entity, "%p4cc:%03d",
> > > Not related to your patch but these sprintfs() make me very
> > > uncomfortable.
> > >
> > > KTODO: change sprintf() to snprintf() in staging/vc04_services/
> > Umang: how about one patch on top of this? :-) There are just five
> > instances of it.
>
> Ricardo, how about this? Do you want to take a swing at this ? :-)
>
> And send a v2. ?
No, that would be a separate change, this one is fine as-is.
thanks,
greg k-h
next prev parent reply other threads:[~2023-10-25 9:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 6:07 [PATCH 0/1] staging: vc04_services: Use %p4cc to print fourcc Umang Jain
2023-10-25 6:07 ` [PATCH 1/1] staging: vc04_services: Use %p4cc format modifier to print FourCC codes Umang Jain
2023-10-25 7:10 ` Dan Carpenter
2023-10-25 9:28 ` Sakari Ailus
2023-10-25 9:34 ` Umang Jain
2023-10-25 9:46 ` Greg Kroah-Hartman [this message]
2023-10-25 11:12 ` Ricardo B. Marliere
2023-10-25 11:29 ` [PATCH 0/1] staging: vc04_services: Use %p4cc to print fourcc Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023102546-trident-clear-1299@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@linaro.org \
--cc=error27@gmail.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=ricardo@marliere.net \
--cc=sakari.ailus@linux.intel.com \
--cc=stefan.wahren@i2se.com \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox