* [PATCH] staging: vme_user: Added blank line after declarations @ 2023-10-31 10:06 Rohit Chavan 2023-10-31 10:27 ` Dan Carpenter 0 siblings, 1 reply; 3+ messages in thread From: Rohit Chavan @ 2023-10-31 10:06 UTC (permalink / raw) To: Martyn Welch, Manohar Vanga, Greg Kroah-Hartman, linux-kernel, linux-staging Cc: Rohit Chavan Fixes below warning reported by checkpatch. WARNING: Missing a blank line after declarations Signed-off-by: Rohit Chavan <roheetchavan@gmail.com> --- drivers/staging/vme_user/vme_fake.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c index 7f84d1c86f29..c4acc010c37b 100644 --- a/drivers/staging/vme_user/vme_fake.c +++ b/drivers/staging/vme_user/vme_fake.c @@ -67,6 +67,7 @@ struct fake_driver { unsigned long long lm_base; u32 lm_aspace; u32 lm_cycle; + void (*lm_callback[4])(void *); void *lm_data[4]; struct tasklet_struct int_tasklet; -- 2.34.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: vme_user: Added blank line after declarations 2023-10-31 10:06 [PATCH] staging: vme_user: Added blank line after declarations Rohit Chavan @ 2023-10-31 10:27 ` Dan Carpenter 2023-10-31 17:37 ` Joe Perches 0 siblings, 1 reply; 3+ messages in thread From: Dan Carpenter @ 2023-10-31 10:27 UTC (permalink / raw) To: Rohit Chavan Cc: Martyn Welch, Manohar Vanga, Greg Kroah-Hartman, linux-kernel, linux-staging On Tue, Oct 31, 2023 at 10:06:10AM +0000, Rohit Chavan wrote: > Fixes below warning reported by checkpatch. > WARNING: Missing a blank line after declarations > > Signed-off-by: Rohit Chavan <roheetchavan@gmail.com> This is a checkpatch false positive. (It's not "after declarations"). Just ignore it. regards, dan carpenter ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: vme_user: Added blank line after declarations 2023-10-31 10:27 ` Dan Carpenter @ 2023-10-31 17:37 ` Joe Perches 0 siblings, 0 replies; 3+ messages in thread From: Joe Perches @ 2023-10-31 17:37 UTC (permalink / raw) To: Dan Carpenter, Rohit Chavan Cc: Martyn Welch, Manohar Vanga, Greg Kroah-Hartman, linux-kernel, linux-staging On Tue, 2023-10-31 at 13:27 +0300, Dan Carpenter wrote: > On Tue, Oct 31, 2023 at 10:06:10AM +0000, Rohit Chavan wrote: > > Fixes below warning reported by checkpatch. > > WARNING: Missing a blank line after declarations > > > > Signed-off-by: Rohit Chavan <roheetchavan@gmail.com> > > This is a checkpatch false positive. (It's not "after declarations"). > Just ignore it. > checkpatch could accept function pointer and function pointer arrays --- scripts/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 25fdb7fda1128..de1f4962f55d6 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1073,6 +1073,7 @@ our $Typecast = qr{\s*(\(\s*$NonptrType\s*\)){0,1}\s*}; # Any use must be runtime checked with $^V our $balanced_parens = qr/(\((?:[^\(\)]++|(?-1))*\))/; +our $balanced_brackets = qr/(\[(?:[^\[\]]++|(?-1))*\])/; our $LvalOrFunc = qr{((?:[\&\*]\s*)?$Lval)\s*($balanced_parens{0,1})\s*}; our $FuncArg = qr{$Typecast{0,1}($LvalOrFunc|$Constant|$String)}; @@ -4107,7 +4108,7 @@ sub process { # looks like a declaration !($sl =~ /^\+\s+$Declare\s*$Ident\s*[=,;:\[]/ || # function pointer declarations - $sl =~ /^\+\s+$Declare\s*\(\s*\*\s*$Ident\s*\)\s*[=,;:\[\(]/ || + $sl =~ /^\+\s+$Declare\s*\(\s*\*\s*$Ident(?:\s*$balanced_brackets)*\s*\)\s*[=,;:\[\(]/ || # foo bar; where foo is some local typedef or #define $sl =~ /^\+\s+$Ident(?:\s+|\s*\*\s*)$Ident\s*[=,;\[]/ || # known declaration macros ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-31 18:14 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-10-31 10:06 [PATCH] staging: vme_user: Added blank line after declarations Rohit Chavan 2023-10-31 10:27 ` Dan Carpenter 2023-10-31 17:37 ` Joe Perches
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox