public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Umang Jain <umang.jain@ideasonboard.com>
Cc: linux-staging@lists.linux.dev,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org,
	Stefan Wahren <stefan.wahren@i2se.com>,
	Dan Carpenter <error27@gmail.com>,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Phil Elwell <phil@raspberrypi.com>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: Re: [PATCH 4/9] staging: vc04_services: Shorten helper function name
Date: Thu, 23 Nov 2023 13:11:39 +0000	[thread overview]
Message-ID: <2023112339-endorse-swaddling-be63@gregkh> (raw)
In-Reply-To: <20231107095156.365492-5-umang.jain@ideasonboard.com>

On Tue, Nov 07, 2023 at 04:51:51AM -0500, Umang Jain wrote:
> Shorten the helper log_category_str() to log_cat().
> Going forwards, this will be used at multiple places with
> dev_dbg().
> 
> No functiional changes intended in this patch.
> 
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
>  .../vc04_services/interface/vchiq_arm/vchiq_core.h     | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
> index 161358db457c..cc7bb6ca832a 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
> @@ -39,7 +39,7 @@ enum vchiq_log_category {
>  	VCHIQ_SUSPEND,
>  };
>  
> -static inline const char *log_category_str(enum vchiq_log_category c)
> +static inline const char *log_cat(enum vchiq_log_category c)

This is a bad name for a subsystem-wide function name, why is this
needed at all?

thanks,

greg k-h

  parent reply	other threads:[~2023-11-23 13:15 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-07  9:51 [PATCH 0/9] staging: vc04_services: Smatch fixes and remove custom logging Umang Jain
2023-11-07  9:51 ` [PATCH 1/9] staging: vc04_services: vchiq_core: Log through struct vchiq_instance Umang Jain
2023-11-23 12:57   ` Greg Kroah-Hartman
2023-11-23 13:42     ` Laurent Pinchart
2023-11-23 12:58   ` Greg Kroah-Hartman
2023-11-07  9:51 ` [PATCH 2/9] staging: vc04_services: Log using pr_err() when vchiq_state is unset Umang Jain
2023-11-23 13:02   ` Greg Kroah-Hartman
2023-11-07  9:51 ` [PATCH 3/9] staging: vc04_services: bcm2835-camera: Remove redundant null check Umang Jain
2023-11-07  9:51 ` [PATCH 4/9] staging: vc04_services: Shorten helper function name Umang Jain
2023-11-07 12:32   ` Kieran Bingham
2023-11-23 13:11   ` Greg Kroah-Hartman [this message]
2023-11-07  9:51 ` [PATCH 5/9] staging: vc04_services: Do not pass NULL to vchiq_log_error() Umang Jain
2023-11-07 12:25   ` Laurent Pinchart
2023-11-07 12:31     ` Umang Jain
2023-11-07 12:38       ` Laurent Pinchart
2023-11-23 12:57       ` Greg Kroah-Hartman
2023-11-23 13:41         ` Laurent Pinchart
2023-11-23 13:55           ` Greg Kroah-Hartman
2023-11-07 12:36     ` Laurent Pinchart
2023-11-10 10:21       ` Stefan Wahren
2023-11-13 13:44         ` Umang Jain
2023-11-28  6:22       ` Umang Jain
2023-11-07  9:51 ` [PATCH 6/9] staging: vc04_services: Drop vchiq_log_error() in favour of dev_dbg Umang Jain
2023-11-23 13:02   ` Greg Kroah-Hartman
2023-11-23 13:49     ` Laurent Pinchart
2023-11-23 13:53       ` Greg Kroah-Hartman
2023-11-23 17:28         ` Laurent Pinchart
2023-11-23 17:31           ` Greg Kroah-Hartman
2023-11-23 18:00             ` Laurent Pinchart
2023-11-26 10:26               ` Greg Kroah-Hartman
2023-11-26 14:52                 ` Laurent Pinchart
2023-11-07  9:51 ` [PATCH 7/9] staging: vc04_services: Drop vchiq_log_warning() " Umang Jain
2023-11-23 13:04   ` Greg Kroah-Hartman
2023-11-07  9:51 ` [PATCH 8/9] staging: vc04_services: Drop vchiq_log_trace() " Umang Jain
2023-11-07  9:51 ` [PATCH 9/9] staging: vc04_services: Drop vchiq_log_debug() " Umang Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023112339-endorse-swaddling-be63@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=error27@gmail.com \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=phil@raspberrypi.com \
    --cc=stefan.wahren@i2se.com \
    --cc=umang.jain@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox