* [PATCH 1/5] staging: rtl8192e; renamed variable HTMcsToDataRate
2023-11-21 18:14 [PATCH 0/5] staging: rtl8192e: renaming of 5 different variables patch series Gary Rookard
@ 2023-11-21 18:14 ` Gary Rookard
2023-11-21 18:14 ` [PATCH 2/5] staging: rtl8192e: renamed variable TXCountToDataRate Gary Rookard
` (5 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Gary Rookard @ 2023-11-21 18:14 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann; +Cc: linux-staging, linux-kernel, Gary Rookard
Renamed variable from Pascal/CamelCase to Snake case the variable
HTMcsToDataRate.
HTMcsToDataRate -> ht_mcs_to_data_rate
Linux Kernel coding style (cleanup), checkpatch Avoid CamelCase.
Driver/module rtl8192e compiles.
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index e607bccc079a..280e335cbb6d 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -103,7 +103,7 @@ void ht_update_default_setting(struct rtllib_device *ieee)
ht_info->rx_reorder_pending_time = 30;
}
-static u16 HTMcsToDataRate(struct rtllib_device *ieee, u8 nMcsRate)
+static u16 ht_mcs_to_data_rate(struct rtllib_device *ieee, u8 nMcsRate)
{
struct rt_hi_throughput *ht_info = ieee->ht_info;
@@ -422,8 +422,8 @@ u8 HTGetHighestMCSRate(struct rtllib_device *ieee, u8 *pMCSRateSet,
bitMap = availableMcsRate[i];
for (j = 0; j < 8; j++) {
if ((bitMap % 2) != 0) {
- if (HTMcsToDataRate(ieee, (8 * i + j)) >
- HTMcsToDataRate(ieee, mcsRate))
+ if (ht_mcs_to_data_rate(ieee, (8 * i + j)) >
+ ht_mcs_to_data_rate(ieee, mcsRate))
mcsRate = 8 * i + j;
}
bitMap >>= 1;
--
2.41.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 2/5] staging: rtl8192e: renamed variable TXCountToDataRate
2023-11-21 18:14 [PATCH 0/5] staging: rtl8192e: renaming of 5 different variables patch series Gary Rookard
2023-11-21 18:14 ` [PATCH 1/5] staging: rtl8192e; renamed variable HTMcsToDataRate Gary Rookard
@ 2023-11-21 18:14 ` Gary Rookard
2023-11-21 18:14 ` [PATCH 3/5] staging: rtl8192e: renamed variable IsHTHalfNmodeAPs Gary Rookard
` (4 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Gary Rookard @ 2023-11-21 18:14 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann; +Cc: linux-staging, linux-kernel, Gary Rookard
Renamed from Pascal/CamelCase to Snake case the variable
TXCountToDataRate.
TXCountToDataRate -> tx_count_to_data_rate
Linux kernel coding style (cleanup), checkpatch Avoid CamelCase.
Driver/module rtl8192e compiles.
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
drivers/staging/rtl8192e/rtllib.h | 2 +-
drivers/staging/rtl8192e/rtllib_softmac_wx.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 280e335cbb6d..fb8294f31a60 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -114,7 +114,7 @@ static u16 ht_mcs_to_data_rate(struct rtllib_device *ieee, u8 nMcsRate)
return MCS_DATA_RATE[is40MHz][isShortGI][(nMcsRate & 0x7f)];
}
-u16 TxCountToDataRate(struct rtllib_device *ieee, u8 nDataRate)
+u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate)
{
u16 CCKOFDMRate[12] = {0x02, 0x04, 0x0b, 0x16, 0x0c, 0x12, 0x18,
0x24, 0x30, 0x48, 0x60, 0x6c};
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index d2cf3cfaaaba..0226a69f40c3 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1783,7 +1783,7 @@ extern u16 MCS_DATA_RATE[2][2][77];
u8 HTCCheck(struct rtllib_device *ieee, u8 *pFrame);
void HTResetIOTSetting(struct rt_hi_throughput *ht_info);
bool IsHTHalfNmodeAPs(struct rtllib_device *ieee);
-u16 TxCountToDataRate(struct rtllib_device *ieee, u8 nDataRate);
+u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate);
int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb);
int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb);
int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb);
diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
index f32584291704..28aba1d610f7 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
@@ -208,7 +208,7 @@ int rtllib_wx_get_rate(struct rtllib_device *ieee,
{
u32 tmp_rate;
- tmp_rate = TxCountToDataRate(ieee,
+ tmp_rate = tx_count_to_data_rate(ieee,
ieee->softmac_stats.CurrentShowTxate);
wrqu->bitrate.value = tmp_rate * 500000;
--
2.41.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 3/5] staging: rtl8192e: renamed variable IsHTHalfNmodeAPs
2023-11-21 18:14 [PATCH 0/5] staging: rtl8192e: renaming of 5 different variables patch series Gary Rookard
2023-11-21 18:14 ` [PATCH 1/5] staging: rtl8192e; renamed variable HTMcsToDataRate Gary Rookard
2023-11-21 18:14 ` [PATCH 2/5] staging: rtl8192e: renamed variable TXCountToDataRate Gary Rookard
@ 2023-11-21 18:14 ` Gary Rookard
2023-11-21 18:14 ` [PATCH 4/5] staging: rtl8192e: renamed variable HTIOTPeerDetermine Gary Rookard
` (3 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Gary Rookard @ 2023-11-21 18:14 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann; +Cc: linux-staging, linux-kernel, Gary Rookard
Renamed from Pascal/CamelCase to Snake case the variable
IsHTHalfNmodeAPs.
ISHTHalfNmodeAPs -> is_ht_half_nmode_aps
Linux kernel coding style (cleanup), checkpatch Avoid CamelCase.
Driver/module rtl8192e compiles.
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
drivers/staging/rtl8192e/rtllib.h | 2 +-
drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index fb8294f31a60..0993263c13d3 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -139,7 +139,7 @@ u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate)
return MCS_DATA_RATE[is40MHz][isShortGI][nDataRate & 0xf];
}
-bool IsHTHalfNmodeAPs(struct rtllib_device *ieee)
+bool is_ht_half_nmode_aps(struct rtllib_device *ieee)
{
bool retValue = false;
struct rtllib_network *net = &ieee->current_network;
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 0226a69f40c3..6b549629087b 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1782,7 +1782,7 @@ extern u8 MCS_FILTER_ALL[];
extern u16 MCS_DATA_RATE[2][2][77];
u8 HTCCheck(struct rtllib_device *ieee, u8 *pFrame);
void HTResetIOTSetting(struct rt_hi_throughput *ht_info);
-bool IsHTHalfNmodeAPs(struct rtllib_device *ieee);
+bool is_ht_half_nmode_aps(struct rtllib_device *ieee);
u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate);
int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb);
int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb);
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index 42d652fe8601..89bc38774fa7 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -1872,7 +1872,7 @@ static void rtllib_rx_auth_resp(struct rtllib_device *ieee, struct sk_buff *skb)
ieee->softmac_stats.rx_auth_rs_ok++;
if (!(ieee->ht_info->iot_action & HT_IOT_ACT_PURE_N_MODE)) {
if (!ieee->GetNmodeSupportBySecCfg(ieee->dev)) {
- if (IsHTHalfNmodeAPs(ieee)) {
+ if (is_ht_half_nmode_aps(ieee)) {
bSupportNmode = true;
bHalfSupportNmode = true;
} else {
--
2.41.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 4/5] staging: rtl8192e: renamed variable HTIOTPeerDetermine
2023-11-21 18:14 [PATCH 0/5] staging: rtl8192e: renaming of 5 different variables patch series Gary Rookard
` (2 preceding siblings ...)
2023-11-21 18:14 ` [PATCH 3/5] staging: rtl8192e: renamed variable IsHTHalfNmodeAPs Gary Rookard
@ 2023-11-21 18:14 ` Gary Rookard
2023-11-21 18:14 ` [PATCH 5/5] staging: rtl8192e: renamed variable HTIOTActIsMgntUseCCK6M Gary Rookard
` (2 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Gary Rookard @ 2023-11-21 18:14 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann; +Cc: linux-staging, linux-kernel, Gary Rookard
Renamed from Pascal/CamelCase to Snake case the variable
HTIOTPeerDetermine.
HTIOTPeerDetermine -> ht_iot_peer_determine
Linux kernel coding style (cleanup), checkpatch Avoid CamelCase.
Driver/module rtl8192e compiles.
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 0993263c13d3..0873c19ca051 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -164,7 +164,7 @@ bool is_ht_half_nmode_aps(struct rtllib_device *ieee)
return retValue;
}
-static void HTIOTPeerDetermine(struct rtllib_device *ieee)
+static void ht_iot_peer_determine(struct rtllib_device *ieee)
{
struct rt_hi_throughput *ht_info = ieee->ht_info;
struct rtllib_network *net = &ieee->current_network;
@@ -672,7 +672,7 @@ void HTResetSelfAndSavePeerSetting(struct rtllib_device *ieee,
ht_info->RT2RT_HT_Mode = (enum rt_ht_capability)0;
}
- HTIOTPeerDetermine(ieee);
+ ht_iot_peer_determine(ieee);
ht_info->iot_action = 0;
bIOTAction = HTIOTActIsMgntUseCCK6M(ieee, pNetwork);
--
2.41.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 5/5] staging: rtl8192e: renamed variable HTIOTActIsMgntUseCCK6M
2023-11-21 18:14 [PATCH 0/5] staging: rtl8192e: renaming of 5 different variables patch series Gary Rookard
` (3 preceding siblings ...)
2023-11-21 18:14 ` [PATCH 4/5] staging: rtl8192e: renamed variable HTIOTPeerDetermine Gary Rookard
@ 2023-11-21 18:14 ` Gary Rookard
2023-11-21 21:39 ` [PATCH 0/5] staging: rtl8192e: renaming of 5 different variables patch series Philipp Hortmann
2023-11-23 12:44 ` Greg KH
6 siblings, 0 replies; 9+ messages in thread
From: Gary Rookard @ 2023-11-21 18:14 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann; +Cc: linux-staging, linux-kernel, Gary Rookard
Renamed from Pascal/CamelCase to Snake case the variable
HTIOTActIsMgntUseCCK6M.
HTIOTActIsMgntUseCCK6M -> ht_iot_act_is_mgnt_use_cck_6m
Linux kernel coding style (cleanup), checkpatch Avoid CamelCase.
Driver/module rtl8192e compiles.
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 0873c19ca051..f43249fd78d7 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -207,7 +207,7 @@ static void ht_iot_peer_determine(struct rtllib_device *ieee)
netdev_dbg(ieee->dev, "IOTPEER: %x\n", ht_info->IOTPeer);
}
-static u8 HTIOTActIsMgntUseCCK6M(struct rtllib_device *ieee,
+static u8 ht_iot_act_is_mgnt_use_cck_6m(struct rtllib_device *ieee,
struct rtllib_network *network)
{
u8 retValue = 0;
@@ -675,7 +675,7 @@ void HTResetSelfAndSavePeerSetting(struct rtllib_device *ieee,
ht_iot_peer_determine(ieee);
ht_info->iot_action = 0;
- bIOTAction = HTIOTActIsMgntUseCCK6M(ieee, pNetwork);
+ bIOTAction = ht_iot_act_is_mgnt_use_cck_6m(ieee, pNetwork);
if (bIOTAction)
ht_info->iot_action |= HT_IOT_ACT_MGNT_USE_CCK_6M;
bIOTAction = HTIOTActIsCCDFsync(ieee);
--
2.41.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 0/5] staging: rtl8192e: renaming of 5 different variables patch series
2023-11-21 18:14 [PATCH 0/5] staging: rtl8192e: renaming of 5 different variables patch series Gary Rookard
` (4 preceding siblings ...)
2023-11-21 18:14 ` [PATCH 5/5] staging: rtl8192e: renamed variable HTIOTActIsMgntUseCCK6M Gary Rookard
@ 2023-11-21 21:39 ` Philipp Hortmann
2023-11-23 12:44 ` Greg KH
6 siblings, 0 replies; 9+ messages in thread
From: Philipp Hortmann @ 2023-11-21 21:39 UTC (permalink / raw)
To: Gary Rookard, gregkh; +Cc: linux-staging, linux-kernel
On 11/21/23 19:14, Gary Rookard wrote:
> Hi,
>
> This patch series renames 5 different variables from
> Pascal/CamelCase to snake case.
>
> Linux kernel coding style (cleanup), checkpatch Avoid CamelCase.
> Driver/module rtl8291e compiles.
>
> Patch 1/5) renamed variable from HTMcsToDataRate -> ht_mcs_to_data_rate
> Patch 2/5) renamed variable from TXCountToDAtaRate -> tx-count_to_data_rate
> Patch 3/5) renamed variable from IsHTHalfNmodeAPs -> is_ht_half_nmode_aps
> Patch 4/5) renamed variable from HTIOTPeerDetermine -> ht_iot_peer_determine
> Patch 5/5) renamed variable from HTIOTActIsMgntUseCCK6M -> ht_iot_act_is_mgnt_use_cck_6m
>
> Regards,
> Gary
>
Hi Gary,
this patch series needs to be a V2 with change history.
The next patch series you are going to send is V3.
The cover letter of your patch series seems to be hand made. You can use
git to do this.
I am using this command to do this:
git format-patch -o ~/Documents/kernel/patches/ --cover-letter -n
--thread=shallow --to="Greg Kroah-Hartman
<gregkh@linuxfoundation.org>,linux-staging@lists.linux.dev,linux-kernel@vger.kernel.org"
7b88c62d3cc5c3fb670b5448c7381c7c099b3518^..HEAD
There are now 31 patches pending for this driver. May be it is a good
idea to wait until those are accepted or rejected. May be this is
happening on Thursday morning. Or you apply the patches before you put
yours on top:
https://lore.kernel.org/linux-staging/c464f4a8-753b-417c-97bb-7aa29ab5bf59@gmail.com/T/#t
https://lore.kernel.org/linux-staging/cover.1700296319.git.philipp.g.hortmann@gmail.com/T/#t
https://lore.kernel.org/linux-staging/d911d509-8677-444c-ad7f-92dd141e8e1e@suswa.mountain/T/#t
In case of question feel free to write to me.
Bye Philipp
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 0/5] staging: rtl8192e: renaming of 5 different variables patch series
2023-11-21 18:14 [PATCH 0/5] staging: rtl8192e: renaming of 5 different variables patch series Gary Rookard
` (5 preceding siblings ...)
2023-11-21 21:39 ` [PATCH 0/5] staging: rtl8192e: renaming of 5 different variables patch series Philipp Hortmann
@ 2023-11-23 12:44 ` Greg KH
6 siblings, 0 replies; 9+ messages in thread
From: Greg KH @ 2023-11-23 12:44 UTC (permalink / raw)
To: Gary Rookard; +Cc: philipp.g.hortmann, linux-staging, linux-kernel
On Tue, Nov 21, 2023 at 01:14:30PM -0500, Gary Rookard wrote:
> Hi,
>
> This patch series renames 5 different variables from
> Pascal/CamelCase to snake case.
>
> Linux kernel coding style (cleanup), checkpatch Avoid CamelCase.
> Driver/module rtl8291e compiles.
>
> Patch 1/5) renamed variable from HTMcsToDataRate -> ht_mcs_to_data_rate
> Patch 2/5) renamed variable from TXCountToDAtaRate -> tx-count_to_data_rate
> Patch 3/5) renamed variable from IsHTHalfNmodeAPs -> is_ht_half_nmode_aps
> Patch 4/5) renamed variable from HTIOTPeerDetermine -> ht_iot_peer_determine
> Patch 5/5) renamed variable from HTIOTActIsMgntUseCCK6M -> ht_iot_act_is_mgnt_use_cck_6m
>
> Regards,
> Gary
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/process/submitting-patches.rst for what
needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 9+ messages in thread