public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Gary Rookard <garyrookard@fastmail.org>
To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Gary Rookard <garyrookard@fastmail.org>
Subject: [PATCH 1/5] staging: rtl8192e: renamed 2 variables nMcsRate, mcsRate
Date: Sat, 25 Nov 2023 17:34:28 -0500	[thread overview]
Message-ID: <20231125223432.13780-2-garyrookard@fastmail.org> (raw)
In-Reply-To: <20231125223432.13780-1-garyrookard@fastmail.org>

Renamed 2 variables from CamelCase to Snake case nMcsRate
and mcsRate.
nMcsRate -> n_mcs_rate
mcs_Rate -> mcs_rate

Linux kernel coding style (cleanup), checkpatch Avoid CamelCase.
Driver/module rtl8192e compiles.

Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
 drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index f43249fd78d7..7e61ebd2bc25 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -103,7 +103,7 @@ void ht_update_default_setting(struct rtllib_device *ieee)
 	ht_info->rx_reorder_pending_time = 30;
 }
 
-static u16 ht_mcs_to_data_rate(struct rtllib_device *ieee, u8 nMcsRate)
+static u16 ht_mcs_to_data_rate(struct rtllib_device *ieee, u8 n_mcs_rate)
 {
 	struct rt_hi_throughput *ht_info = ieee->ht_info;
 
@@ -111,7 +111,7 @@ static u16 ht_mcs_to_data_rate(struct rtllib_device *ieee, u8 nMcsRate)
 	u8	isShortGI = (ht_info->bCurBW40MHz) ?
 			    ((ht_info->bCurShortGI40MHz) ? 1 : 0) :
 			    ((ht_info->bCurShortGI20MHz) ? 1 : 0);
-	return MCS_DATA_RATE[is40MHz][isShortGI][(nMcsRate & 0x7f)];
+	return MCS_DATA_RATE[is40MHz][isShortGI][(n_mcs_rate & 0x7f)];
 }
 
 u16  tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate)
@@ -398,7 +398,7 @@ u8 HTGetHighestMCSRate(struct rtllib_device *ieee, u8 *pMCSRateSet,
 {
 	u8		i, j;
 	u8		bitMap;
-	u8		mcsRate = 0;
+	u8		mcs_rate = 0;
 	u8		availableMcsRate[16];
 
 	if (!pMCSRateSet || !pMCSFilter) {
@@ -423,14 +423,14 @@ u8 HTGetHighestMCSRate(struct rtllib_device *ieee, u8 *pMCSRateSet,
 			for (j = 0; j < 8; j++) {
 				if ((bitMap % 2) != 0) {
 					if (ht_mcs_to_data_rate(ieee, (8 * i + j)) >
-					    ht_mcs_to_data_rate(ieee, mcsRate))
-						mcsRate = 8 * i + j;
+					    ht_mcs_to_data_rate(ieee, mcs_rate))
+						mcs_rate = 8 * i + j;
 				}
 				bitMap >>= 1;
 			}
 		}
 	}
-	return mcsRate | 0x80;
+	return mcs_rate | 0x80;
 }
 
 static u8 HTFilterMCSRate(struct rtllib_device *ieee, u8 *pSupportMCS,
-- 
2.41.0


  reply	other threads:[~2023-11-25 22:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-25 22:34 [PATCH 0/5] staging: rtl8192e: patch series renaming (6) different variables Gary Rookard
2023-11-25 22:34 ` Gary Rookard [this message]
2023-11-26 10:30   ` [PATCH 1/5] staging: rtl8192e: renamed 2 variables nMcsRate, mcsRate Greg KH
2023-11-26 10:42     ` Gary Rookard
2023-11-25 22:34 ` [PATCH 2/5] staging: rtl8192e: renamed variable isShortGI Gary Rookard
2023-11-25 22:34 ` [PATCH 3/5] staging: rtl8192e: renamed variable bCurBW40MHz Gary Rookard
2023-11-26 10:29   ` Greg KH
2023-11-26 10:46     ` Gary Rookard
2023-11-25 22:34 ` [PATCH 4/5] staging: rtl8192e: renamed variable nDataRate Gary Rookard
2023-11-26 10:29   ` Greg KH
2023-11-26 10:48     ` Gary Rookard
2023-11-25 22:34 ` [PATCH 5/5] staging: rtl8192e: renamed variable is40MHz Gary Rookard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231125223432.13780-2-garyrookard@fastmail.org \
    --to=garyrookard@fastmail.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=philipp.g.hortmann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox