From: Greg KH <gregkh@linuxfoundation.org>
To: Gary Rookard <garyrookard@fastmail.org>
Cc: philipp.g.hortmann@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] staging: rtl8192e: renamed variable nDataRate
Date: Sun, 26 Nov 2023 10:29:16 +0000 [thread overview]
Message-ID: <2023112622-jigsaw-scrambler-d385@gregkh> (raw)
In-Reply-To: <20231125223432.13780-5-garyrookard@fastmail.org>
On Sat, Nov 25, 2023 at 05:34:31PM -0500, Gary Rookard wrote:
> -u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate)
> +u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 n_data_rate)
Why are you keeping the "n"? It's not needed, right? Remember, these
were written in "Hungarian notation" which uses the variable name to
denote the type of the variable, so "n" means "number" perhaps? So it
can be dropped.
thanks,
greg k-h
next prev parent reply other threads:[~2023-11-26 10:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-25 22:34 [PATCH 0/5] staging: rtl8192e: patch series renaming (6) different variables Gary Rookard
2023-11-25 22:34 ` [PATCH 1/5] staging: rtl8192e: renamed 2 variables nMcsRate, mcsRate Gary Rookard
2023-11-26 10:30 ` Greg KH
2023-11-26 10:42 ` Gary Rookard
2023-11-25 22:34 ` [PATCH 2/5] staging: rtl8192e: renamed variable isShortGI Gary Rookard
2023-11-25 22:34 ` [PATCH 3/5] staging: rtl8192e: renamed variable bCurBW40MHz Gary Rookard
2023-11-26 10:29 ` Greg KH
2023-11-26 10:46 ` Gary Rookard
2023-11-25 22:34 ` [PATCH 4/5] staging: rtl8192e: renamed variable nDataRate Gary Rookard
2023-11-26 10:29 ` Greg KH [this message]
2023-11-26 10:48 ` Gary Rookard
2023-11-25 22:34 ` [PATCH 5/5] staging: rtl8192e: renamed variable is40MHz Gary Rookard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023112622-jigsaw-scrambler-d385@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=garyrookard@fastmail.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox