public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Umang Jain <umang.jain@ideasonboard.com>
To: linux-staging@lists.linux.dev,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org
Cc: Stefan Wahren <stefan.wahren@i2se.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Dan Carpenter <error27@gmail.com>,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	"Ricardo B . Marliere" <ricardo@marliere.net>,
	Umang Jain <umang.jain@ideasonboard.com>
Subject: [PATCH v2 0/5] staging: vc04_services: Drop custom logging
Date: Wed, 29 Nov 2023 01:49:21 +0530	[thread overview]
Message-ID: <20231128201926.489269-1-umang.jain@ideasonboard.com> (raw)

This series also removes the vchiq_log_* macro and makes use of dev_dbg()
directly.

Patch 1/5 is fix. It prevents passing NULL to one of vchiq_log_error().
The function there in question, does not have any users as of
now. However, it is going to be used by the vc-sm-cma and bcm2835-isp
drivers (posted on list for review [1]). There was discussion on v1,
whether I should drop and add the function later, however, didn't 
conclude.

Patch 2/5 removes vchiq_log_error() macro
Patch 3/5 removes vchiq_log_warning() macro
Patch 4/5 removes vchiq_log_trace() macro
Patch 5/5 removes vchiq_log_debug() macro

This completes the following TODO item:

```
* Cleanup logging mechanism

The driver should probably be using the standard kernel logging mechanisms
such as dev_info, dev_dbg, and friends.
```

[1]: https://lore.kernel.org/linux-media/20231109210309.638594-1-umang.jain@ideasonboard.com/

Changes in v2:
- Separate out one fixup patch from v1 (Patch 1/9)and send separately
- Drop usage of log_type() and log_category() helpers. Directly use
  dev_dbg() as suggested by Greg KH.
- Drop __func__ annotation from all logs. Dynamic debug has 'f'
  decorator flag which can be used instead of manual __func__
- Reword commit messages.

Umang Jain (5):
  staging: vc04_services: Do not pass NULL to vchiq_log_error()
  staging: vc04_services: Drop vchiq_log_error() in favour of dev_dbg
  staging: vc04_services: Drop vchiq_log_warning() in favour of dev_dbg
  staging: vc04_services: Drop vchiq_log_trace() in favour of dev_dbg
  staging: vc04_services: Drop vchiq_log_debug() in favour of dev_dbg

 drivers/staging/vc04_services/interface/TODO  |   5 -
 .../interface/vchiq_arm/vchiq_arm.c           | 176 ++++----
 .../interface/vchiq_arm/vchiq_connected.c     |   8 +-
 .../interface/vchiq_arm/vchiq_connected.h     |   4 +-
 .../interface/vchiq_arm/vchiq_core.c          | 402 +++++++++---------
 .../interface/vchiq_arm/vchiq_core.h          |  38 --
 .../interface/vchiq_arm/vchiq_dev.c           |  92 ++--
 7 files changed, 315 insertions(+), 410 deletions(-)

-- 
2.41.0


             reply	other threads:[~2023-11-28 20:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-28 20:19 Umang Jain [this message]
2023-11-28 20:19 ` [PATCH v2 1/5] staging: vc04_services: Do not pass NULL to vchiq_log_error() Umang Jain
2023-11-28 20:19 ` [PATCH v2 2/5] staging: vc04_services: Drop vchiq_log_error() in favour of dev_dbg Umang Jain
2023-11-28 20:19 ` [PATCH v2 3/5] staging: vc04_services: Drop vchiq_log_warning() " Umang Jain
2023-11-28 20:19 ` [PATCH v2 4/5] staging: vc04_services: Drop vchiq_log_trace() " Umang Jain
2023-11-28 20:19 ` [PATCH v2 5/5] staging: vc04_services: Drop vchiq_log_debug() " Umang Jain
2023-11-28 23:26 ` [PATCH v2 0/5] staging: vc04_services: Drop custom logging Stefan Wahren
2023-12-05  6:39   ` Umang Jain
2023-12-05 19:18     ` Stefan Wahren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231128201926.489269-1-umang.jain@ideasonboard.com \
    --to=umang.jain@ideasonboard.com \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=error27@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=ricardo@marliere.net \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox