From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E3862375B;
	Mon,  4 Dec 2023 12:22:01 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="o8PKmUAZ"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25AA5C433BA;
	Mon,  4 Dec 2023 12:22:01 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1701692521;
	bh=NcAANKt1lnRvaxYqIUFqYUMHhA7/3PgO5ncSrMk9pSk=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=o8PKmUAZKUvlwxeNS4xMomT8R7/MVUYVoiobUamnKqtoUTu3bIb1qEBqes/PdiJNQ
	 J+1FpJZPGSg+STyvpglw8l/ZxtjnXcsgXhTl2JWXseitoxNh0xk2CbwcqPE0zq21Oo
	 jV067nCYDxmqJd/PAaQ7Scu+EJtOshr925tJep1U=
Date: Mon, 4 Dec 2023 08:08:27 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Umang Jain <umang.jain@ideasonboard.com>
Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org,
	Stefan Wahren <stefan.wahren@i2se.com>,
	Dan Carpenter <error27@gmail.com>,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	"Ricardo B . Marliere" <ricardo@marliere.net>
Subject: Re: [PATCH v2 0/2] staging: vc04_services: Use %p to log pointer
Message-ID: <2023120459-irregular-cost-1785@gregkh>
References: <20231128202007.489294-1-umang.jain@ideasonboard.com>
Precedence: bulk
X-Mailing-List: linux-staging@lists.linux.dev
List-Id: <linux-staging.lists.linux.dev>
List-Subscribe: <mailto:linux-staging+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:linux-staging+unsubscribe@lists.linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231128202007.489294-1-umang.jain@ideasonboard.com>

On Wed, Nov 29, 2023 at 01:50:05AM +0530, Umang Jain wrote:
> %lx is used to print the unmodified pointer address for debugging.
> %p will print the hashed pointer address to avoid leaking information
> about kernel memory layout to userspace. But when `no_hash_pointers`
> is passed as kernel parameter, unmodified pointer address will be
> printed.
> 
> Hence, drop %lx in favour of %p. For debugging purposes, one can
> easily depend on `no_hash_pointers`.
> 
> This also solves the following smatch warnings:
> service_callback() warn: argument 7 to %lx specifier is cast from pointer
> service_callback() warn: argument 11 to %lx specifier is cast from pointer
> service_callback() warn: argument 12 to %lx specifier is cast from pointer
> service_callback() warn: argument 13 to %lx specifier is cast from pointer
> vchiq_release() warn: argument 7 to %lx specifier is cast from pointer
> 
> Changes in v2:
> - Built/Rebased on top of:
>   [PATCH v2 0/5] staging: vc04_services: Drop custom logging
> 
> Umang Jain (2):
>   staging: vc04_services: Use %p to log pointer address
>   staging: vc04_services: Use %p to log pointer address

You have 2 different patches that do different things, yet have the
identical subject lines.  That needs to be fixed up before I can take
them.

thanks,

greg k-h