From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Umang Jain <umang.jain@ideasonboard.com>
Cc: Stefan Wahren <wahrenst@gmx.net>,
linux-staging@lists.linux.dev,
linux-rpi-kernel@lists.infradead.org,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Stefan Wahren <stefan.wahren@i2se.com>,
Dan Carpenter <error27@gmail.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
"Ricardo B . Marliere" <ricardo@marliere.net>
Subject: Re: [PATCH v3 1/4] staging: vc04_services: Drop vchiq_log_error() in favour of dev_err
Date: Thu, 7 Dec 2023 11:39:07 +0900 [thread overview]
Message-ID: <2023120750-engorge-wham-83a0@gregkh> (raw)
In-Reply-To: <6a8566c0-bd26-4ec1-9f7d-d58bbed8411c@ideasonboard.com>
On Wed, Dec 06, 2023 at 10:57:59AM +0530, Umang Jain wrote:
> Hi Stefan
>
> On 12/6/23 1:02 AM, Stefan Wahren wrote:
> > Hi Umang,
> >
> > Am 05.12.23 um 09:41 schrieb Umang Jain:
> > > Drop vchiq_log_error() macro which wraps dev_dbg(). Introduce the usage
> > > of dev_err() directly.
> > sorry, i missed to review the last change. So the change won't be that
> > trivial.
>
> All the changes you said are valid and I have taken a note of it.
>
> However, I think it would best that if we can address them in a separate
> series on top of this (and I will do it). It would seem to be streamlined on
> top of this.
Agreed, I'll merge this now so you can make forward progress here,
thanks!
greg k-h
next prev parent reply other threads:[~2023-12-07 6:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 8:41 [PATCH v3 0/4] staging: vc04_services: Drop custom logging Umang Jain
2023-12-05 8:41 ` [PATCH v3 1/4] staging: vc04_services: Drop vchiq_log_error() in favour of dev_err Umang Jain
2023-12-05 19:32 ` Stefan Wahren
2023-12-06 5:27 ` Umang Jain
2023-12-06 21:34 ` Stefan Wahren
2023-12-07 8:41 ` Umang Jain
2023-12-07 22:28 ` Stefan Wahren
2023-12-07 2:39 ` Greg Kroah-Hartman [this message]
2023-12-05 8:41 ` [PATCH v3 2/4] staging: vc04_services: Drop vchiq_log_warning() in favour of dev_warn Umang Jain
2023-12-05 19:37 ` Stefan Wahren
2023-12-05 8:41 ` [PATCH v3 3/4] staging: vc04_services: Drop vchiq_log_trace() in favour of dev_dbg Umang Jain
2023-12-08 12:08 ` Stefan Wahren
2023-12-09 6:27 ` Dan Carpenter
2023-12-09 9:33 ` Stefan Wahren
2023-12-05 8:41 ` [PATCH v3 4/4] staging: vc04_services: Drop vchiq_log_debug() " Umang Jain
2023-12-08 13:00 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023120750-engorge-wham-83a0@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=error27@gmail.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=ricardo@marliere.net \
--cc=stefan.wahren@i2se.com \
--cc=umang.jain@ideasonboard.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox