public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Gary Rookard <garyrookard@fastmail.org>
To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Gary Rookard <garyrookard@fastmail.org>
Subject: [PATCH 1/5] staging: rtl8192e: rename variable posHTCap
Date: Tue, 12 Dec 2023 11:56:33 -0500	[thread overview]
Message-ID: <20231212165637.17618-2-garyrookard@fastmail.org> (raw)
In-Reply-To: <20231212165637.17618-1-garyrookard@fastmail.org>

Coding style issue, checkpatch Avoid CamelCase,
rename it. posHTCap -> pos_ht_cap

Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
 drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 14e25f87c1bf..eb798a3a9052 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -247,27 +247,27 @@ void ht_reset_iot_setting(struct rt_hi_throughput *ht_info)
 	ht_info->iot_ra_func = 0;
 }
 
-void ht_construct_capability_element(struct rtllib_device *ieee, u8 *posHTCap,
+void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap,
 				  u8 *len, u8 IsEncrypt, bool bAssoc)
 {
 	struct rt_hi_throughput *pHT = ieee->ht_info;
 	struct ht_capab_ele *pCapELE = NULL;
 
-	if (!posHTCap || !pHT) {
+	if (!pos_ht_cap || !pHT) {
 		netdev_warn(ieee->dev,
 			    "%s(): posHTCap and ht_info are null\n", __func__);
 		return;
 	}
-	memset(posHTCap, 0, *len);
+	memset(pos_ht_cap, 0, *len);
 
 	if ((bAssoc) && (pHT->ePeerHTSpecVer == HT_SPEC_VER_EWC)) {
 		static const u8	EWC11NHTCap[] = { 0x00, 0x90, 0x4c, 0x33 };
 
-		memcpy(posHTCap, EWC11NHTCap, sizeof(EWC11NHTCap));
-		pCapELE = (struct ht_capab_ele *)&posHTCap[4];
+		memcpy(pos_ht_cap, EWC11NHTCap, sizeof(EWC11NHTCap));
+		pCapELE = (struct ht_capab_ele *)&pos_ht_cap[4];
 		*len = 30 + 2;
 	} else {
-		pCapELE = (struct ht_capab_ele *)posHTCap;
+		pCapELE = (struct ht_capab_ele *)pos_ht_cap;
 		*len = 26 + 2;
 	}
 
-- 
2.41.0


  reply	other threads:[~2023-12-12 16:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-12 16:56 [PATCH 0/5] [Series 2] rename variable posHTCap and (4) others Gary Rookard
2023-12-12 16:56 ` Gary Rookard [this message]
2023-12-12 16:56 ` [PATCH 2/5] staging: rtl8192e: rename variable IsEncrypt Gary Rookard
2023-12-12 16:56 ` [PATCH 3/5] staging: rtl8192e: rename variable bAssoc Gary Rookard
2023-12-12 16:56 ` [PATCH 4/5] staging: rtl8192e: rename variable pHT Gary Rookard
2023-12-12 18:56   ` Philipp Hortmann
2023-12-12 20:14     ` Gary Rookard
2023-12-13  7:40     ` Dan Carpenter
2023-12-12 16:56 ` [PATCH 5/5] staging: rtl8192e: rename variable pCapELE Gary Rookard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231212165637.17618-2-garyrookard@fastmail.org \
    --to=garyrookard@fastmail.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=philipp.g.hortmann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox