[PATCH] staging: rtl8192e: Add blank line after declarations

[PATCH] staging: rtl8192e: Add blank line after declarations

[Nathan DSilva]

Found using checkpatch, removes one warning about line breaks after
declarations.

This is my first patch, feedback is welcome. I am submitting this as a test
before moving to other subsystems to (hopefully) make more meaningful
contributions.

Signed-off-by: Nathan DSilva <expitau@gmail.com>
---
 drivers/staging/rtl8192e/rtllib_rx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index ecaa4dec3f94..397859c7f5b1 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -946,6 +946,7 @@ static int rtllib_rx_data_filter(struct rtllib_device *ieee, struct ieee80211_hd
 {
 	u8 type, stype;
 	u16 fc = le16_to_cpu(hdr->frame_control);
+
 	type = WLAN_FC_GET_TYPE(fc);
 	stype = WLAN_FC_GET_STYPE(fc);
 
-- 
2.43.0

Re: [PATCH] staging: rtl8192e: Add blank line after declarations

[<Tree Davies]

On Fri, Dec 15, 2023 at 03:28:52AM +0000, Nathan DSilva wrote:
> Found using checkpatch, removes one warning about line breaks after
> declarations.
> 
> This is my first patch, feedback is welcome. I am submitting this as a test
> before moving to other subsystems to (hopefully) make more meaningful
> contributions.
> 
> Signed-off-by: Nathan DSilva <expitau@gmail.com>
> ---
>  drivers/staging/rtl8192e/rtllib_rx.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
> index ecaa4dec3f94..397859c7f5b1 100644
> --- a/drivers/staging/rtl8192e/rtllib_rx.c
> +++ b/drivers/staging/rtl8192e/rtllib_rx.c
> @@ -946,6 +946,7 @@ static int rtllib_rx_data_filter(struct rtllib_device *ieee, struct ieee80211_hd
>  {
>  	u8 type, stype;
>  	u16 fc = le16_to_cpu(hdr->frame_control);
> +
>  	type = WLAN_FC_GET_TYPE(fc);
>  	stype = WLAN_FC_GET_STYPE(fc);
>  
> -- 
> 2.43.0

Hi Nathan,

Thanks for your patch, but here are few comments.

1. Your subject line looks good. Keep it.

2. Your commit message should read something like.. 'Do x to fix Y'.
There are lots of examples in the log for this driver which demonstrates this.
You don't want 'This is first patch' in the commit log.

3. For this driver, it is best to send your patches to Greg, Philipp Hortmann,
and Dan Carpenter (error27@gmail.com) looks at them sometimes too. And like you
did, cc the mailing lists.

For example, My setup usually looks like...
git send-email ./patches/*  --to=gregkh@linuxfoundation.org --to=philipp.g.hortmann@gmail.com --to=anjan@momi.ca  --cc=linux-staging@lists.linux.dev --cc=linux-kernel@vger.kernel.org

A good source of info for sending patches can be foound here:
at https://docs.kernel.org/process/submitting-patches.html
and also there is a free tutorial at:
https://trainingportal.linuxfoundation.org/courses/a-beginners-guide-to-linux-kernel-development-lfd103

I'm a newbie myself, but I'm happy to help.
Cheers
Tree



 
  

Re: [PATCH] staging: rtl8192e: Add blank line after declarations

[Greg KH]

On Fri, Dec 15, 2023 at 03:28:52AM +0000, Nathan DSilva wrote:
> Found using checkpatch, removes one warning about line breaks after
> declarations.
> 
> This is my first patch, feedback is welcome. I am submitting this as a test
> before moving to other subsystems to (hopefully) make more meaningful
> contributions.
> 
> Signed-off-by: Nathan DSilva <expitau@gmail.com>
> ---
>  drivers/staging/rtl8192e/rtllib_rx.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
> index ecaa4dec3f94..397859c7f5b1 100644
> --- a/drivers/staging/rtl8192e/rtllib_rx.c
> +++ b/drivers/staging/rtl8192e/rtllib_rx.c
> @@ -946,6 +946,7 @@ static int rtllib_rx_data_filter(struct rtllib_device *ieee, struct ieee80211_hd
>  {
>  	u8 type, stype;
>  	u16 fc = le16_to_cpu(hdr->frame_control);
> +
>  	type = WLAN_FC_GET_TYPE(fc);
>  	stype = WLAN_FC_GET_STYPE(fc);
>  
> -- 
> 2.43.0
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what is needed in
  order to properly describe the change.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

[PATCH v2] staging: rtl8192e: Add blank line after declarations

[Nathan DSilva]

Remove a warning about line breaks after declarations found by checkpatch.

Signed-off-by: Nathan DSilva <expitau@gmail.com>
---

Thank you very much for your response. I didn't realize you could select
multiple --to recipients, or that you could have comments not in the changelog.

 drivers/staging/rtl8192e/rtllib_rx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index ecaa4dec3f94..397859c7f5b1 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -946,6 +946,7 @@ static int rtllib_rx_data_filter(struct rtllib_device *ieee, struct ieee80211_hd
 {
 	u8 type, stype;
 	u16 fc = le16_to_cpu(hdr->frame_control);
+
 	type = WLAN_FC_GET_TYPE(fc);
 	stype = WLAN_FC_GET_STYPE(fc);
 
-- 
2.43.0

Re: [PATCH v2] staging: rtl8192e: Add blank line after declarations

[Greg KH]

On Fri, Dec 15, 2023 at 03:29:18PM +0000, Nathan DSilva wrote:
> Remove a warning about line breaks after declarations found by checkpatch.
> 
> Signed-off-by: Nathan DSilva <expitau@gmail.com>
> ---
> 
> Thank you very much for your response. I didn't realize you could select
> multiple --to recipients, or that you could have comments not in the changelog.
> 
>  drivers/staging/rtl8192e/rtllib_rx.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
> index ecaa4dec3f94..397859c7f5b1 100644
> --- a/drivers/staging/rtl8192e/rtllib_rx.c
> +++ b/drivers/staging/rtl8192e/rtllib_rx.c
> @@ -946,6 +946,7 @@ static int rtllib_rx_data_filter(struct rtllib_device *ieee, struct ieee80211_hd
>  {
>  	u8 type, stype;
>  	u16 fc = le16_to_cpu(hdr->frame_control);
> +
>  	type = WLAN_FC_GET_TYPE(fc);
>  	stype = WLAN_FC_GET_STYPE(fc);
>  
> -- 
> 2.43.0
> 


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH] staging: rtl8192e: Add blank line after declarations

[Dan Carpenter]

On Thu, Dec 14, 2023 at 09:06:04PM -0800, <Tree Davies wrote:
> 3. For this driver, it is best to send your patches to Greg, Philipp Hortmann,
> and Dan Carpenter (error27@gmail.com) looks at them sometimes too. And like you
> did, cc the mailing lists.

You don't need to CC me.  I'm on the list.  Just use get_maintainer.pl.

Otherwise your advise was correct.

regards,
dan carpenter

Re: [PATCH v2] staging: rtl8192e: Add blank line after declarations

[Dan Carpenter]

On Fri, Dec 15, 2023 at 03:29:18PM +0000, Nathan DSilva wrote:
> Remove a warning about line breaks after declarations found by checkpatch.
> 
> Signed-off-by: Nathan DSilva <expitau@gmail.com>
> ---
> 
> Thank you very much for your response. I didn't realize you could select
> multiple --to recipients, or that you could have comments not in the changelog.
> 

This should say:

v2: Fix commit message
v3: Improve these notes about changes between versions

Otherwise it looks okay.

regards,
dan carpenter

Re: [PATCH v2] staging: rtl8192e: Add blank line after declarations

[Dan Carpenter]

Also send the v3 as a new thread.  See my blog for more details?

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch

regards,
dan carpenter