* [PATCH v2 1/4] staging: rtl8192e: rename variable pHT
2023-12-16 1:01 [PATCH v2 0/4] [Series 4] staging: rtl8192e: rename variable pHT and (3) other Gary Rookard
@ 2023-12-16 1:01 ` Gary Rookard
2023-12-16 1:01 ` [PATCH v2 2/4] staging: rtl8192e: rename variable pCapELE Gary Rookard
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Gary Rookard @ 2023-12-16 1:01 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann; +Cc: linux-staging, linux-kernel, Gary Rookard
Coding style issue, checkpatch Avoid CamelCase,
rename it. pHT -> ht
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
v2: Corrections to make applicable.
v1: Not applicable, conflicting line numbers, code changed.
drivers/staging/rtl8192e/rtl819x_HTProc.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 90a9356d78ca..29c3d33bf5a6 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -230,17 +230,17 @@ void ht_reset_iot_setting(struct rt_hi_throughput *ht_info)
void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap,
u8 *len, u8 is_encrypt, bool assoc)
{
- struct rt_hi_throughput *pHT = ieee->ht_info;
+ struct rt_hi_throughput *ht = ieee->ht_info;
struct ht_capab_ele *pCapELE = NULL;
- if (!pos_ht_cap || !pHT) {
+ if (!pos_ht_cap || !ht) {
netdev_warn(ieee->dev,
"%s(): posHTCap and ht_info are null\n", __func__);
return;
}
memset(pos_ht_cap, 0, *len);
- if ((assoc) && (pHT->ePeerHTSpecVer == HT_SPEC_VER_EWC)) {
+ if ((assoc) && (ht->ePeerHTSpecVer == HT_SPEC_VER_EWC)) {
static const u8 EWC11NHTCap[] = { 0x00, 0x90, 0x4c, 0x33 };
memcpy(pos_ht_cap, EWC11NHTCap, sizeof(EWC11NHTCap));
@@ -289,16 +289,16 @@ void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap,
pCapELE->ASCap = 0;
if (assoc) {
- if (pHT->iot_action & HT_IOT_ACT_DISABLE_MCS15)
+ if (ht->iot_action & HT_IOT_ACT_DISABLE_MCS15)
pCapELE->MCS[1] &= 0x7f;
- if (pHT->iot_action & HT_IOT_ACT_DISABLE_MCS14)
+ if (ht->iot_action & HT_IOT_ACT_DISABLE_MCS14)
pCapELE->MCS[1] &= 0xbf;
- if (pHT->iot_action & HT_IOT_ACT_DISABLE_ALL_2SS)
+ if (ht->iot_action & HT_IOT_ACT_DISABLE_ALL_2SS)
pCapELE->MCS[1] &= 0x00;
- if (pHT->iot_action & HT_IOT_ACT_DISABLE_RX_40MHZ_SHORT_GI)
+ if (ht->iot_action & HT_IOT_ACT_DISABLE_RX_40MHZ_SHORT_GI)
pCapELE->ShortGI40Mhz = 0;
if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev)) {
--
2.41.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2 2/4] staging: rtl8192e: rename variable pCapELE
2023-12-16 1:01 [PATCH v2 0/4] [Series 4] staging: rtl8192e: rename variable pHT and (3) other Gary Rookard
2023-12-16 1:01 ` [PATCH v2 1/4] staging: rtl8192e: rename variable pHT Gary Rookard
@ 2023-12-16 1:01 ` Gary Rookard
2023-12-16 1:01 ` [PATCH v2 3/4] staging: rtl8192e: rename variable HTGetHighestMCSRate Gary Rookard
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Gary Rookard @ 2023-12-16 1:01 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann; +Cc: linux-staging, linux-kernel, Gary Rookard
Coding style issue, checkpatch Avoid CamelCase,
rename it. pCapELE -> cap_ele
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
v2: Corrections to make applicable.
v1: Not applicable, conflicting line numbers, code changed.
drivers/staging/rtl8192e/rtl819x_HTProc.c | 64 +++++++++++------------
1 file changed, 32 insertions(+), 32 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 29c3d33bf5a6..8d9037130424 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -231,7 +231,7 @@ void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap,
u8 *len, u8 is_encrypt, bool assoc)
{
struct rt_hi_throughput *ht = ieee->ht_info;
- struct ht_capab_ele *pCapELE = NULL;
+ struct ht_capab_ele *cap_ele = NULL;
if (!pos_ht_cap || !ht) {
netdev_warn(ieee->dev,
@@ -244,66 +244,66 @@ void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap,
static const u8 EWC11NHTCap[] = { 0x00, 0x90, 0x4c, 0x33 };
memcpy(pos_ht_cap, EWC11NHTCap, sizeof(EWC11NHTCap));
- pCapELE = (struct ht_capab_ele *)&pos_ht_cap[4];
+ cap_ele = (struct ht_capab_ele *)&pos_ht_cap[4];
*len = 30 + 2;
} else {
- pCapELE = (struct ht_capab_ele *)pos_ht_cap;
+ cap_ele = (struct ht_capab_ele *)pos_ht_cap;
*len = 26 + 2;
}
- pCapELE->AdvCoding = 0;
+ cap_ele->AdvCoding = 0;
if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev))
- pCapELE->ChlWidth = 0;
+ cap_ele->ChlWidth = 0;
else
- pCapELE->ChlWidth = 1;
+ cap_ele->ChlWidth = 1;
- pCapELE->MimoPwrSave = 3;
- pCapELE->GreenField = 0;
- pCapELE->ShortGI20Mhz = 1;
- pCapELE->ShortGI40Mhz = 1;
+ cap_ele->MimoPwrSave = 3;
+ cap_ele->GreenField = 0;
+ cap_ele->ShortGI20Mhz = 1;
+ cap_ele->ShortGI40Mhz = 1;
- pCapELE->TxSTBC = 1;
- pCapELE->RxSTBC = 0;
- pCapELE->DelayBA = 0;
- pCapELE->MaxAMSDUSize = (MAX_RECEIVE_BUFFER_SIZE >= 7935) ? 1 : 0;
- pCapELE->DssCCk = 1;
- pCapELE->PSMP = 0;
- pCapELE->LSigTxopProtect = 0;
+ cap_ele->TxSTBC = 1;
+ cap_ele->RxSTBC = 0;
+ cap_ele->DelayBA = 0;
+ cap_ele->MaxAMSDUSize = (MAX_RECEIVE_BUFFER_SIZE >= 7935) ? 1 : 0;
+ cap_ele->DssCCk = 1;
+ cap_ele->PSMP = 0;
+ cap_ele->LSigTxopProtect = 0;
netdev_dbg(ieee->dev,
"TX HT cap/info ele BW=%d MaxAMSDUSize:%d DssCCk:%d\n",
- pCapELE->ChlWidth, pCapELE->MaxAMSDUSize, pCapELE->DssCCk);
+ cap_ele->ChlWidth, cap_ele->MaxAMSDUSize, cap_ele->DssCCk);
if (is_encrypt) {
- pCapELE->MPDUDensity = 7;
- pCapELE->MaxRxAMPDUFactor = 2;
+ cap_ele->MPDUDensity = 7;
+ cap_ele->MaxRxAMPDUFactor = 2;
} else {
- pCapELE->MaxRxAMPDUFactor = 3;
- pCapELE->MPDUDensity = 0;
+ cap_ele->MaxRxAMPDUFactor = 3;
+ cap_ele->MPDUDensity = 0;
}
- memcpy(pCapELE->MCS, ieee->reg_dot11ht_oper_rate_set, 16);
- memset(&pCapELE->ExtHTCapInfo, 0, 2);
- memset(pCapELE->TxBFCap, 0, 4);
+ memcpy(cap_ele->MCS, ieee->reg_dot11ht_oper_rate_set, 16);
+ memset(&cap_ele->ExtHTCapInfo, 0, 2);
+ memset(cap_ele->TxBFCap, 0, 4);
- pCapELE->ASCap = 0;
+ cap_ele->ASCap = 0;
if (assoc) {
if (ht->iot_action & HT_IOT_ACT_DISABLE_MCS15)
- pCapELE->MCS[1] &= 0x7f;
+ cap_ele->MCS[1] &= 0x7f;
if (ht->iot_action & HT_IOT_ACT_DISABLE_MCS14)
- pCapELE->MCS[1] &= 0xbf;
+ cap_ele->MCS[1] &= 0xbf;
if (ht->iot_action & HT_IOT_ACT_DISABLE_ALL_2SS)
- pCapELE->MCS[1] &= 0x00;
+ cap_ele->MCS[1] &= 0x00;
if (ht->iot_action & HT_IOT_ACT_DISABLE_RX_40MHZ_SHORT_GI)
- pCapELE->ShortGI40Mhz = 0;
+ cap_ele->ShortGI40Mhz = 0;
if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev)) {
- pCapELE->ChlWidth = 0;
- pCapELE->MCS[1] = 0;
+ cap_ele->ChlWidth = 0;
+ cap_ele->MCS[1] = 0;
}
}
}
--
2.41.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2 3/4] staging: rtl8192e: rename variable HTGetHighestMCSRate
2023-12-16 1:01 [PATCH v2 0/4] [Series 4] staging: rtl8192e: rename variable pHT and (3) other Gary Rookard
2023-12-16 1:01 ` [PATCH v2 1/4] staging: rtl8192e: rename variable pHT Gary Rookard
2023-12-16 1:01 ` [PATCH v2 2/4] staging: rtl8192e: rename variable pCapELE Gary Rookard
@ 2023-12-16 1:01 ` Gary Rookard
2023-12-16 1:01 ` [PATCH v2 4/4] staging: rtl8192e: renamed variable HTFilterMCSRate Gary Rookard
2023-12-16 7:27 ` [PATCH v2 0/4] [Series 4] staging: rtl8192e: rename variable pHT and (3) other Greg KH
4 siblings, 0 replies; 8+ messages in thread
From: Gary Rookard @ 2023-12-16 1:01 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann; +Cc: linux-staging, linux-kernel, Gary Rookard
Coding style issue, checkpatch Avoid CamelCase,
rename it. HTGetHighestMCSRate -> ht_get_highest_mcs_rate
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
v2: Corrections to make applicable.
v1: Not applicable, conflicting line numbers, code changed.
drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++--
drivers/staging/rtl8192e/rtllib.h | 2 +-
drivers/staging/rtl8192e/rtllib_wx.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 8d9037130424..6c1af19d67d2 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -357,7 +357,7 @@ static u8 ht_pick_mcs_rate(struct rtllib_device *ieee, u8 *pOperateMCS)
return true;
}
-u8 HTGetHighestMCSRate(struct rtllib_device *ieee, u8 *pMCSRateSet,
+u8 ht_get_highest_mcs_rate(struct rtllib_device *ieee, u8 *pMCSRateSet,
u8 *pMCSFilter)
{
u8 i, j;
@@ -493,7 +493,7 @@ void ht_on_assoc_rsp(struct rtllib_device *ieee)
HTFilterMCSRate(ieee, pPeerHTCap->MCS, ieee->dot11ht_oper_rate_set);
pMcsFilter = MCS_FILTER_ALL;
- ieee->HTHighestOperaRate = HTGetHighestMCSRate(ieee,
+ ieee->HTHighestOperaRate = ht_get_highest_mcs_rate(ieee,
ieee->dot11ht_oper_rate_set,
pMcsFilter);
ieee->HTCurrentOperaRate = ieee->HTHighestOperaRate;
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index b4413cfcb17e..966a62cfcfde 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1763,7 +1763,7 @@ void HTResetSelfAndSavePeerSetting(struct rtllib_device *ieee,
struct rtllib_network *pNetwork);
void HT_update_self_and_peer_setting(struct rtllib_device *ieee,
struct rtllib_network *pNetwork);
-u8 HTGetHighestMCSRate(struct rtllib_device *ieee, u8 *pMCSRateSet,
+u8 ht_get_highest_mcs_rate(struct rtllib_device *ieee, u8 *pMCSRateSet,
u8 *pMCSFilter);
extern u8 MCS_FILTER_ALL[];
extern u16 MCS_DATA_RATE[2][2][77];
diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c
index a37250de7ba3..f92ec0faf4d5 100644
--- a/drivers/staging/rtl8192e/rtllib_wx.c
+++ b/drivers/staging/rtl8192e/rtllib_wx.c
@@ -134,7 +134,7 @@ static inline char *rtl819x_translate_scan(struct rtllib_device *ieee,
((ht_cap->ShortGI40Mhz) ? 1 : 0) :
((ht_cap->ShortGI20Mhz) ? 1 : 0);
- max_mcs = HTGetHighestMCSRate(ieee, ht_cap->MCS,
+ max_mcs = ht_get_highest_mcs_rate(ieee, ht_cap->MCS,
MCS_FILTER_ALL);
rate = MCS_DATA_RATE[is40M][isShortGI][max_mcs & 0x7f];
if (rate > max_rate)
--
2.41.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2 4/4] staging: rtl8192e: renamed variable HTFilterMCSRate
2023-12-16 1:01 [PATCH v2 0/4] [Series 4] staging: rtl8192e: rename variable pHT and (3) other Gary Rookard
` (2 preceding siblings ...)
2023-12-16 1:01 ` [PATCH v2 3/4] staging: rtl8192e: rename variable HTGetHighestMCSRate Gary Rookard
@ 2023-12-16 1:01 ` Gary Rookard
2023-12-16 7:27 ` [PATCH v2 0/4] [Series 4] staging: rtl8192e: rename variable pHT and (3) other Greg KH
4 siblings, 0 replies; 8+ messages in thread
From: Gary Rookard @ 2023-12-16 1:01 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann; +Cc: linux-staging, linux-kernel, Gary Rookard
Coding style issue, checkpatch Avoid CamelCase,
rename it. HTFilterMCSRate -> ht_filter_mcs_rate
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
v2: Corrections to make applicable.
v1: Not applicable, conflicting line numbers, code changed.
drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 6c1af19d67d2..0d57bcda33b4 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -397,7 +397,7 @@ u8 ht_get_highest_mcs_rate(struct rtllib_device *ieee, u8 *pMCSRateSet,
return mcsRate | 0x80;
}
-static u8 HTFilterMCSRate(struct rtllib_device *ieee, u8 *pSupportMCS,
+static u8 ht_filter_mcs_rate(struct rtllib_device *ieee, u8 *pSupportMCS,
u8 *pOperateMCS)
{
u8 i;
@@ -490,7 +490,7 @@ void ht_on_assoc_rsp(struct rtllib_device *ieee)
ht_iot_act_determine_ra_func(ieee, ((pPeerHTCap->MCS[1]) != 0));
- HTFilterMCSRate(ieee, pPeerHTCap->MCS, ieee->dot11ht_oper_rate_set);
+ ht_filter_mcs_rate(ieee, pPeerHTCap->MCS, ieee->dot11ht_oper_rate_set);
pMcsFilter = MCS_FILTER_ALL;
ieee->HTHighestOperaRate = ht_get_highest_mcs_rate(ieee,
--
2.41.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2 0/4] [Series 4] staging: rtl8192e: rename variable pHT and (3) other
2023-12-16 1:01 [PATCH v2 0/4] [Series 4] staging: rtl8192e: rename variable pHT and (3) other Gary Rookard
` (3 preceding siblings ...)
2023-12-16 1:01 ` [PATCH v2 4/4] staging: rtl8192e: renamed variable HTFilterMCSRate Gary Rookard
@ 2023-12-16 7:27 ` Greg KH
2023-12-16 13:09 ` Gary Rookard
4 siblings, 1 reply; 8+ messages in thread
From: Greg KH @ 2023-12-16 7:27 UTC (permalink / raw)
To: Gary Rookard; +Cc: philipp.g.hortmann, linux-staging, linux-kernel
On Fri, Dec 15, 2023 at 08:01:01PM -0500, Gary Rookard wrote:
> Hi,
>
> This patch series renames (4) different variables with
> the checkpatch coding style issue, Avoid CamelCase.
>
> (resubmittals)
I see two different copies of this patch set, please send only one as
now I don't know which one is "real".
Please fix up and send a v3, I've dropped both from my queue.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2 0/4] [Series 4] staging: rtl8192e: rename variable pHT and (3) other
2023-12-16 7:27 ` [PATCH v2 0/4] [Series 4] staging: rtl8192e: rename variable pHT and (3) other Greg KH
@ 2023-12-16 13:09 ` Gary Rookard
0 siblings, 0 replies; 8+ messages in thread
From: Gary Rookard @ 2023-12-16 13:09 UTC (permalink / raw)
To: Greg KH; +Cc: philipp.g.hortmann, linux-staging, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 654 bytes --]
Greg KH <gregkh@linuxfoundation.org> writes:
> On Fri, Dec 15, 2023 at 08:01:01PM -0500, Gary Rookard wrote:
>> Hi,
>>
>> This patch series renames (4) different variables with
>> the checkpatch coding style issue, Avoid CamelCase.
>>
>> (resubmittals)
>
> I see two different copies of this patch set, please send only one as
> now I don't know which one is "real".
>
> Please fix up and send a v3, I've dropped both from my queue.
>
> thanks,
>
> greg k-h
--
Sorry for that, I've resent a v3 however 2 got stuck
together resulting in an extra cover letter...
Regards,
Gary
--
Sent with my mu4e on Gentoo GNU/linux.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 869 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread