From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ryan England <rcengland@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: rtl8712: fix open parentheses alignment
Date: Mon, 18 Dec 2023 16:30:01 +0100 [thread overview]
Message-ID: <2023121809-viewer-depict-f23f@gregkh> (raw)
In-Reply-To: <ZX3oDRuQ1OvZwCe3@kernel.ryanengland.xyz>
On Sat, Dec 16, 2023 at 06:10:21PM +0000, Ryan England wrote:
> @@ -639,16 +640,16 @@ int r8712_xmitframe_complete(struct _adapter *padapter,
> if (p2ndxmitframe) {
> u16 total_length;
>
> - total_length = r8712_xmitframe_aggr_next(
> - pxmitbuf, p2ndxmitframe);
> + total_length = r8712_xmitframe_aggr_next(pxmitbuf,
> + p2ndxmitframe);
You have 100 characters now, why not put this all on one line?
> do {
> - p2ndxmitframe = dequeue_xframe_ex(
> - pxmitpriv, phwxmits, hwentry);
> + p2ndxmitframe = dequeue_xframe_ex(pxmitpriv,
> + phwxmits,
> + hwentry);
Same with this? And others in this patch, try to neaten stuff up when
you make this type of change.
thanks,
greg k-h
prev parent reply other threads:[~2023-12-18 15:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-16 18:10 [PATCH] staging: rtl8712: fix open parentheses alignment Ryan England
2023-12-18 15:30 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023121809-viewer-depict-f23f@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=florian.c.schilhabel@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=rcengland@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox