From: Hans de Goede <hdegoede@redhat.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>, Kate Hsuan <hpa@redhat.com>,
Tsuchiya Yuto <kitakar@gmail.com>,
Yury Luneff <yury.lunev@gmail.com>,
Nable <nable.maininbox@googlemail.com>,
andrey.i.trufanov@gmail.com, Fabio Aiuto <fabioaiuto83@gmail.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev
Subject: [PATCH 00/15] media: atomisp: NULL pointer deref + missing firmware fixes
Date: Sun, 31 Dec 2023 11:30:42 +0100 [thread overview]
Message-ID: <20231231103057.35837-1-hdegoede@redhat.com> (raw)
Hi All,
Here is a set of atomisp fixes I have been working on:
- The first commit in this series fixes the driver no longer
working due to v4l2_subdev_state handling in media_stage/master
- Gracefully handle missing firmware:
- Fix the driver crashing the system when the firmware is missing
- Make the driver bind in power-managent-only mode when the firmware
is missing so that the ISP is still properly turned off. This
requires custom handling, not just standard PCI power-management.
This allows the system to properly enter S0i3 with missing ISP
firmware, allowing the atomisp driver to be used as a replacement
for the pm-only drivers/platform/x86/atomisp/pm.c driver.
I am going to send out a pull-request to Mauro for this almost directly
after sending these patches to the list, leaving pretty much zero time
for review. Sorry about that, with the holidays the timing did not work
out very well.
If review finds any significant issues I'll do a set of follow up
patches to fix those.
Regards,
Hans
Hans de Goede (15):
media: atomisp: Adjust for v4l2_subdev_state handling changes in 6.8
media: atomisp: Refactor sensor crop + fmt setting
media: atomisp: Remove s_routing subdev call
media: atomisp: Remove remaining deferred firmware loading code
media: atomisp: Drop is_valid_device() function
media: atomisp: Call pcim_enable_device() and pcim_iomap_regions()
later
media: atomisp: Fix probe error-exit path
media: atomisp: Fix atomisp_pci_remove()
media: atomisp: Group cpu_latency_qos_add_request() call together with
other PM calls
media: atomisp: Fix probe()/remove() power-management
media: atomisp: Replace atomisp_drvfs attr with using
driver.dev_groups attr
media: atomisp: Move power-management [un]init into
atomisp_pm_[un]init()
media: atomisp: Bind and do power-management without firmware
media: atomisp: Remove unnecessary msleep(10) from
atomisp_mrfld_power() error path
media: atomisp: Update TODO
drivers/staging/media/atomisp/TODO | 10 -
.../staging/media/atomisp/pci/atomisp_cmd.c | 133 ++++----
.../media/atomisp/pci/atomisp_compat_css20.c | 2 +-
.../staging/media/atomisp/pci/atomisp_drvfs.c | 148 +++-----
.../staging/media/atomisp/pci/atomisp_drvfs.h | 5 +-
.../media/atomisp/pci/atomisp_internal.h | 5 +-
.../staging/media/atomisp/pci/atomisp_ioctl.c | 60 ++--
.../staging/media/atomisp/pci/atomisp_v4l2.c | 319 ++++++++----------
.../media/atomisp/pci/ia_css_control.h | 29 +-
.../media/atomisp/pci/ia_css_firmware.h | 6 +-
drivers/staging/media/atomisp/pci/sh_css.c | 33 +-
11 files changed, 309 insertions(+), 441 deletions(-)
--
2.43.0
next reply other threads:[~2023-12-31 10:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-31 10:30 Hans de Goede [this message]
2023-12-31 10:30 ` [PATCH 01/15] media: atomisp: Adjust for v4l2_subdev_state handling changes in 6.8 Hans de Goede
2024-01-02 0:14 ` Andy Shevchenko
2023-12-31 10:30 ` [PATCH 02/15] media: atomisp: Refactor sensor crop + fmt setting Hans de Goede
2024-01-02 0:17 ` Andy Shevchenko
2023-12-31 10:30 ` [PATCH 03/15] media: atomisp: Remove s_routing subdev call Hans de Goede
2023-12-31 10:30 ` [PATCH 04/15] media: atomisp: Remove remaining deferred firmware loading code Hans de Goede
2023-12-31 10:30 ` [PATCH 05/15] media: atomisp: Drop is_valid_device() function Hans de Goede
2024-01-02 0:19 ` Andy Shevchenko
2024-02-19 13:25 ` Hans de Goede
2023-12-31 10:30 ` [PATCH 06/15] media: atomisp: Call pcim_enable_device() and pcim_iomap_regions() later Hans de Goede
2024-01-02 0:22 ` Andy Shevchenko
2023-12-31 10:30 ` [PATCH 07/15] media: atomisp: Fix probe error-exit path Hans de Goede
2024-01-02 0:24 ` Andy Shevchenko
2023-12-31 10:30 ` [PATCH 08/15] media: atomisp: Fix atomisp_pci_remove() Hans de Goede
2024-01-02 0:26 ` Andy Shevchenko
2023-12-31 10:30 ` [PATCH 09/15] media: atomisp: Group cpu_latency_qos_add_request() call together with other PM calls Hans de Goede
2023-12-31 10:30 ` [PATCH 10/15] media: atomisp: Fix probe()/remove() power-management Hans de Goede
2024-01-02 0:29 ` Andy Shevchenko
2023-12-31 10:30 ` [PATCH 11/15] media: atomisp: Replace atomisp_drvfs attr with using driver.dev_groups attr Hans de Goede
2024-01-02 0:33 ` Andy Shevchenko
2024-01-02 11:30 ` Hans de Goede
2024-01-02 21:23 ` Andy Shevchenko
2024-01-17 15:03 ` Hans de Goede
2023-12-31 10:30 ` [PATCH 12/15] media: atomisp: Move power-management [un]init into atomisp_pm_[un]init() Hans de Goede
2023-12-31 10:30 ` [PATCH 13/15] media: atomisp: Bind and do power-management without firmware Hans de Goede
2023-12-31 10:30 ` [PATCH 14/15] media: atomisp: Remove unnecessary msleep(10) from atomisp_mrfld_power() error path Hans de Goede
2023-12-31 10:30 ` [PATCH 15/15] media: atomisp: Update TODO Hans de Goede
2024-01-02 0:40 ` [PATCH 00/15] media: atomisp: NULL pointer deref + missing firmware fixes Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231231103057.35837-1-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=andrey.i.trufanov@gmail.com \
--cc=andy@kernel.org \
--cc=fabioaiuto83@gmail.com \
--cc=hpa@redhat.com \
--cc=kitakar@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=nable.maininbox@googlemail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=yury.lunev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox