From: Gary Rookard <garyrookard@fastmail.org>
To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Gary Rookard <garyrookard@fastmail.org>
Subject: [PATCH 2/5] staging: rtl8192e: rename variable isShortGI
Date: Sun, 7 Jan 2024 22:22:30 -0500 [thread overview]
Message-ID: <20240108032233.4280-3-garyrookard@fastmail.org> (raw)
In-Reply-To: <20240108032233.4280-1-garyrookard@fastmail.org>
Coding style issue, checkpatch Avoid CamelCase,
rename it. isShortGI -> is_short_gi
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 1b1cb9514028..43249b9cda44 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -88,10 +88,10 @@ static u16 ht_mcs_to_data_rate(struct rtllib_device *ieee, u8 mcs_rate)
struct rt_hi_throughput *ht_info = ieee->ht_info;
u8 is_40mhz = (ht_info->cur_bw_40mhz) ? 1 : 0;
- u8 isShortGI = (ht_info->cur_bw_40mhz) ?
+ u8 is_short_gi = (ht_info->cur_bw_40mhz) ?
((ht_info->cur_short_gi_40mhz) ? 1 : 0) :
((ht_info->cur_short_gi_20mhz) ? 1 : 0);
- return MCS_DATA_RATE[is_40mhz][isShortGI][(mcs_rate & 0x7f)];
+ return MCS_DATA_RATE[is_40mhz][is_short_gi][(mcs_rate & 0x7f)];
}
u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 data_rate)
@@ -99,24 +99,24 @@ u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 data_rate)
u16 cck_of_dm_rate[12] = {0x02, 0x04, 0x0b, 0x16, 0x0c, 0x12, 0x18,
0x24, 0x30, 0x48, 0x60, 0x6c};
u8 is_40mhz = 0;
- u8 isShortGI = 0;
+ u8 is_short_gi = 0;
if (data_rate < 12)
return cck_of_dm_rate[data_rate];
if (data_rate >= 0x10 && data_rate <= 0x1f) {
is_40mhz = 0;
- isShortGI = 0;
+ is_short_gi = 0;
} else if (data_rate >= 0x20 && data_rate <= 0x2f) {
is_40mhz = 1;
- isShortGI = 0;
+ is_short_gi = 0;
} else if (data_rate >= 0x30 && data_rate <= 0x3f) {
is_40mhz = 0;
- isShortGI = 1;
+ is_short_gi = 1;
} else if (data_rate >= 0x40 && data_rate <= 0x4f) {
is_40mhz = 1;
- isShortGI = 1;
+ is_short_gi = 1;
}
- return MCS_DATA_RATE[is_40mhz][isShortGI][data_rate & 0xf];
+ return MCS_DATA_RATE[is_40mhz][is_short_gi][data_rate & 0xf];
}
bool is_ht_half_nmode_aps(struct rtllib_device *ieee)
--
2.43.0
next prev parent reply other threads:[~2024-01-08 3:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 3:22 [PATCH 0/5] staging: rtl8192e: renamed variable is40MHz and 4 other Gary Rookard
2024-01-08 3:22 ` [PATCH 1/5] staging: rtl8192e: rename variable is40MHz Gary Rookard
2024-01-08 7:58 ` Dan Carpenter
2024-01-08 13:22 ` Gary Rookard
[not found] ` <62836460ae502097ca8307bcee85a5ae3634e1acc74af843ffc466c28d1a0b95@mu.id>
2024-01-09 1:25 ` Gary Rookard
2024-01-09 7:43 ` Dan Carpenter
2024-01-08 3:22 ` Gary Rookard [this message]
2024-01-08 3:22 ` [PATCH 3/5] staging: rtl8192e: rename variable retValue Gary Rookard
2024-01-08 3:22 ` [PATCH 4/5] staging: rtl8192e: rename variable EWC11NHTCap Gary Rookard
2024-01-08 3:22 ` [PATCH 5/5] staging: rtl8192e: rename variable AdvCoding Gary Rookard
2024-01-08 4:46 ` [PATCH 0/5] staging: rtl8192e: renamed variable is40MHz and 4 other Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240108032233.4280-3-garyrookard@fastmail.org \
--to=garyrookard@fastmail.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox