* [PATCH] staging: vt6655: fixed check alignment of open parenthesis in card.c
@ 2024-01-08 6:02 Matthias Yee
2024-01-08 6:39 ` Greg KH
0 siblings, 1 reply; 8+ messages in thread
From: Matthias Yee @ 2024-01-08 6:02 UTC (permalink / raw)
To: gregkh, linux-staging, linux-kernel; +Cc: Matthias Yee
Fixed a coding style issue.
Signed-off-by: Matthias Yee <mgyee9@gmail.com>
---
drivers/staging/vt6655/card.c | 74 +++++++++++++++++------------------
1 file changed, 37 insertions(+), 37 deletions(-)
diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 36183f2a64c1..688c870d89bc 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -81,9 +81,9 @@ static void vt6655_mac_set_bb_type(void __iomem *iobase, u32 mask)
* Return Value: none
*/
static void calculate_ofdmr_parameter(unsigned char rate,
- u8 bb_type,
- unsigned char *tx_rate,
- unsigned char *rsv_time)
+ u8 bb_type,
+ unsigned char *tx_rate,
+ unsigned char *rsv_time)
{
switch (rate) {
case RATE_6M:
@@ -288,7 +288,7 @@ bool card_set_phy_parameter(struct vnt_private *priv, u8 bb_type)
* Return Value: none
*/
bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
- u64 bss_timestamp)
+ u64 bss_timestamp)
{
u64 local_tsf;
u64 tsf_offset = 0;
@@ -297,7 +297,7 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
if (bss_timestamp != local_tsf) {
tsf_offset = card_get_tsf_offset(rx_rate, bss_timestamp,
- local_tsf);
+ local_tsf);
/* adjust TSF, HW's TSF add TSF Offset reg */
tsf_offset = le64_to_cpu(tsf_offset);
iowrite32((u32)tsf_offset, priv->port_offset + MAC_REG_TSFOFST);
@@ -321,7 +321,7 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
* Return Value: true if succeed; otherwise false
*/
bool card_set_beacon_period(struct vnt_private *priv,
- unsigned short beacon_interval)
+ unsigned short beacon_interval)
{
u64 next_tbtt;
@@ -586,61 +586,61 @@ void card_set_rspinf(struct vnt_private *priv, u8 bb_type)
/* RSPINF_a_6 */
calculate_ofdmr_parameter(RATE_6M,
- bb_type,
- &byTxRate,
- &byRsvTime);
+ bb_type,
+ &byTxRate,
+ &byRsvTime);
iowrite16(MAKEWORD(byTxRate, byRsvTime), priv->port_offset + MAC_REG_RSPINF_A_6);
/* RSPINF_a_9 */
calculate_ofdmr_parameter(RATE_9M,
- bb_type,
- &byTxRate,
- &byRsvTime);
+ bb_type,
+ &byTxRate,
+ &byRsvTime);
iowrite16(MAKEWORD(byTxRate, byRsvTime), priv->port_offset + MAC_REG_RSPINF_A_9);
/* RSPINF_a_12 */
calculate_ofdmr_parameter(RATE_12M,
- bb_type,
- &byTxRate,
- &byRsvTime);
+ bb_type,
+ &byTxRate,
+ &byRsvTime);
iowrite16(MAKEWORD(byTxRate, byRsvTime), priv->port_offset + MAC_REG_RSPINF_A_12);
/* RSPINF_a_18 */
calculate_ofdmr_parameter(RATE_18M,
- bb_type,
- &byTxRate,
- &byRsvTime);
+ bb_type,
+ &byTxRate,
+ &byRsvTime);
iowrite16(MAKEWORD(byTxRate, byRsvTime), priv->port_offset + MAC_REG_RSPINF_A_18);
/* RSPINF_a_24 */
calculate_ofdmr_parameter(RATE_24M,
- bb_type,
- &byTxRate,
- &byRsvTime);
+ bb_type,
+ &byTxRate,
+ &byRsvTime);
iowrite16(MAKEWORD(byTxRate, byRsvTime), priv->port_offset + MAC_REG_RSPINF_A_24);
/* RSPINF_a_36 */
calculate_ofdmr_parameter(CARDwGetOFDMControlRate((void *)priv,
- RATE_36M),
- bb_type,
- &byTxRate,
- &byRsvTime);
+ RATE_36M),
+ bb_type,
+ &byTxRate,
+ &byRsvTime);
iowrite16(MAKEWORD(byTxRate, byRsvTime), priv->port_offset + MAC_REG_RSPINF_A_36);
/* RSPINF_a_48 */
calculate_ofdmr_parameter(CARDwGetOFDMControlRate((void *)priv,
- RATE_48M),
- bb_type,
- &byTxRate,
- &byRsvTime);
+ RATE_48M),
+ bb_type,
+ &byTxRate,
+ &byRsvTime);
iowrite16(MAKEWORD(byTxRate, byRsvTime), priv->port_offset + MAC_REG_RSPINF_A_48);
/* RSPINF_a_54 */
calculate_ofdmr_parameter(CARDwGetOFDMControlRate((void *)priv,
- RATE_54M),
- bb_type,
- &byTxRate,
- &byRsvTime);
+ RATE_54M),
+ bb_type,
+ &byTxRate,
+ &byRsvTime);
iowrite16(MAKEWORD(byTxRate, byRsvTime), priv->port_offset + MAC_REG_RSPINF_A_54);
/* RSPINF_a_72 */
calculate_ofdmr_parameter(CARDwGetOFDMControlRate((void *)priv,
- RATE_54M),
- bb_type,
- &byTxRate,
- &byRsvTime);
+ RATE_54M),
+ bb_type,
+ &byTxRate,
+ &byRsvTime);
iowrite16(MAKEWORD(byTxRate, byRsvTime), priv->port_offset + MAC_REG_RSPINF_A_72);
/* Set to Page0 */
VT6655_MAC_SELECT_PAGE0(priv->port_offset);
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: vt6655: fixed check alignment of open parenthesis in card.c
2024-01-08 6:02 Matthias Yee
@ 2024-01-08 6:39 ` Greg KH
0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2024-01-08 6:39 UTC (permalink / raw)
To: Matthias Yee; +Cc: linux-staging, linux-kernel
On Sun, Jan 07, 2024 at 10:02:07PM -0800, Matthias Yee wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Matthias Yee <mgyee9@gmail.com>
> ---
> drivers/staging/vt6655/card.c | 74 +++++++++++++++++------------------
> 1 file changed, 37 insertions(+), 37 deletions(-)
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- You did not specify a description of why the patch is needed, or
possibly, any description at all, in the email body. Please read the
section entitled "The canonical patch format" in the kernel file,
Documentation/process/submitting-patches.rst for what is needed in
order to properly describe the change.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] staging: vt6655: fixed check alignment of open parenthesis in card.c
@ 2024-01-09 6:36 Matthias Yee
2024-01-09 8:22 ` Dan Carpenter
2024-01-14 12:23 ` Greg KH
0 siblings, 2 replies; 8+ messages in thread
From: Matthias Yee @ 2024-01-09 6:36 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Matthias Yee
This patch adjusts whitespace to fix the checkpatch warning Alignment Should Match Open Parenthesis.
Signed-off-by: Matthias Yee <mgyee9@gmail.com>
---
drivers/staging/vt6655/card.c | 74 +++++++++++++++++------------------
1 file changed, 37 insertions(+), 37 deletions(-)
diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 36183f2a64c1..688c870d89bc 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -81,9 +81,9 @@ static void vt6655_mac_set_bb_type(void __iomem *iobase, u32 mask)
* Return Value: none
*/
static void calculate_ofdmr_parameter(unsigned char rate,
- u8 bb_type,
- unsigned char *tx_rate,
- unsigned char *rsv_time)
+ u8 bb_type,
+ unsigned char *tx_rate,
+ unsigned char *rsv_time)
{
switch (rate) {
case RATE_6M:
@@ -288,7 +288,7 @@ bool card_set_phy_parameter(struct vnt_private *priv, u8 bb_type)
* Return Value: none
*/
bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
- u64 bss_timestamp)
+ u64 bss_timestamp)
{
u64 local_tsf;
u64 tsf_offset = 0;
@@ -297,7 +297,7 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
if (bss_timestamp != local_tsf) {
tsf_offset = card_get_tsf_offset(rx_rate, bss_timestamp,
- local_tsf);
+ local_tsf);
/* adjust TSF, HW's TSF add TSF Offset reg */
tsf_offset = le64_to_cpu(tsf_offset);
iowrite32((u32)tsf_offset, priv->port_offset + MAC_REG_TSFOFST);
@@ -321,7 +321,7 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
* Return Value: true if succeed; otherwise false
*/
bool card_set_beacon_period(struct vnt_private *priv,
- unsigned short beacon_interval)
+ unsigned short beacon_interval)
{
u64 next_tbtt;
@@ -586,61 +586,61 @@ void card_set_rspinf(struct vnt_private *priv, u8 bb_type)
/* RSPINF_a_6 */
calculate_ofdmr_parameter(RATE_6M,
- bb_type,
- &byTxRate,
- &byRsvTime);
+ bb_type,
+ &byTxRate,
+ &byRsvTime);
iowrite16(MAKEWORD(byTxRate, byRsvTime), priv->port_offset + MAC_REG_RSPINF_A_6);
/* RSPINF_a_9 */
calculate_ofdmr_parameter(RATE_9M,
- bb_type,
- &byTxRate,
- &byRsvTime);
+ bb_type,
+ &byTxRate,
+ &byRsvTime);
iowrite16(MAKEWORD(byTxRate, byRsvTime), priv->port_offset + MAC_REG_RSPINF_A_9);
/* RSPINF_a_12 */
calculate_ofdmr_parameter(RATE_12M,
- bb_type,
- &byTxRate,
- &byRsvTime);
+ bb_type,
+ &byTxRate,
+ &byRsvTime);
iowrite16(MAKEWORD(byTxRate, byRsvTime), priv->port_offset + MAC_REG_RSPINF_A_12);
/* RSPINF_a_18 */
calculate_ofdmr_parameter(RATE_18M,
- bb_type,
- &byTxRate,
- &byRsvTime);
+ bb_type,
+ &byTxRate,
+ &byRsvTime);
iowrite16(MAKEWORD(byTxRate, byRsvTime), priv->port_offset + MAC_REG_RSPINF_A_18);
/* RSPINF_a_24 */
calculate_ofdmr_parameter(RATE_24M,
- bb_type,
- &byTxRate,
- &byRsvTime);
+ bb_type,
+ &byTxRate,
+ &byRsvTime);
iowrite16(MAKEWORD(byTxRate, byRsvTime), priv->port_offset + MAC_REG_RSPINF_A_24);
/* RSPINF_a_36 */
calculate_ofdmr_parameter(CARDwGetOFDMControlRate((void *)priv,
- RATE_36M),
- bb_type,
- &byTxRate,
- &byRsvTime);
+ RATE_36M),
+ bb_type,
+ &byTxRate,
+ &byRsvTime);
iowrite16(MAKEWORD(byTxRate, byRsvTime), priv->port_offset + MAC_REG_RSPINF_A_36);
/* RSPINF_a_48 */
calculate_ofdmr_parameter(CARDwGetOFDMControlRate((void *)priv,
- RATE_48M),
- bb_type,
- &byTxRate,
- &byRsvTime);
+ RATE_48M),
+ bb_type,
+ &byTxRate,
+ &byRsvTime);
iowrite16(MAKEWORD(byTxRate, byRsvTime), priv->port_offset + MAC_REG_RSPINF_A_48);
/* RSPINF_a_54 */
calculate_ofdmr_parameter(CARDwGetOFDMControlRate((void *)priv,
- RATE_54M),
- bb_type,
- &byTxRate,
- &byRsvTime);
+ RATE_54M),
+ bb_type,
+ &byTxRate,
+ &byRsvTime);
iowrite16(MAKEWORD(byTxRate, byRsvTime), priv->port_offset + MAC_REG_RSPINF_A_54);
/* RSPINF_a_72 */
calculate_ofdmr_parameter(CARDwGetOFDMControlRate((void *)priv,
- RATE_54M),
- bb_type,
- &byTxRate,
- &byRsvTime);
+ RATE_54M),
+ bb_type,
+ &byTxRate,
+ &byRsvTime);
iowrite16(MAKEWORD(byTxRate, byRsvTime), priv->port_offset + MAC_REG_RSPINF_A_72);
/* Set to Page0 */
VT6655_MAC_SELECT_PAGE0(priv->port_offset);
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: vt6655: fixed check alignment of open parenthesis in card.c
2024-01-09 6:36 [PATCH] staging: vt6655: fixed check alignment of open parenthesis in card.c Matthias Yee
@ 2024-01-09 8:22 ` Dan Carpenter
2024-01-09 18:56 ` Matthias Yee
2024-01-14 12:23 ` Greg KH
1 sibling, 1 reply; 8+ messages in thread
From: Dan Carpenter @ 2024-01-09 8:22 UTC (permalink / raw)
To: Matthias Yee; +Cc: gregkh, linux-staging, linux-kernel
On Mon, Jan 08, 2024 at 10:36:19PM -0800, Matthias Yee wrote:
> This patch adjusts whitespace to fix the checkpatch warning Alignment Should Match Open Parenthesis.
>
Line wrap your commit message at 75 characters, and also run checkpatch.pl
on your patches. Otherwise it's okay by me.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: vt6655: fixed check alignment of open parenthesis in card.c
2024-01-09 8:22 ` Dan Carpenter
@ 2024-01-09 18:56 ` Matthias Yee
2024-01-09 19:10 ` Greg KH
0 siblings, 1 reply; 8+ messages in thread
From: Matthias Yee @ 2024-01-09 18:56 UTC (permalink / raw)
To: Dan Carpenter; +Cc: gregkh, linux-staging, linux-kernel
On Tue, Jan 09, 2024 at 11:22:42AM +0300, Dan Carpenter wrote:
> On Mon, Jan 08, 2024 at 10:36:19PM -0800, Matthias Yee wrote:
> > This patch adjusts whitespace to fix the checkpatch warning Alignment Should Match Open Parenthesis.
> >
>
> Line wrap your commit message at 75 characters, and also run checkpatch.pl
> on your patches. Otherwise it's okay by me.
>
Sounds good, will do. However, checkpatch.pl gives an avoid CamelCase
warning. Is it okay to ignore if I am only focusing on the parenthesis
alignment warning in this patch?
thanks,
matthias
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: vt6655: fixed check alignment of open parenthesis in card.c
2024-01-09 18:56 ` Matthias Yee
@ 2024-01-09 19:10 ` Greg KH
0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2024-01-09 19:10 UTC (permalink / raw)
To: Matthias Yee; +Cc: Dan Carpenter, linux-staging, linux-kernel
On Tue, Jan 09, 2024 at 10:56:51AM -0800, Matthias Yee wrote:
> On Tue, Jan 09, 2024 at 11:22:42AM +0300, Dan Carpenter wrote:
> > On Mon, Jan 08, 2024 at 10:36:19PM -0800, Matthias Yee wrote:
> > > This patch adjusts whitespace to fix the checkpatch warning Alignment Should Match Open Parenthesis.
> > >
> >
> > Line wrap your commit message at 75 characters, and also run checkpatch.pl
> > on your patches. Otherwise it's okay by me.
> >
>
> Sounds good, will do. However, checkpatch.pl gives an avoid CamelCase
> warning. Is it okay to ignore if I am only focusing on the parenthesis
> alignment warning in this patch?
Yes.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: vt6655: fixed check alignment of open parenthesis in card.c
2024-01-09 6:36 [PATCH] staging: vt6655: fixed check alignment of open parenthesis in card.c Matthias Yee
2024-01-09 8:22 ` Dan Carpenter
@ 2024-01-14 12:23 ` Greg KH
2024-01-14 12:39 ` Greg KH
1 sibling, 1 reply; 8+ messages in thread
From: Greg KH @ 2024-01-14 12:23 UTC (permalink / raw)
To: Matthias Yee; +Cc: linux-staging, linux-kernel
On Mon, Jan 08, 2024 at 10:36:19PM -0800, Matthias Yee wrote:
> This patch adjusts whitespace to fix the checkpatch warning Alignment Should Match Open Parenthesis.
Please wrap your changelog at 72 columns.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: vt6655: fixed check alignment of open parenthesis in card.c
2024-01-14 12:23 ` Greg KH
@ 2024-01-14 12:39 ` Greg KH
0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2024-01-14 12:39 UTC (permalink / raw)
To: Matthias Yee; +Cc: linux-staging, linux-kernel
On Sun, Jan 14, 2024 at 01:23:09PM +0100, Greg KH wrote:
> On Mon, Jan 08, 2024 at 10:36:19PM -0800, Matthias Yee wrote:
> > This patch adjusts whitespace to fix the checkpatch warning Alignment Should Match Open Parenthesis.
>
> Please wrap your changelog at 72 columns.
Oops, this was for an older version of the patch, ignore this, sorry.
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-01-14 12:39 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-09 6:36 [PATCH] staging: vt6655: fixed check alignment of open parenthesis in card.c Matthias Yee
2024-01-09 8:22 ` Dan Carpenter
2024-01-09 18:56 ` Matthias Yee
2024-01-09 19:10 ` Greg KH
2024-01-14 12:23 ` Greg KH
2024-01-14 12:39 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2024-01-08 6:02 Matthias Yee
2024-01-08 6:39 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox