* [PATCH] staging: vt6655: Remove extra blank lines between code blocks @ 2024-01-11 7:06 Pranav Athreya 2024-01-11 7:22 ` Greg Kroah-Hartman 0 siblings, 1 reply; 7+ messages in thread From: Pranav Athreya @ 2024-01-11 7:06 UTC (permalink / raw) To: Forest Bond, Greg Kroah-Hartman Cc: linux-staging, linux-kernel, Pranav Athreya Adhere to Linux kernel coding style. Reported by checkpatch: drivers/staging/vt6655/rxtx.h:22: CHECK: Please don't use multiple blank lines drivers/staging/vt6655/vt6655_stage.mod.c:38: CHECK: Please don't use multiple blank lines ^Ignore the blank lines in vt6655_stage.mod.c since *.mod.c files are included in .gitignore. Signed-off-by: Pranav Athreya <pranavsubbu@gmail.com> --- drivers/staging/vt6655/rxtx.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vt6655/rxtx.h b/drivers/staging/vt6655/rxtx.h index a67757c9bb5c..be1e5180d57b 100644 --- a/drivers/staging/vt6655/rxtx.h +++ b/drivers/staging/vt6655/rxtx.h @@ -19,7 +19,6 @@ #define DEFAULT_MSDU_LIFETIME_RES_64us 8000 /* 64us */ #define DEFAULT_MGN_LIFETIME_RES_64us 125 /* 64us */ - /*--------------------- Export Definitions -------------------------*/ /*--------------------- Export Variables --------------------------*/ -- 2.34.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: vt6655: Remove extra blank lines between code blocks 2024-01-11 7:06 [PATCH] staging: vt6655: Remove extra blank lines between code blocks Pranav Athreya @ 2024-01-11 7:22 ` Greg Kroah-Hartman [not found] ` <CAP1Lp88vEZJtd69Njf9uZ5VXypwZ-5vLdBHf2xoLSpqmeyEQiA@mail.gmail.com> 0 siblings, 1 reply; 7+ messages in thread From: Greg Kroah-Hartman @ 2024-01-11 7:22 UTC (permalink / raw) To: Pranav Athreya; +Cc: Forest Bond, linux-staging, linux-kernel On Thu, Jan 11, 2024 at 12:36:52PM +0530, Pranav Athreya wrote: > Adhere to Linux kernel coding style. > > Reported by checkpatch: > > drivers/staging/vt6655/rxtx.h:22: CHECK: Please don't use multiple blank lines > > drivers/staging/vt6655/vt6655_stage.mod.c:38: CHECK: Please don't use multiple blank lines > ^Ignore the blank lines in vt6655_stage.mod.c since *.mod.c files > are included in .gitignore. *.mod.c files are not something that you can change, and are not in your patch either: > Signed-off-by: Pranav Athreya <pranavsubbu@gmail.com> > --- > drivers/staging/vt6655/rxtx.h | 1 - > 1 file changed, 1 deletion(-) So the text is not correct :( thanks, greg k-h ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <CAP1Lp88vEZJtd69Njf9uZ5VXypwZ-5vLdBHf2xoLSpqmeyEQiA@mail.gmail.com>]
* Re: [PATCH] staging: vt6655: Remove extra blank lines between code blocks [not found] ` <CAP1Lp88vEZJtd69Njf9uZ5VXypwZ-5vLdBHf2xoLSpqmeyEQiA@mail.gmail.com> @ 2024-01-11 9:09 ` Pranav Athreya 2024-01-11 9:27 ` Greg Kroah-Hartman 0 siblings, 1 reply; 7+ messages in thread From: Pranav Athreya @ 2024-01-11 9:09 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: Forest Bond, linux-staging, linux-kernel My apologies, resending this as plain text. Greg, Thank you for reviewing my patch! Shall I amend the commit and send a revision of the patch? If I understand you correctly, I should remove all mention of the .mod.c file from the commit, which will leave the new text as such: Adhere to Linux kernel coding style. Reported by checkpatch: drivers/staging/vt6655/rxtx.h:22: CHECK: Please don't use multiple blank lines Signed-off-by: Pranav Athreya <pranavsubbu@gmail.com> --- drivers/staging/vt6655/rxtx.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vt6655/rxtx.h b/drivers/staging/vt6655/rxtx.h index a67757c9bb5c..be1e5180d57b 100644 --- a/drivers/staging/vt6655/rxtx.h +++ b/drivers/staging/vt6655/rxtx.h @@ -19,7 +19,6 @@ #define DEFAULT_MSDU_LIFETIME_RES_64us 8000 /* 64us */ #define DEFAULT_MGN_LIFETIME_RES_64us 125 /* 64us */ - /*--------------------- Export Definitions -------------------------*/ /*--------------------- Export Variables --------------------------*/ Yours Sincerely, Pranav. Yours Sincerely, Pranav. On Thu, Jan 11, 2024 at 2:33 PM Pranav Athreya <pranavsubbu@gmail.com> wrote: > > Greg, > > Thank you for reviewing my patch! Shall I amend the commit and send a revision of the patch? > If I understand you correctly, I should remove all mention of the .mod.c file from the commit, > which will leave the new text as such: > > Adhere to Linux kernel coding style. > > Reported by checkpatch: > > drivers/staging/vt6655/rxtx.h:22: CHECK: Please don't use multiple blank lines > > Signed-off-by: Pranav Athreya <pranavsubbu@gmail.com> > --- > drivers/staging/vt6655/rxtx.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/vt6655/rxtx.h b/drivers/staging/vt6655/rxtx.h > index a67757c9bb5c..be1e5180d57b 100644 > --- a/drivers/staging/vt6655/rxtx.h > +++ b/drivers/staging/vt6655/rxtx.h > @@ -19,7 +19,6 @@ > #define DEFAULT_MSDU_LIFETIME_RES_64us 8000 /* 64us */ > #define DEFAULT_MGN_LIFETIME_RES_64us 125 /* 64us */ > > - > /*--------------------- Export Definitions -------------------------*/ > > /*--------------------- Export Variables --------------------------*/ > > > Yours Sincerely, > > Pranav. > > > On Thu, Jan 11, 2024 at 12:52 PM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: >> >> On Thu, Jan 11, 2024 at 12:36:52PM +0530, Pranav Athreya wrote: >> > Adhere to Linux kernel coding style. >> > >> > Reported by checkpatch: >> > >> > drivers/staging/vt6655/rxtx.h:22: CHECK: Please don't use multiple blank lines >> > >> > drivers/staging/vt6655/vt6655_stage.mod.c:38: CHECK: Please don't use multiple blank lines >> > ^Ignore the blank lines in vt6655_stage.mod.c since *.mod.c files >> > are included in .gitignore. >> >> *.mod.c files are not something that you can change, and are not in your >> patch either: >> >> > Signed-off-by: Pranav Athreya <pranavsubbu@gmail.com> >> > --- >> > drivers/staging/vt6655/rxtx.h | 1 - >> > 1 file changed, 1 deletion(-) >> >> So the text is not correct :( >> >> thanks, >> >> greg k-h ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: vt6655: Remove extra blank lines between code blocks 2024-01-11 9:09 ` Pranav Athreya @ 2024-01-11 9:27 ` Greg Kroah-Hartman 2024-01-11 10:08 ` Pranav Athreya 0 siblings, 1 reply; 7+ messages in thread From: Greg Kroah-Hartman @ 2024-01-11 9:27 UTC (permalink / raw) To: Pranav Athreya; +Cc: Forest Bond, linux-staging, linux-kernel On Thu, Jan 11, 2024 at 02:39:54PM +0530, Pranav Athreya wrote: > My apologies, resending this as plain text. > > Greg, > > Thank you for reviewing my patch! Shall I amend the commit and send a > revision of the patch? Yes, please read the kernel documentation for how to submit a new version of a patch. thanks, greg k-h ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: vt6655: Remove extra blank lines between code blocks 2024-01-11 9:27 ` Greg Kroah-Hartman @ 2024-01-11 10:08 ` Pranav Athreya 2024-01-11 11:08 ` Dan Carpenter 0 siblings, 1 reply; 7+ messages in thread From: Pranav Athreya @ 2024-01-11 10:08 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: Forest Bond, linux-staging, linux-kernel On Thu, Jan 11, 2024 at 2:57 PM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > Yes, please read the kernel documentation for how to submit a new > version of a patch. Reading the docs now and will send the patch right after. My sincere apologies for the top posting. Yours Sincerely, Pranav. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: vt6655: Remove extra blank lines between code blocks 2024-01-11 10:08 ` Pranav Athreya @ 2024-01-11 11:08 ` Dan Carpenter 2024-01-11 11:24 ` Pranav Athreya 0 siblings, 1 reply; 7+ messages in thread From: Dan Carpenter @ 2024-01-11 11:08 UTC (permalink / raw) To: Pranav Athreya Cc: Greg Kroah-Hartman, Forest Bond, linux-staging, linux-kernel On Thu, Jan 11, 2024 at 03:38:16PM +0530, Pranav Athreya wrote: > On Thu, Jan 11, 2024 at 2:57 PM Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: > > Yes, please read the kernel documentation for how to submit a new > > version of a patch. > > Reading the docs now and will send the patch right after. My sincere > apologies for the top posting. I have a blog about how to send a v2 patch. (v3 patch now I guess). https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ regards, dan carpenter ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: vt6655: Remove extra blank lines between code blocks 2024-01-11 11:08 ` Dan Carpenter @ 2024-01-11 11:24 ` Pranav Athreya 0 siblings, 0 replies; 7+ messages in thread From: Pranav Athreya @ 2024-01-11 11:24 UTC (permalink / raw) To: Dan Carpenter Cc: Greg Kroah-Hartman, Forest Bond, linux-staging, linux-kernel On Thu, Jan 11, 2024 at 4:38 PM Dan Carpenter <dan.carpenter@linaro.org> wrote: > I have a blog about how to send a v2 patch. (v3 patch now I guess). > > https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ Thanks Dan, I will take a look at this! Also, why do you say it is a v3 patch now? Yours Sincerely, Pranav. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-01-11 11:24 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-11 7:06 [PATCH] staging: vt6655: Remove extra blank lines between code blocks Pranav Athreya
2024-01-11 7:22 ` Greg Kroah-Hartman
[not found] ` <CAP1Lp88vEZJtd69Njf9uZ5VXypwZ-5vLdBHf2xoLSpqmeyEQiA@mail.gmail.com>
2024-01-11 9:09 ` Pranav Athreya
2024-01-11 9:27 ` Greg Kroah-Hartman
2024-01-11 10:08 ` Pranav Athreya
2024-01-11 11:08 ` Dan Carpenter
2024-01-11 11:24 ` Pranav Athreya
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox