public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pranav Athreya <pranavsubbu@gmail.com>
Cc: Forest Bond <forest@alittletooquiet.net>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vt6655: Remove extra blank lines between code blocks
Date: Thu, 11 Jan 2024 08:22:27 +0100	[thread overview]
Message-ID: <2024011144-silica-viral-9e79@gregkh> (raw)
In-Reply-To: <20240111070652.71717-1-pranavsubbu@gmail.com>

On Thu, Jan 11, 2024 at 12:36:52PM +0530, Pranav Athreya wrote:
> Adhere to Linux kernel coding style.
> 
> Reported by checkpatch:
> 
> drivers/staging/vt6655/rxtx.h:22: CHECK: Please don't use multiple blank lines
> 
> drivers/staging/vt6655/vt6655_stage.mod.c:38: CHECK: Please don't use multiple blank lines
> ^Ignore the blank lines in vt6655_stage.mod.c since *.mod.c files
> are included in .gitignore.

*.mod.c files are not something that you can change, and are not in your
patch either:

> Signed-off-by: Pranav Athreya <pranavsubbu@gmail.com>
> ---
>  drivers/staging/vt6655/rxtx.h | 1 -
>  1 file changed, 1 deletion(-)

So the text is not correct :(

thanks,

greg k-h

  reply	other threads:[~2024-01-11  7:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-11  7:06 [PATCH] staging: vt6655: Remove extra blank lines between code blocks Pranav Athreya
2024-01-11  7:22 ` Greg Kroah-Hartman [this message]
     [not found]   ` <CAP1Lp88vEZJtd69Njf9uZ5VXypwZ-5vLdBHf2xoLSpqmeyEQiA@mail.gmail.com>
2024-01-11  9:09     ` Pranav Athreya
2024-01-11  9:27       ` Greg Kroah-Hartman
2024-01-11 10:08         ` Pranav Athreya
2024-01-11 11:08           ` Dan Carpenter
2024-01-11 11:24             ` Pranav Athreya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024011144-silica-viral-9e79@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=forest@alittletooquiet.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=pranavsubbu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox