[PATCH] staging: vt6655: Remove extra blank lines between code blocks

[PATCH] staging: vt6655: Remove extra blank lines between code blocks

[Pranav Athreya]

Adhere to Linux kernel coding style.

Reported by checkpatch:

drivers/staging/vt6655/rxtx.h:22: CHECK: Please don't use multiple blank lines

drivers/staging/vt6655/vt6655_stage.mod.c:38: CHECK: Please don't use multiple blank lines
^Ignore the blank lines in vt6655_stage.mod.c since *.mod.c files
are included in .gitignore.

Signed-off-by: Pranav Athreya <pranavsubbu@gmail.com>
---
 drivers/staging/vt6655/rxtx.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/vt6655/rxtx.h b/drivers/staging/vt6655/rxtx.h
index a67757c9bb5c..be1e5180d57b 100644
--- a/drivers/staging/vt6655/rxtx.h
+++ b/drivers/staging/vt6655/rxtx.h
@@ -19,7 +19,6 @@
 #define DEFAULT_MSDU_LIFETIME_RES_64us	8000 /* 64us */
 #define DEFAULT_MGN_LIFETIME_RES_64us	125  /* 64us */
 
-
 /*---------------------  Export Definitions -------------------------*/
 
 /*---------------------  Export Variables  --------------------------*/
-- 
2.34.1

Re: [PATCH] staging: vt6655: Remove extra blank lines between code blocks

[Greg Kroah-Hartman]

On Thu, Jan 11, 2024 at 12:36:52PM +0530, Pranav Athreya wrote:
> Adhere to Linux kernel coding style.
> 
> Reported by checkpatch:
> 
> drivers/staging/vt6655/rxtx.h:22: CHECK: Please don't use multiple blank lines
> 
> drivers/staging/vt6655/vt6655_stage.mod.c:38: CHECK: Please don't use multiple blank lines
> ^Ignore the blank lines in vt6655_stage.mod.c since *.mod.c files
> are included in .gitignore.

*.mod.c files are not something that you can change, and are not in your
patch either:

> Signed-off-by: Pranav Athreya <pranavsubbu@gmail.com>
> ---
>  drivers/staging/vt6655/rxtx.h | 1 -
>  1 file changed, 1 deletion(-)

So the text is not correct :(

thanks,

greg k-h

Re: [PATCH] staging: vt6655: Remove extra blank lines between code blocks

[Pranav Athreya]

My apologies, resending this as plain text.

Greg,

Thank you for reviewing my patch! Shall I amend the commit and send a
revision of the patch?
If I understand you correctly, I should remove all mention of the
.mod.c file from the commit,
which will leave the new text as such:

Adhere to Linux kernel coding style.

Reported by checkpatch:

drivers/staging/vt6655/rxtx.h:22: CHECK: Please don't use multiple blank lines

Signed-off-by: Pranav Athreya <pranavsubbu@gmail.com>
---
 drivers/staging/vt6655/rxtx.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/vt6655/rxtx.h b/drivers/staging/vt6655/rxtx.h
index a67757c9bb5c..be1e5180d57b 100644
--- a/drivers/staging/vt6655/rxtx.h
+++ b/drivers/staging/vt6655/rxtx.h
@@ -19,7 +19,6 @@
 #define DEFAULT_MSDU_LIFETIME_RES_64us 8000 /* 64us */
 #define DEFAULT_MGN_LIFETIME_RES_64us  125  /* 64us */

-
 /*---------------------  Export Definitions -------------------------*/

 /*---------------------  Export Variables  --------------------------*/

Yours Sincerely,

Pranav.

Yours Sincerely,

Pranav.


On Thu, Jan 11, 2024 at 2:33 PM Pranav Athreya <pranavsubbu@gmail.com> wrote:
>
> Greg,
>
> Thank you for reviewing my patch! Shall I amend the commit and send a revision of the patch?
> If I understand you correctly, I should remove all mention of the .mod.c file from the commit,
> which will leave the new text as such:
>
> Adhere to Linux kernel coding style.
>
> Reported by checkpatch:
>
> drivers/staging/vt6655/rxtx.h:22: CHECK: Please don't use multiple blank lines
>
> Signed-off-by: Pranav Athreya <pranavsubbu@gmail.com>
> ---
>  drivers/staging/vt6655/rxtx.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/rxtx.h b/drivers/staging/vt6655/rxtx.h
> index a67757c9bb5c..be1e5180d57b 100644
> --- a/drivers/staging/vt6655/rxtx.h
> +++ b/drivers/staging/vt6655/rxtx.h
> @@ -19,7 +19,6 @@
>  #define DEFAULT_MSDU_LIFETIME_RES_64us 8000 /* 64us */
>  #define DEFAULT_MGN_LIFETIME_RES_64us  125  /* 64us */
>
> -
>  /*---------------------  Export Definitions -------------------------*/
>
>  /*---------------------  Export Variables  --------------------------*/
>
>
> Yours Sincerely,
>
> Pranav.
>
>
> On Thu, Jan 11, 2024 at 12:52 PM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>>
>> On Thu, Jan 11, 2024 at 12:36:52PM +0530, Pranav Athreya wrote:
>> > Adhere to Linux kernel coding style.
>> >
>> > Reported by checkpatch:
>> >
>> > drivers/staging/vt6655/rxtx.h:22: CHECK: Please don't use multiple blank lines
>> >
>> > drivers/staging/vt6655/vt6655_stage.mod.c:38: CHECK: Please don't use multiple blank lines
>> > ^Ignore the blank lines in vt6655_stage.mod.c since *.mod.c files
>> > are included in .gitignore.
>>
>> *.mod.c files are not something that you can change, and are not in your
>> patch either:
>>
>> > Signed-off-by: Pranav Athreya <pranavsubbu@gmail.com>
>> > ---
>> >  drivers/staging/vt6655/rxtx.h | 1 -
>> >  1 file changed, 1 deletion(-)
>>
>> So the text is not correct :(
>>
>> thanks,
>>
>> greg k-h

Re: [PATCH] staging: vt6655: Remove extra blank lines between code blocks

[Greg Kroah-Hartman]

On Thu, Jan 11, 2024 at 02:39:54PM +0530, Pranav Athreya wrote:
> My apologies, resending this as plain text.
> 
> Greg,
> 
> Thank you for reviewing my patch! Shall I amend the commit and send a
> revision of the patch?

Yes, please read the kernel documentation for how to submit a new
version of a patch.

thanks,

greg k-h

Re: [PATCH] staging: vt6655: Remove extra blank lines between code blocks

[Pranav Athreya]

On Thu, Jan 11, 2024 at 2:57 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> Yes, please read the kernel documentation for how to submit a new
> version of a patch.

Reading the docs now and will send the patch right after. My sincere
apologies for the top posting.

Yours Sincerely,

Pranav.

Re: [PATCH] staging: vt6655: Remove extra blank lines between code blocks

[Dan Carpenter]

On Thu, Jan 11, 2024 at 03:38:16PM +0530, Pranav Athreya wrote:
> On Thu, Jan 11, 2024 at 2:57 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > Yes, please read the kernel documentation for how to submit a new
> > version of a patch.
> 
> Reading the docs now and will send the patch right after. My sincere
> apologies for the top posting.

I have a blog about how to send a v2 patch.  (v3 patch now I guess).

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

regards,
dan carpenter

Re: [PATCH] staging: vt6655: Remove extra blank lines between code blocks

[Pranav Athreya]

On Thu, Jan 11, 2024 at 4:38 PM Dan Carpenter <dan.carpenter@linaro.org> wrote:
> I have a blog about how to send a v2 patch.  (v3 patch now I guess).
>
> https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
Thanks Dan, I will take a look at this! Also, why do you say it is a
v3 patch now?

Yours Sincerely,

Pranav.