From: Greg KH <gregkh@linuxfoundation.org>
To: Jacob Lott <jklott.git@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rts5208: Add more details to Kconfig help
Date: Thu, 18 Jan 2024 16:48:49 +0100 [thread overview]
Message-ID: <2024011854-hardship-undivided-b714@gregkh> (raw)
In-Reply-To: <20240118154044.68425-1-jklott.git@gmail.com>
On Thu, Jan 18, 2024 at 10:40:44AM -0500, Jacob Lott wrote:
> The current help text is short and triggers a
> warning from checkpatch.pl. This patch adds more
> details to the help text which should provide better information
> for whether or not to enable the driver.
Please wrap your lines at 72 columns.
> Signed-off-by: Jacob Lott <jklott.git@gmail.com>
> ---
> drivers/staging/rts5208/Kconfig | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rts5208/Kconfig b/drivers/staging/rts5208/Kconfig
> index b864023d3ccb..76a083fbe401 100644
> --- a/drivers/staging/rts5208/Kconfig
> +++ b/drivers/staging/rts5208/Kconfig
> @@ -3,7 +3,11 @@ config RTS5208
> tristate "Realtek PCI-E Card Reader RTS5208/5288 support"
> depends on PCI && SCSI
> help
> - Say Y here to include driver code to support the Realtek
> - PCI-E card reader rts5208/rts5288.
> + Choose Y here to enable support for the Realtek PCI-E card reader RTS5208/5288.
No tab? Didn't checkpatch complain about this when you ran it on this
patch?
> + This driver facilitates communication between the Linux kernel and the Realtek
> + PCI-E card reader.
>
> - If this driver is compiled as a module, it will be named rts5208.
> + If you opt to compile this driver as a module, it will be named rts5208. Selecting
> + N will exclude this driver from the kernel build. Choose option Y if your system includes
> + the Realtek PCI-E card reader rts5208/rts5288. When in doubt, it is generally safe
> + to select N.
Wrap your lines properly here at 80 columns.
thanks,
greg k-h
next prev parent reply other threads:[~2024-01-18 15:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 15:40 [PATCH] staging: rts5208: Add more details to Kconfig help Jacob Lott
2024-01-18 15:48 ` Greg KH [this message]
2024-01-18 15:59 ` Jacob Lott
2024-01-18 15:50 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024011854-hardship-undivided-b714@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=jklott.git@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox