From: Meir Elisha <meir6264@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans de Goede <hdegoede@redhat.com>,
Ruan Jinjie <ruanjinjie@huawei.com>,
Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Meir Elisha <meir6264@Gmail.com>
Subject: [PATCH v2 4/4] Staging: rtl8723bs: fix else after break warning
Date: Thu, 1 Feb 2024 16:04:59 +0200 [thread overview]
Message-ID: <20240201140459.438479-5-meir6264@Gmail.com> (raw)
In-Reply-To: <20240201140459.438479-1-meir6264@Gmail.com>
Fix checkpatch warning:
else is not generally useful after a break or return
Signed-off-by: Meir Elisha <meir6264@Gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 40 +++++++++--------------
1 file changed, 16 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 13bc0ebca247..6a9b57fd1a97 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -1498,30 +1498,25 @@ void _rtw_join_timeout_handler(struct timer_list *t)
spin_lock_bh(&pmlmepriv->lock);
- if (rtw_to_roam(adapter) > 0) { /* join timeout caused by roaming */
+ if (rtw_to_roam(adapter) == 0) {
+ rtw_indicate_disconnect(adapter);
+ free_scanqueue(pmlmepriv);
+ /* indicate disconnect for the case that join_timeout
+ * and check_fwstate != FW_LINKED
+ */
+ rtw_cfg80211_indicate_disconnect(adapter);
+ } else { /* join timeout caused by roaming */
while (1) {
rtw_dec_to_roam(adapter);
- if (rtw_to_roam(adapter) != 0) { /* try another */
- int do_join_r;
-
- do_join_r = rtw_do_join(adapter);
- if (do_join_r != _SUCCESS)
- continue;
-
- break;
- } else {
+ if (rtw_to_roam(adapter) == 0) {
rtw_indicate_disconnect(adapter);
break;
+ } else if (rtw_do_join(adapter) != _SUCCESS) { /* try another */
+ continue;
}
- }
-
- } else {
- rtw_indicate_disconnect(adapter);
- free_scanqueue(pmlmepriv);/* */
-
- /* indicate disconnect for the case that join_timeout and check_fwstate != FW_LINKED */
- rtw_cfg80211_indicate_disconnect(adapter);
+ break;
+ }
}
spin_unlock_bh(&pmlmepriv->lock);
@@ -2052,12 +2047,9 @@ signed int rtw_restruct_sec_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, u
}
iEntry = SecIsInPMKIDList(adapter, pmlmepriv->assoc_bssid);
- if (iEntry < 0) {
- return ielength;
- } else {
- if (authmode == WLAN_EID_RSN)
- ielength = rtw_append_pmkid(adapter, iEntry, out_ie, ielength);
- }
+ if (iEntry > 0 && authmode == WLAN_EID_RSN)
+ ielength = rtw_append_pmkid(adapter, iEntry, out_ie, ielength);
+
return ielength;
}
--
2.34.1
next prev parent reply other threads:[~2024-02-01 14:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 14:04 [PATCH v2 0/4] Staging: rtl8723bs: checkpatch fixes for rtw_mlme.c Meir Elisha
2024-02-01 14:04 ` [PATCH v2 1/4] Staging: rtl8723bs: Remove unnecessary braces Meir Elisha
2024-02-01 14:04 ` [PATCH v2 2/4] Staging: rtl8723bs: Remove extra spaces Meir Elisha
2024-02-02 7:21 ` Dan Carpenter
2024-02-01 14:04 ` [PATCH v2 3/4] Staging: rtl8723bs: Fix block comments warning Meir Elisha
2024-02-01 14:04 ` Meir Elisha [this message]
2024-02-02 8:00 ` [PATCH v2 4/4] Staging: rtl8723bs: fix else after break warning Dan Carpenter
2024-02-01 21:26 ` [PATCH v2 0/4] Staging: rtl8723bs: checkpatch fixes for rtw_mlme.c Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201140459.438479-5-meir6264@Gmail.com \
--to=meir6264@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=ruanjinjie@huawei.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox