public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ettore Forgiarini <ettorenigma@gmail.com>
Cc: richardcochran@gmail.com, ozlinux@hotmail.com,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Staging: octeon: octeon-stubs: remove all typedef
Date: Sun, 4 Feb 2024 17:23:54 -0800	[thread overview]
Message-ID: <2024020433-flyover-humorless-5a3c@gregkh> (raw)
In-Reply-To: <20240204153603.1373700-1-ettorenigma@gmail.com>

On Sun, Feb 04, 2024 at 04:36:03PM +0100, Ettore Forgiarini wrote:
> Removed all typedef so the code conform with code style
> 
> Signed-off-by: Ettore Forgiarini <ettorenigma@gmail.com>
> ---
>  drivers/staging/octeon/octeon-stubs.h | 48 +++++++++++++--------------
>  1 file changed, 24 insertions(+), 24 deletions(-)

Also, most importantly, this breaks the build, ALWAYS test build your
patches at the very least.

thanks,

greg k-h

  parent reply	other threads:[~2024-02-05  1:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-04 15:36 [PATCH 2/2] Staging: octeon: octeon-stubs: remove all typedef Ettore Forgiarini
2024-02-05  1:23 ` Greg KH
2024-02-05  1:23 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-02-04  9:21 Ettore Forgiarini
2024-02-04 12:52 ` Greg KH
2024-02-05  6:08 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024020433-flyover-humorless-5a3c@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=ettorenigma@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=ozlinux@hotmail.com \
    --cc=richardcochran@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox